Skip to contentSkip to conversation

Dockerfile: provide kernel for libguestfs-tools

PATCH New Heinrich Schuchardt 2 participants 6 messages Jul 14, 2020 – Jul 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Dockerfile: provide kernel for libguestfs-tools

The libguestfs-tools use QEMU to mount an image file. This requires a Linux kernel.

On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal users (chmod 600), cf.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725

Install a kernel and make it readable for all users (chmod 644).

---
v2:
add link to Ubuntu bug report

---
 Dockerfile | 4 ++++
 1 file changed, 4 insertions(+)
Dockerfile +4 -0
index bc3cdee..aac7f01 100644
@@ -68,6 +68,7 @@ RUN apt-get update && apt-get install -y \
 	libssl-dev \
 	libudev-dev \
 	libusb-1.0-0-dev \
+	linux-image-kvm \
 	lzma-alone \
 	lzop \
 	mount \
@@ -94,6 +95,9 @@ RUN apt-get update && apt-get install -y \
 	zip \
 	&& rm -rf /var/lib/apt/lists/*
 
+# libguestfs-tools runs the kernel via QEMU. Give normal users access.
+RUN chmod 644 /boot/vmlinu*
+
 # Manually install libmpfr4 for the toolchains
 RUN wget http://mirrors.kernel.org/ubuntu/pool/main/m/mpfr4/libmpfr4_3.1.4-1_amd64.deb && dpkg -i libmpfr4_3.1.4-1_amd64.deb && rm libmpfr4_3.1.4-1_amd64.deb
 

--
2.27.0

#1 lore raw

PATCH v2 1/1 Dockerfile: provide kernel for libguestfs-tools

Quoted 10 lines · Heinrich Schuchardt

The libguestfs-tools use QEMU to mount an image file. This requires a Linux kernel.

On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal users (chmod 600), cf.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725

Install a kernel and make it readable for all users (chmod 644).

This causes the tests to fail now that they're trying to use libguestfs-tools:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/124872

I did a quick change to pass in the KVM group to useradd as well, but that didn't catch. I suspect that changing /dev/kvm inside the container won't stick either. But that shouldn't be fatal as it's still fast enough.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200714/bd1125fc/attachment.sig>
#2 lore raw

PATCH v2 1/1 Dockerfile: provide kernel for libguestfs-tools

Am 14. Juli 2020 23:28:21 MESZ schrieb Tom Rini <[email protected]>:

Quoted 19 lines · Heinrich Schuchardt
Quoted 2 lines

The libguestfs-tools use QEMU to mount an image file. This requires a

Linux

Quoted 3 lines

kernel.

On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal

users

Quoted 6 lines

(chmod 600), cf.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725

Install a kernel and make it readable for all users (chmod 644).

This causes the tests to fail now that they're trying to use libguestfs-tools:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/124872

Quoted 5 lines

I did a quick change to pass in the KVM group to useradd as well, but that didn't catch. I suspect that changing /dev/kvm inside the container won't stick either. But that shouldn't be fatal as it's still
fast enough.

KVM requires docker --privileged according to what I read.

Tests failing that were not excercised before seems to be a step into the right direction. - But a lot of work before us.

Thanks for the update.

Best regards

Heinrich

#3 lore raw

PATCH v2 1/1 Dockerfile: provide kernel for libguestfs-tools

Quoted 26 lines · Heinrich Schuchardt

Am 14. Juli 2020 23:28:21 MESZ schrieb Tom Rini <[email protected]>:

Quoted 19 lines · Heinrich Schuchardt
Quoted 2 lines

The libguestfs-tools use QEMU to mount an image file. This requires a

Linux

Quoted 3 lines

kernel.

On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal

users

Quoted 6 lines

(chmod 600), cf.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725

Install a kernel and make it readable for all users (chmod 644).

This causes the tests to fail now that they're trying to use libguestfs-tools:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/124872

Quoted 5 lines

I did a quick change to pass in the KVM group to useradd as well, but that didn't catch. I suspect that changing /dev/kvm inside the container won't stick either. But that shouldn't be fatal as it's still
fast enough.

Quoted 3 lines

KVM requires docker --privileged according to what I read.

Tests failing that were not excercised before seems to be a step into the right direction. - But a lot of work before us.

It's not progress as they do pass when I apply the patch I posted the other day to fix sudo'ing the tests. And we may need to have an off-list chat to make sure everyone with a runner is configured consistently.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200714/9dce583b/attachment.sig>
#4 lore raw

PATCH v2 1/1 Dockerfile: provide kernel for libguestfs-tools

Quoted 27 lines · Tom Rini
Quoted 26 lines · Heinrich Schuchardt

Am 14. Juli 2020 23:28:21 MESZ schrieb Tom Rini <[email protected]>:

Quoted 24 lines · Heinrich Schuchardt
Quoted 2 lines

The libguestfs-tools use QEMU to mount an image file. This requires a

Linux

Quoted 3 lines

kernel.

On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal

users

Quoted 6 lines

(chmod 600), cf.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725

Install a kernel and make it readable for all users (chmod 644).

This causes the tests to fail now that they're trying to use libguestfs-tools:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/124872

I did a quick change to pass in the KVM group to useradd as well, but that didn't catch. I suspect that changing /dev/kvm inside the container won't stick either. But that shouldn't be fatal as it's still
fast enough.

Quoted 6 lines
Quoted 3 lines

KVM requires docker --privileged according to what I read.

Tests failing that were not excercised before seems to be a step into the right direction. - But a lot of work before us.

It's not progress as they do pass when I apply the patch I posted the other day to fix sudo'ing the tests. And we may need to have an

Which patch do you relate to?

Quoted 3 lines

off-list chat to make sure everyone with a runner is configured consistently.

You marked this patch as "changes requested". It is unclear to me what change you are requesting for this patch.

Best regards

Heinrich

#5 lore raw

PATCH v2 1/1 Dockerfile: provide kernel for libguestfs-tools

Quoted 28 lines · Heinrich Schuchardt
Quoted 27 lines · Tom Rini
Quoted 26 lines · Heinrich Schuchardt

Am 14. Juli 2020 23:28:21 MESZ schrieb Tom Rini <[email protected]>:

Quoted 24 lines · Heinrich Schuchardt
Quoted 2 lines

The libguestfs-tools use QEMU to mount an image file. This requires a

Linux

Quoted 3 lines

kernel.

On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal

users

Quoted 6 lines

(chmod 600), cf.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725

Install a kernel and make it readable for all users (chmod 644).

This causes the tests to fail now that they're trying to use libguestfs-tools:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/124872

I did a quick change to pass in the KVM group to useradd as well, but that didn't catch. I suspect that changing /dev/kvm inside the container won't stick either. But that shouldn't be fatal as it's still
fast enough.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

KVM requires docker --privileged according to what I read.

Tests failing that were not excercised before seems to be a step into the right direction. - But a lot of work before us.

It's not progress as they do pass when I apply the patch I posted the other day to fix sudo'ing the tests. And we may need to have an

Which patch do you relate to?

http://patchwork.ozlabs.org/project/uboot/patch/20200709134225.10412-1-trini at konsulko.com/

Quoted 6 lines
Quoted 3 lines

off-list chat to make sure everyone with a runner is configured consistently.

You marked this patch as "changes requested". It is unclear to me what change you are requesting for this patch.

We need something, I'm not sure what, that moves us from "tests run and pass on travis, are skipped on GitLab and are skipped on Azure" to at least "tests run and pass on travis, run and pass on GitLab and are skipped on Azure". I believe we just won't have the required privileges to run the tests on Azure.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200720/e6cbc90a/attachment.sig>