media: i2c: fix error check on max9286_read call
PATCH 1/1 media: i2c: fix error check on max9286_read call
From: Colin Ian King <[email protected]>
Currently the error return from the call to max9286_read is masked with 0xf0 so the following check for a negative error return is never true. Fix this by checking for an error first, then masking the return value for subsequent conflink_mask checking.
Addresses-Coverity: ("Logically dead code")
--- drivers/media/i2c/max9286.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/max9286.c +2 -1
@@ -405,10 +405,11 @@ static int max9286_check_config_link(struct max9286_priv *priv,* to 5 milliseconds. */ for (i =0 ; i <10 ; i++) { - ret =max9286_read (priv,0x49 ) &0xf0 ; + ret =max9286_read (priv,0x49 );if (ret <0 )return -EIO ; + ret &=0xf0 ;if (ret = conflink_mask)break ;
Signature · 1 line
2.27.0
Hi Colin,
Quoted 6 lines · Colin King
From: Colin Ian King <[email protected]>
Currently the error return from the call to
max9286_readis masked with0xf0so the following check for a negative error return is never true. Fix this by checking for an error first, then masking the return value for subsequentconflink_maskchecking.
Ooops!
Quoted 3 lines
Addresses-Coverity: ("Logically dead code")
Fixes 66d8c9d2422d ("media: i2c: Add MAX9286 driver")Signed-off-by Colin Ian King <[email protected]>
Thanks,
Quoted 22 lines
--- drivers/media/i2c/max9286.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/media/i2c/max9286.c +2
-1@@ -405,10 +405,11 @@ static int max9286_check_config_link(struct max9286_priv *priv,* to 5 milliseconds. */ for (i =0 ; i <10 ; i++) { - ret =max9286_read (priv,0x49 ) &0xf0 ; + ret =max9286_read (priv,0x49 );if (ret <0 )return -EIO ; + ret &=0xf0 ;if (ret = conflink_mask)break ;