Skip to contentSkip to conversation

video: fbdev: pvr2fb: initialize variables

PATCH Applied [email protected] 3 participants 3 messages Jul 20, 2020 – Aug 3, 2020 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fbdev: pvr2fb: initialize variables

From: Tom Rix <[email protected]>

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
is an uninitialized value [core.CallAndMessage]

        if (*cable_arg)
        ^~~~~~~~~~~~~~~

Problem is that cable_arg depends on the input loop to set the cable_arg[0]. If it does not, then some random value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

---
 drivers/video/fbdev/pvr2fb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/video/fbdev/pvr2fb.c +2 -0
index 2d9f69b93392..f4add36cb5f4 100644
@@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options)
 	if (!options || !*options)
 		return 0;
 
+	cable_arg[0] = output_arg[0] = 0;
+
 	while ((this_opt = strsep(&options, ","))) {
 		if (!*this_opt)
 			continue;
Signature · 1 line
2.18.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Mon, Jul 20, 2020 at 9:19 PM <[email protected]> wrote:

From: Tom Rix <[email protected]>

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
is an uninitialized value [core.CallAndMessage]

        if (*cable_arg)
        ^~~~~~~~~~~~~~~
Quoted 7 lines

Problem is that cable_arg depends on the input loop to set the cable_arg[0]. If it does not, then some random value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Adding a zero-initialization is almost never the correct way to deal with these warnings, so one has to be careful doing this.

I checked this file, and your patch is absolutely correct here. ;-)

Quoted 1 line
Applied
#2 lore raw
In reply to [email protected]

Hi Tom,

Quoted 13 lines · On Mon, Jul 20, 2020 at 12:18:45PM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
is an uninitialized value [core.CallAndMessage]

        if (*cable_arg)
        ^~~~~~~~~~~~~~~

Problem is that cable_arg depends on the input loop to set the cable_arg[0]. If it does not, then some random value from the stack is used.

Quoted 5 lines

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Thanks, applied to drm-misc-next.

Sam

Quoted 24 lines
---
 drivers/video/fbdev/pvr2fb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/video/fbdev/pvr2fb.c +2 -0
index 2d9f69b93392..f4add36cb5f4 100644
@@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options)
 	if (!options || !*options)
 		return 0;
 
+	cable_arg[0] = output_arg[0] = 0;
+
 	while ((this_opt = strsep(&options, ","))) {
 		if (!*this_opt)
 			continue;
Signature · 6 lines
2.18.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel