Skip to contentSkip to conversation

dt-bindings: hwmon: adm1272: add analog-temperature1-enable binding

PATCH Superseded Chu Lin 2 participants 2 messages Jul 20, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Chu Lin

author
#0 lore raw

PATCH v2 1/1 dt-bindings: hwmon: adm1272: add analog-temperature1-enable binding

Problem:
adm1272 and adm1278 supports temperature sampling. The
current way of enabling it requires the user manually unbind the device from the driver, flip the temperature sampling control bit and then bind the device back to the driver. It would be nice if we can control this in a better way by reading the dt.

Solution:
Introducing device tree binding analog-temperature1-enable. If the
flag is set, flip the temp1_en control bit on probing.

Testing:
make dt_binding_check

---
ChangeLog v1->v2:
- Rename adm1272-adm1278-temp1-en to analog-temperature1-enable

 Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/hwmon/adm1275.txt +3 -0
index 1ecd03f3da4d..7a345c7794a2 100644
@@ -15,6 +15,8 @@ Optional properties:
 
 - shunt-resistor-micro-ohms
 	Shunt resistor value in micro-Ohm
+- analog-temperature1-enable
+	Enable temperature sampling. This is supported on adm1272 and adm1278
 
 Example:
 
@@ -22,4 +24,5 @@ adm1272@10 {
 	compatible = "adi,adm1272";
 	reg = <0x10>;
 	shunt-resistor-micro-ohms = <500>;
+	analog-temperature1-enable;
 };
Signature · 1 line
2.28.0.rc0.105.gf9edc3c819-goog
maintainer
#1 lore raw
Quoted 11 lines · Chu Lin

Problem:
adm1272 and adm1278 supports temperature sampling. The
current way of enabling it requires the user manually unbind the device from the driver, flip the temperature sampling control bit and then bind the device back to the driver. It would be nice if we can control this in a better way by reading the dt.

Solution:
Introducing device tree binding analog-temperature1-enable. If the
flag is set, flip the temp1_en control bit on probing.

Quoted 7 lines

Testing:
make dt_binding_check

---
ChangeLog v1->v2:
- Rename adm1272-adm1278-temp1-en to analog-temperature1-enable

This needs to be either analog,temperature1-enable or analog,temp1-enable (comma instead of '-').

Thanks,
Guenter

Quoted 26 lines
 Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/hwmon/adm1275.txt +3 -0
index 1ecd03f3da4d..7a345c7794a2 100644
@@ -15,6 +15,8 @@ Optional properties:
 
 - shunt-resistor-micro-ohms
 	Shunt resistor value in micro-Ohm
+- analog-temperature1-enable
+	Enable temperature sampling. This is supported on adm1272 and adm1278
 
 Example:
 
@@ -22,4 +24,5 @@ adm1272@10 {
 	compatible = "adi,adm1272";
 	reg = <0x10>;
 	shunt-resistor-micro-ohms = <500>;
+	analog-temperature1-enable;
 };
Signature · 1 line
2.28.0.rc0.105.gf9edc3c819-goog