Skip to contentSkip to conversation

freebsd: remove freebsd- hostflags request from guest tests

PATCH In review Roger Pau Monne 2 participants 2 messages Jul 21, 2020 – Jul 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 freebsd: remove freebsd- hostflags request from guest tests

Guest tests shouldn't care about the capabilities or firmware of the underlying hosts, so drop the request of specific freebsd-<version> hostflags for FreeBSD guest tests.

While there request the presence of the hvm hostflag since the FreeBSD guest tests are run in HVM mode.

---
 make-flight | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
make-flight +3 -3
index b8942c1c..2ea9ad29 100755
@@ -241,7 +241,7 @@ do_freebsd_tests () {
       job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-freebsd10-$freebsdarch \
                       test-freebsd xl $xenarch $dom0arch freebsd_arch=$freebsdarch \
  freebsd_image=${FREEBSD_IMAGE_PREFIX-FreeBSD-10.1-CUSTOM-}$freebsdarch${FREEBSD_IMAGE_SUFFIX--20150525.raw.xz} \
-                      all_hostflags=$most_hostflags,freebsd-10
+                      all_hostflags=$most_hostflags,hvm
     done
     return
   fi
@@ -251,11 +251,11 @@ do_freebsd_tests () {
     job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-freebsd11-$freebsdarch \
                     test-freebsd xl $xenarch $dom0arch freebsd_arch=$freebsdarch \
  freebsd_image=${FREEBSD_IMAGE_PREFIX-FreeBSD-11.3-RELEASE-}$freebsdarch${FREEBSD_IMAGE_SUFFIX-.raw.xz} \
-                    all_hostflags=$most_hostflags,freebsd-11
+                    all_hostflags=$most_hostflags,hvm
     job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-freebsd12-$freebsdarch \
                     test-freebsd xl $xenarch $dom0arch freebsd_arch=$freebsdarch \
  freebsd_image=${FREEBSD_IMAGE_PREFIX-FreeBSD-12.1-RELEASE-}$freebsdarch${FREEBSD_IMAGE_SUFFIX-.raw.xz} \
-                    all_hostflags=$most_hostflags,freebsd-12
+                    all_hostflags=$most_hostflags,hvm
   done
 }
 
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw

Roger Pau Monne writes ("[osstest PATCH] freebsd: remove freebsd- hostflags request from guest tests"):

Quoted 8 lines

Guest tests shouldn't care about the capabilities or firmware of the underlying hosts, so drop the request of specific freebsd-<version> hostflags for FreeBSD guest tests.

While there request the presence of the hvm hostflag since the FreeBSD guest tests are run in HVM mode.

I have queued this for the next push to pretest which I hope to do some time today.

Thanks,
Ian.