Skip to contentSkip to conversation

common/qat: remove unused fields

PATCH Applied Adam Dybkowski 3 participants 3 messages Jul 21, 2020 – Jul 26, 2020 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/qat: remove unused fields

This patch removes unused fields from structs qat_qp and qat_qp_config, together with their initializations.

---
 drivers/common/qat/qat_qp.c         | 1 -
 drivers/common/qat/qat_qp.h         | 8 +-------
 drivers/compress/qat/qat_comp_pmd.c | 1 -
 drivers/crypto/qat/qat_asym_pmd.c   | 1 -
 drivers/crypto/qat/qat_sym_pmd.c    | 1 -
 5 files changed, 1 insertion(+), 11 deletions(-)
drivers/common/qat/qat_qp.c +0 -1
index aacd4ab21..f7e478a4f 100644
@@ -292,7 +292,6 @@ int qat_qp_setup(struct qat_pci_device *qat_dev,
 	}
 
 	qp->qat_dev_gen = qat_dev->qat_dev_gen;
-	qp->build_request = qat_qp_conf->build_request;
 	qp->service_type = qat_qp_conf->hw->service_type;
 	qp->qat_dev = qat_dev;
 
drivers/common/qat/qat_qp.h +1 -7
index 575d69059..74f7e7dae 100644
@@ -14,11 +14,6 @@ struct qat_pci_device;
 
 #define QAT_QP_MIN_INFL_THRESHOLD	256
 
-typedef int (*build_request_t)(void *op,
-		uint8_t *req, void *op_cookie,
-		enum qat_device_gen qat_dev_gen);
-/**< Build a request from an op. */
-
 /**
  * Structure with data needed for creation of queue pair.
  */
@@ -30,6 +25,7 @@ struct qat_qp_hw_data {
 	uint16_t tx_msg_size;
 	uint16_t rx_msg_size;
 };
+
 /**
  * Structure with data needed for creation of queue pair.
  */
@@ -38,7 +34,6 @@ struct qat_qp_config {
 	uint32_t nb_descriptors;
 	uint32_t cookie_size;
 	int socket_id;
-	build_request_t build_request;
 	const char *service_str;
 };
 
@@ -73,7 +68,6 @@ struct qat_qp {
 	void **op_cookies;
 	uint32_t nb_descriptors;
 	enum qat_device_gen qat_dev_gen;
-	build_request_t build_request;
 	enum qat_service_type service_type;
 	struct qat_pci_device *qat_dev;
 	/**< qat device this qp is on */
drivers/compress/qat/qat_comp_pmd.c +0 -1
index 73e23c018..311e56168 100644
@@ -124,7 +124,6 @@ qat_comp_qp_setup(struct rte_compressdev *dev, uint16_t qp_id,
 	}
 
 	qat_qp_conf.hw = qp_hw_data;
-	qat_qp_conf.build_request = qat_comp_build_request;
 	qat_qp_conf.cookie_size = sizeof(struct qat_comp_op_cookie);
 	qat_qp_conf.nb_descriptors = max_inflight_ops;
 	qat_qp_conf.socket_id = socket_id;
drivers/crypto/qat/qat_asym_pmd.c +0 -1
index 968ec54ee..ed8a2a50b 100644
@@ -145,7 +145,6 @@ static int qat_asym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
 	}
 
 	qat_qp_conf.hw = qp_hw_data;
-	qat_qp_conf.build_request = qat_asym_build_request;
 	qat_qp_conf.cookie_size = sizeof(struct qat_asym_op_cookie);
 	qat_qp_conf.nb_descriptors = qp_conf->nb_descriptors;
 	qat_qp_conf.socket_id = socket_id;
drivers/crypto/qat/qat_sym_pmd.c +0 -1
index c7e323cce..50626754b 100644
@@ -181,7 +181,6 @@ static int qat_sym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
 	}
 
 	qat_qp_conf.hw = qp_hw_data;
-	qat_qp_conf.build_request = qat_sym_build_request;
 	qat_qp_conf.cookie_size = sizeof(struct qat_sym_op_cookie);
 	qat_qp_conf.nb_descriptors = qp_conf->nb_descriptors;
 	qat_qp_conf.socket_id = socket_id;
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Tuesday, July 21, 2020 2:37 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] common/qat: remove unused fields

Quoted 4 lines

This patch removes unused fields from structs qat_qp and qat_qp_config, together with their initializations.