Skip to contentSkip to conversation

serial: Fix incorrect dependency for debug sifive serial driver

PATCH New Sean Anderson 2 participants 3 messages Jul 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: Fix incorrect dependency for debug sifive serial driver

The debug sifive serial driver depends on the wrong serial driver, making it unselectable.

Fixes 4cc24aeaf42 ("serial: Add missing Kconfig dependencies for debug

consoles")

---

 drivers/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/Kconfig +1 -1
index 14df2e9247..e146ffc5f8 100644
@@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
 
 config DEBUG_UART_SIFIVE
 	bool "SiFive UART"
-	depends on PL01X_SERIAL
+	depends on SIFIVE_SERIAL
 	help
 	  Select this to enable a debug UART using the serial_sifive driver. You
 	  will need to provide parameters to make this work. The driver will
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 serial: Fix incorrect dependency for debug sifive serial driver

Hi Sean,

Quoted 19 lines · Sean Anderson

The debug sifive serial driver depends on the wrong serial driver, making it unselectable.

Fixes 4cc24aeaf42 ("serial: Add missing Kconfig dependencies for debug

consoles")

---

 drivers/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/Kconfig +0 -0
index 14df2e9247..e146ffc5f8 100644

drivers/serial/Kconfig config DEBUG_UART_SANDBOX · line 365

Quoted 8 lines
drivers/serial/Kconfig +1 -1
@@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
 
 config DEBUG_UART_SIFIVE
 	bool "SiFive UART"
-	depends on PL01X_SERIAL
+	depends on SIFIVE_SERIAL
 	help
 	  Select this to enable a debug UART using the serial_sifive driver. You
 	  will need to provide parameters to make this work. The driver will

I have already sent a fix for it.
https://lists.denx.de/pipermail/u-boot/2020-July/419649.html

Please ack.

Thanks,
Michal

#2 lore raw

PATCH 1/1 serial: Fix incorrect dependency for debug sifive serial driver

Quoted 34 lines · Michal Simek

Hi Sean,

Quoted 19 lines · Sean Anderson

The debug sifive serial driver depends on the wrong serial driver, making it unselectable.

Fixes 4cc24aeaf42 ("serial: Add missing Kconfig dependencies for debug

consoles")

---

 drivers/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/Kconfig +0 -0
index 14df2e9247..e146ffc5f8 100644

drivers/serial/Kconfig config DEBUG_UART_SANDBOX · line 365

Quoted 8 lines
drivers/serial/Kconfig +1 -1
@@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
 
 config DEBUG_UART_SIFIVE
 	bool "SiFive UART"
-	depends on PL01X_SERIAL
+	depends on SIFIVE_SERIAL
 	help
 	  Select this to enable a debug UART using the serial_sifive driver. You
 	  will need to provide parameters to make this work. The driver will

I have already sent a fix for it.
https://lists.denx.de/pipermail/u-boot/2020-July/419649.html

Quoted 5 lines

Please ack.

Thanks,
Michal

Ah, thanks. I only found this when I needed to use the debug serial and I couldn't select anything.

--Sean