platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes
Subsystems (3)
v2 cover platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes
The EC reports a variety of error codes. Most of those, with the exception of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the actual error code gets lost. In cros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.
To prepare for this change, handle error codes other than -EPROTO for all callers of cros_ec_cmd_xfer_status(). Specifically, no longer assume that -EPROTO reflects an error from the EC and all other error codes reflect a transfer error.
v2: Add patches 1/4 to 3/4 to handle callers of cros_ec_cmd_xfer_status()
----------------------------------------------------------------
Guenter Roeck (4):
iio: cros_ec: Accept -EOPNOTSUPP as 'not supported' error code
cros_ec_lightbar: Accept more error codes from cros_ec_cmd_xfer_status platform/chrome: cros_ec_sysfs: Report range of error codes from EC platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes
.../iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 +- drivers/platform/chrome/cros_ec_lightbar.c | 10 +++--- drivers/platform/chrome/cros_ec_proto.c | 37 +++++++++++++++++----- drivers/platform/chrome/cros_ec_sysfs.c | 24 ++++++-------- 4 files changed, 43 insertions(+), 30 deletions(-)
PATCH v2 1/4 iio: cros_ec: Accept -EOPNOTSUPP as 'not supported' error code
A follow-up patch will extend the number of errors reported by cros_ec_cmd_xfer_status(). Specifically, the function will return -EOPNOTSUPP if a command is not supported by the EC. Prepare for it.
---
v2: Added patch
drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c +1 -1
@@ -73,7 +73,7 @@ static int cros_ec_sensors_read(struct iio_dev *indio_dev, st->core.param.sensor_offset.flags =0 ; ret =cros_ec_motion_send_host_cmd (&st->core,0 ); -if (ret == -EPROTO ) { +if (ret == -EPROTO || ret == -EOPNOTSUPP ) {/* Reading calibscale is not supported on older EC. */ *val =1 ; *val2 =0 ;
Signature · 1 line
2.17.1
Re: [PATCH v2 1/4] iio: cros_ec: Accept -EOPNOTSUPP as 'not supported' error code
Quoted 7 lines · On Mon, 20 Jul 2020 13:22:40 -0700 Guenter Roeck <[email protected]> wrote:
A follow-up patch will extend the number of errors reported by
cros_ec_cmd_xfer_status(). Specifically, the function will return-EOPNOTSUPPif a command is not supported by the EC. Prepare for it.Cc Yu-Hsuan Hsu <[email protected]>Cc Prashant Malani <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Quoted 19 lines
---
v2: Added patchdrivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c +1
-1@@ -73,7 +73,7 @@ static int cros_ec_sensors_read(struct iio_dev *indio_dev, st->core.param.sensor_offset.flags =0 ; ret =cros_ec_motion_send_host_cmd (&st->core,0 ); -if (ret == -EPROTO ) { +if (ret == -EPROTO || ret == -EOPNOTSUPP ) {/* Reading calibscale is not supported on older EC. */ *val =1 ; *val2 =0 ;
PATCH v2 2/4 cros_ec_lightbar: Accept more error codes from cros_ec_cmd_xfer_status
In reply to Guenter RoeckSince commit c5cd2b47b203 ("platform/chrome: cros_ec_proto: Report command not supported") we can no longer assume that cros_ec_cmd_xfer_status() reports -EPROTO for all errors returned by the EC itself. A follow-up patch will change cros_ec_cmd_xfer_status() to report additional errors reported by the EC as distinguished Linux error codes.
Handle this change by no longer assuming that -EPROTO is used to report all errors returned by the EC itself. Since errors reported by the EC are already reported in text form through sysfs attributes, extend this form of error reporting to all errors reported by cros_ec_cmd_xfer_status().
---
v2: Added patch
drivers/platform/chrome/cros_ec_lightbar.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/platform/chrome/cros_ec_lightbar.c +4 -6
@@ -117,7 +117,7 @@ static int get_lightbar_version(struct cros_ec_dev *ec, param = (struct ec_params_lightbar *)msg->data; param->cmd =LIGHTBAR_CMD_VERSION ; ret =cros_ec_cmd_xfer_status (ec->ec_dev, msg); -if (ret <0 ) { +if (ret <0 && ret != -EINVAL ) { ret =0 ; goto exit; }
@@ -298,11 +298,9 @@ static ssize_t sequence_show(struct device *dev, goto exit; ret =cros_ec_cmd_xfer_status (ec->ec_dev, msg); -if (ret == -EPROTO ) { - ret =scnprintf (buf,PAGE_SIZE , -"ERROR: EC returned %d\n" , msg->result); - goto exit; - }else if (ret <0 ) { +if (ret <0 ) { + ret =scnprintf (buf,PAGE_SIZE ,"XFER / EC ERROR %d / %d\n" , + ret, msg->result); goto exit; }
Signature · 1 line
2.17.1
PATCH v2 3/4 platform/chrome: cros_ec_sysfs: Report range of error codes from EC
In reply to Guenter RoeckSince commit c5cd2b47b203 ("platform/chrome: cros_ec_proto: Report command not supported") we can no longer assume that cros_ec_cmd_xfer_status() reports -EPROTO for all errors returned by the EC itself. A follow-up patch will change cros_ec_cmd_xfer_status() to report additional errors reported by the EC as distinguished Linux error codes.
Prepare for this change by always reporting both the Linux error code and the EC error code in sysfs attributes.
---
v2: Added patch
drivers/platform/chrome/cros_ec_sysfs.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-)
drivers/platform/chrome/cros_ec_sysfs.c +9 -15
@@ -150,12 +150,10 @@ static ssize_t version_show(struct device *dev, msg->command =EC_CMD_GET_BUILD_INFO + ec->cmd_offset; msg->insize =EC_HOST_PARAM_SIZE ; ret =cros_ec_cmd_xfer_status (ec->ec_dev, msg); -if (ret == -EPROTO ) { - count +=scnprintf (buf + count,PAGE_SIZE - count, -"Build info: EC error %d\n" , msg->result); - }else if (ret <0 ) { +if (ret <0 ) { count +=scnprintf (buf + count,PAGE_SIZE - count, -"Build info: XFER ERROR %d\n" , ret); +"Build info: XFER / EC ERROR %d / %d\n" , + ret, msg->result); }else { msg->data[EC_HOST_PARAM_SIZE -1 ] ='\0' ; count += scnprintf(buf + count, PAGE_SIZE - count,
@@ -166,12 +164,10 @@ static ssize_t version_show(struct device *dev, msg->command =EC_CMD_GET_CHIP_INFO + ec->cmd_offset; msg->insize =sizeof (*r_chip); ret =cros_ec_cmd_xfer_status (ec->ec_dev, msg); -if (ret == -EPROTO ) { - count +=scnprintf (buf + count,PAGE_SIZE - count, -"Chip info: EC error %d\n" , msg->result); - }else if (ret <0 ) { +if (ret <0 ) { count +=scnprintf (buf + count,PAGE_SIZE - count, -"Chip info: XFER ERROR %d\n" , ret); +"Chip info: XFER / EC ERROR %d / %d\n" , + ret, msg->result); }else { r_chip = (struct ec_response_get_chip_info *)msg->data;
@@ -190,12 +186,10 @@ static ssize_t version_show(struct device *dev, msg->command =EC_CMD_GET_BOARD_VERSION + ec->cmd_offset; msg->insize =sizeof (*r_board); ret =cros_ec_cmd_xfer_status (ec->ec_dev, msg); -if (ret == -EPROTO ) { - count +=scnprintf (buf + count,PAGE_SIZE - count, -"Board version: EC error %d\n" , msg->result); - }else if (ret <0 ) { +if (ret <0 ) { count +=scnprintf (buf + count,PAGE_SIZE - count, -"Board version: XFER ERROR %d\n" , ret); +"Board version: XFER / EC ERROR %d / %d\n" , + ret, msg->result); }else { r_board = (struct ec_response_board_version *)msg->data;
Signature · 1 line
2.17.1
PATCH v2 4/4 platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes
In reply to Guenter RoeckThe EC reports a variety of error codes. Most of those, with the exception of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the actual error code gets lost. In cros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.
---
v2: No change
Notes:
I would welcome feedback on the error code translations. Can we do better ?
-ENOTSUPP is not a recommended error code, and checkpatch complains about it. It is used in existing code, so I did not change it, but it might be worthwhile exploring if we can find a better error code to report "version not supported". Possible candidates might be EPROTOTYPE, ENOPROTOOPT, EPROTONOSUPPORT, EPFNOSUPPORT, or EAFNOSUPPORT. I don't see a direct match, but NFS reports -EPROTONOSUPPORT for unsupported protocol versions.
drivers/platform/chrome/cros_ec_proto.c | 37 +++++++++++++++++++------ 1 file changed, 29 insertions(+), 8 deletions(-)
drivers/platform/chrome/cros_ec_proto.c +29 -8
@@ -543,6 +543,29 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, }EXPORT_SYMBOL (cros_ec_cmd_xfer); +static const int cros_ec_error_map[] = { + [EC_RES_INVALID_COMMAND ] = -EOPNOTSUPP , + [EC_RES_ERROR ] = -EIO , + [EC_RES_INVALID_PARAM ] = -EINVAL , + [EC_RES_ACCESS_DENIED ] = -EACCES , + [EC_RES_INVALID_RESPONSE ] = -EPROTO , + [EC_RES_INVALID_VERSION ] = -ENOTSUPP , + [EC_RES_INVALID_CHECKSUM ] = -EBADMSG , + [EC_RES_IN_PROGRESS ] = -EINPROGRESS , + [EC_RES_UNAVAILABLE ] = -ENODATA , + [EC_RES_TIMEOUT ] = -ETIMEDOUT , + [EC_RES_OVERFLOW ] = -EOVERFLOW , + [EC_RES_INVALID_HEADER ] = -EBADR , + [EC_RES_REQUEST_TRUNCATED ] = -EBADR , + [EC_RES_RESPONSE_TOO_BIG ] = -EFBIG , + [EC_RES_BUS_ERROR ] = -EFAULT , + [EC_RES_BUSY ] = -EBUSY , + [EC_RES_INVALID_HEADER_VERSION ] = -EBADMSG , + [EC_RES_INVALID_HEADER_CRC ] = -EBADMSG , + [EC_RES_INVALID_DATA_CRC ] = -EBADMSG , + [EC_RES_DUP_UNAVAILABLE ] = -ENODATA , +}; +/** * cros_ec_cmd_xfer_status() - Send a command to the ChromeOS EC. * @ec_dev: EC device.
@@ -555,8 +578,7 @@ EXPORT_SYMBOL(cros_ec_cmd_xfer);* * Return: * >=0 - The number of bytes transferred -* -ENOTSUPP - Operation not supported -* -EPROTO - Protocol error +* <0 - Linux error code */ int cros_ec_cmd_xfer_status (struct cros_ec_device *ec_dev,struct cros_ec_command *msg)
@@ -566,13 +588,12 @@ int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, ret =cros_ec_cmd_xfer (ec_dev, msg);if (ret <0 ) {dev_err (ec_dev->dev,"Command xfer error (err:%d)\n" , ret); - }else if (msg->result ==EC_RES_INVALID_VERSION ) { -dev_dbg (ec_dev->dev,"Command invalid version (err:%d)\n" , - msg->result); -return -ENOTSUPP ; }else if (msg->result !=EC_RES_SUCCESS ) { -dev_dbg (ec_dev->dev,"Command result (err: %d)\n" , msg->result); -return -EPROTO ; +if (msg->result <ARRAY_SIZE (cros_ec_error_map) && cros_ec_error_map[msg->result]) + ret = cros_ec_error_map[msg->result]; +else + ret = -EPROTO ; +dev_dbg (ec_dev->dev,"Command result (err: %d [%d])\n" , msg->result, ret); }return ret;
Signature · 1 line
2.17.1
Hi Guenter,
Thank you for work on this. Cc'ing Gwendal as he has a deep knowledge of the EC and their errors.
Quoted 32 lines · Guenter Roeck
The EC reports a variety of error codes. Most of those, with the exception of
EC_RES_INVALID_VERSION, are converted to-EPROTO. As result, the actual error code gets lost. Incros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.Cc Yu-Hsuan Hsu <[email protected]>Cc Prashant Malani <[email protected]>Signed-off-by Guenter Roeck <[email protected]>---
v2: No changeNotes:
I would welcome feedback on the error code translations. Can we do better ?
-ENOTSUPPis not a recommended error code, and checkpatch complains about it. It is used in existing code, so I did not change it, but it might be worthwhile exploring if we can find a better error code to report "version not supported". Possible candidates might be EPROTOTYPE, ENOPROTOOPT, EPROTONOSUPPORT, EPFNOSUPPORT, or EAFNOSUPPORT. I don't see a direct match, but NFS reports-EPROTONOSUPPORTfor unsupported protocol versions.drivers/platform/chrome/cros_ec_proto.c | 37 +++++++++++++++++++------ 1 file changed, 29 insertions(+), 8 deletions(-)drivers/platform/chrome/cros_ec_proto.c +0
-0
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 548
Quoted 6 lines
drivers/platform/chrome/cros_ec_proto.c +3
-0@@ -543,6 +543,29 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, }EXPORT_SYMBOL (cros_ec_cmd_xfer); +static const int cros_ec_error_map[] = { + [EC_RES_INVALID_COMMAND ] = -EOPNOTSUPP , + [EC_RES_ERROR ] = -EIO ,
nit -EREMOTEIO? To make explicit that the error is "remote" from the host. Although -EIO seems to be more generic.
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 552
Quoted 4 lines
drivers/platform/chrome/cros_ec_proto.c +4
-0+ [EC_RES_INVALID_PARAM] = -EINVAL, + [EC_RES_ACCESS_DENIED] = -EACCES, + [EC_RES_INVALID_RESPONSE] = -EPROTO, + [EC_RES_INVALID_VERSION] = -ENOTSUPP,
+1 for EPROTONOSUPPORT to match with EC_RES_INVALID_VERSION
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 562
Quoted 10 lines
drivers/platform/chrome/cros_ec_proto.c +10
-0+ [EC_RES_INVALID_CHECKSUM] = -EBADMSG, + [EC_RES_IN_PROGRESS] = -EINPROGRESS, + [EC_RES_UNAVAILABLE] = -ENODATA, + [EC_RES_TIMEOUT] = -ETIMEDOUT, + [EC_RES_OVERFLOW] = -EOVERFLOW, + [EC_RES_INVALID_HEADER] = -EBADR, + [EC_RES_REQUEST_TRUNCATED] = -EBADR, + [EC_RES_RESPONSE_TOO_BIG] = -EFBIG, + [EC_RES_BUS_ERROR] = -EFAULT, + [EC_RES_BUSY] = -EBUSY,
Although the name matches, I'm wondering if we should use -EAGAIN instead as per EC documentation:
EC_RES_BUSY - Up but too busy. Should retry.
hmm, however, for the audio codec, for example, this seems to have a slightly different meaning and retry is not what we want, so let's do direct translation and stay with -EBUSY.
Quoted 39 lines
drivers/platform/chrome/cros_ec_proto.c +12
-8+ [EC_RES_INVALID_HEADER_VERSION] = -EBADMSG, + [EC_RES_INVALID_HEADER_CRC] = -EBADMSG, + [EC_RES_INVALID_DATA_CRC] = -EBADMSG, + [EC_RES_DUP_UNAVAILABLE] = -ENODATA, +}; +/** * cros_ec_cmd_xfer_status() - Send a command to the ChromeOS EC. * @ec_dev: EC device. @@ -555,8 +578,7 @@ EXPORT_SYMBOL(cros_ec_cmd_xfer);* * Return: * >=0 - The number of bytes transferred -* -ENOTSUPP - Operation not supported -* -EPROTO - Protocol error +* <0 - Linux error code */ int cros_ec_cmd_xfer_status (struct cros_ec_device *ec_dev,struct cros_ec_command *msg)@@ -566,13 +588,12 @@ int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, ret =cros_ec_cmd_xfer (ec_dev, msg);if (ret <0 ) {dev_err (ec_dev->dev,"Command xfer error (err:%d)\n" , ret); - }else if (msg->result ==EC_RES_INVALID_VERSION ) { -dev_dbg (ec_dev->dev,"Command invalid version (err:%d)\n" , - msg->result); -return -ENOTSUPP ; }else if (msg->result !=EC_RES_SUCCESS ) { -dev_dbg (ec_dev->dev,"Command result (err: %d)\n" , msg->result); -return -EPROTO ; +if (msg->result <ARRAY_SIZE (cros_ec_error_map) && cros_ec_error_map[msg->result]) + ret = cros_ec_error_map[msg->result]; +else + ret = -EPROTO ; +dev_dbg (ec_dev->dev,"Command result (err: %d [%d])\n" , msg->result, ret); }return ret;
Hi Enric,
Quoted 4 lines · Enric Balletbo i Serra
Hi Guenter,
Thank you for work on this. Cc'ing Gwendal as he has a deep knowledge of the EC and their errors.
The series is now also available in Gerrit at
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2306731/3
for integration/testing into ChromeOS.
Thanks,
Guenter
Quoted 110 lines · Guenter Roeck
Quoted 32 lines
The EC reports a variety of error codes. Most of those, with the exception of
EC_RES_INVALID_VERSION, are converted to-EPROTO. As result, the actual error code gets lost. Incros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.Cc Yu-Hsuan Hsu <[email protected]>Cc Prashant Malani <[email protected]>Signed-off-by Guenter Roeck <[email protected]>---
v2: No changeNotes:
I would welcome feedback on the error code translations. Can we do better ?
-ENOTSUPPis not a recommended error code, and checkpatch complains about it. It is used in existing code, so I did not change it, but it might be worthwhile exploring if we can find a better error code to report "version not supported". Possible candidates might be EPROTOTYPE, ENOPROTOOPT, EPROTONOSUPPORT, EPFNOSUPPORT, or EAFNOSUPPORT. I don't see a direct match, but NFS reports-EPROTONOSUPPORTfor unsupported protocol versions.drivers/platform/chrome/cros_ec_proto.c | 37 +++++++++++++++++++------ 1 file changed, 29 insertions(+), 8 deletions(-)drivers/platform/chrome/cros_ec_proto.c +0
-0drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 548
Quoted 6 lines
drivers/platform/chrome/cros_ec_proto.c +3
-0@@ -543,6 +543,29 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, }EXPORT_SYMBOL (cros_ec_cmd_xfer); +static const int cros_ec_error_map[] = { + [EC_RES_INVALID_COMMAND ] = -EOPNOTSUPP , + [EC_RES_ERROR ] = -EIO ,nit
-EREMOTEIO? To make explicit that the error is "remote" from the host. Although-EIOseems to be more generic.drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 552
Quoted 4 lines
drivers/platform/chrome/cros_ec_proto.c +4
-0+ [EC_RES_INVALID_PARAM] = -EINVAL, + [EC_RES_ACCESS_DENIED] = -EACCES, + [EC_RES_INVALID_RESPONSE] = -EPROTO, + [EC_RES_INVALID_VERSION] = -ENOTSUPP,+1 for EPROTONOSUPPORT to match with
EC_RES_INVALID_VERSIONdrivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 562
Quoted 10 lines
drivers/platform/chrome/cros_ec_proto.c +10
-0+ [EC_RES_INVALID_CHECKSUM] = -EBADMSG, + [EC_RES_IN_PROGRESS] = -EINPROGRESS, + [EC_RES_UNAVAILABLE] = -ENODATA, + [EC_RES_TIMEOUT] = -ETIMEDOUT, + [EC_RES_OVERFLOW] = -EOVERFLOW, + [EC_RES_INVALID_HEADER] = -EBADR, + [EC_RES_REQUEST_TRUNCATED] = -EBADR, + [EC_RES_RESPONSE_TOO_BIG] = -EFBIG, + [EC_RES_BUS_ERROR] = -EFAULT, + [EC_RES_BUSY] = -EBUSY,Although the name matches, I'm wondering if we should use
-EAGAINinstead as per EC documentation:
EC_RES_BUSY- Up but too busy. Should retry.hmm, however, for the audio codec, for example, this seems to have a slightly different meaning and retry is not what we want, so let's do direct translation and stay with
-EBUSY.Quoted 39 lines
drivers/platform/chrome/cros_ec_proto.c +12
-8+ [EC_RES_INVALID_HEADER_VERSION] = -EBADMSG, + [EC_RES_INVALID_HEADER_CRC] = -EBADMSG, + [EC_RES_INVALID_DATA_CRC] = -EBADMSG, + [EC_RES_DUP_UNAVAILABLE] = -ENODATA, +}; +/** * cros_ec_cmd_xfer_status() - Send a command to the ChromeOS EC. * @ec_dev: EC device. @@ -555,8 +578,7 @@ EXPORT_SYMBOL(cros_ec_cmd_xfer);* * Return: * >=0 - The number of bytes transferred -* -ENOTSUPP - Operation not supported -* -EPROTO - Protocol error +* <0 - Linux error code */ int cros_ec_cmd_xfer_status (struct cros_ec_device *ec_dev,struct cros_ec_command *msg)@@ -566,13 +588,12 @@ int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, ret =cros_ec_cmd_xfer (ec_dev, msg);if (ret <0 ) {dev_err (ec_dev->dev,"Command xfer error (err:%d)\n" , ret); - }else if (msg->result ==EC_RES_INVALID_VERSION ) { -dev_dbg (ec_dev->dev,"Command invalid version (err:%d)\n" , - msg->result); -return -ENOTSUPP ; }else if (msg->result !=EC_RES_SUCCESS ) { -dev_dbg (ec_dev->dev,"Command result (err: %d)\n" , msg->result); -return -EPROTO ; +if (msg->result <ARRAY_SIZE (cros_ec_error_map) && cros_ec_error_map[msg->result]) + ret = cros_ec_error_map[msg->result]; +else + ret = -EPROTO ; +dev_dbg (ec_dev->dev,"Command result (err: %d [%d])\n" , msg->result, ret); }return ret;
Quoted 41 lines · Enric Balletbo i Serra
Hi Guenter,
Thank you for work on this. Cc'ing Gwendal as he has a deep knowledge of the EC and their errors.
Quoted 35 lines · Guenter Roeck
The EC reports a variety of error codes. Most of those, with the exception of
EC_RES_INVALID_VERSION, are converted to-EPROTO. As result, the actual error code gets lost. Incros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.Cc Yu-Hsuan Hsu <[email protected]>Cc Prashant Malani <[email protected]>Signed-off-by Guenter Roeck <[email protected]>---
v2: No changeNotes:
I would welcome feedback on the error code translations. Can we do better ?
-ENOTSUPPis not a recommended error code, and checkpatch complains about it. It is used in existing code, so I did not change it, but it might be worthwhile exploring if we can find a better error code to report "version not supported". Possible candidates might be EPROTOTYPE, ENOPROTOOPT, EPROTONOSUPPORT, EPFNOSUPPORT, or EAFNOSUPPORT. I don't see a direct match, but NFS reports-EPROTONOSUPPORTfor unsupported protocol versions.drivers/platform/chrome/cros_ec_proto.c | 37 +++++++++++++++++++------ 1 file changed, 29 insertions(+), 8 deletions(-)drivers/platform/chrome/cros_ec_proto.c +0
-0@@ -543,6 +543,29 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, }EXPORT_SYMBOL (cros_ec_cmd_xfer);
Quoted 7 lines
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 548
Quoted 3 lines
drivers/platform/chrome/cros_ec_proto.c +3
-0+static const int cros_ec_error_map[] = { + [EC_RES_INVALID_COMMAND ] = -EOPNOTSUPP , + [EC_RES_ERROR ] = -EIO ,nit
-EREMOTEIO? To make explicit that the error is "remote" from the host. Although-EIOseems to be more generic.
I think using -EREMOTEIO is a good idea; some SPI/I2C controller error might return -EIO.
Quoted 7 lines
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 552
Quoted 4 lines
drivers/platform/chrome/cros_ec_proto.c +4
-0+ [EC_RES_INVALID_PARAM] = -EINVAL, + [EC_RES_ACCESS_DENIED] = -EACCES, + [EC_RES_INVALID_RESPONSE] = -EPROTO, + [EC_RES_INVALID_VERSION] = -ENOTSUPP,+1 for EPROTONOSUPPORT to match with
EC_RES_INVALID_VERSION
Ok. I'll do that with a separate patch.
Quoted 14 lines
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 562
Quoted 10 lines
drivers/platform/chrome/cros_ec_proto.c +10
-0+ [EC_RES_INVALID_CHECKSUM] = -EBADMSG, + [EC_RES_IN_PROGRESS] = -EINPROGRESS, + [EC_RES_UNAVAILABLE] = -ENODATA, + [EC_RES_TIMEOUT] = -ETIMEDOUT, + [EC_RES_OVERFLOW] = -EOVERFLOW, + [EC_RES_INVALID_HEADER] = -EBADR, + [EC_RES_REQUEST_TRUNCATED] = -EBADR, + [EC_RES_RESPONSE_TOO_BIG] = -EFBIG, + [EC_RES_BUS_ERROR] = -EFAULT, + [EC_RES_BUSY] = -EBUSY,Although the name matches, I'm wondering if we should use
-EAGAINinstead as per EC documentation:
Quoted 7 lines
EC_RES_BUSY- Up but too busy. Should retry.hmm, however, for the audio codec, for example, this seems to have a slightly different meaning and retry is not what we want, so let's do direct translation and stay with
-EBUSY.drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 563
Quoted 1 line
drivers/platform/chrome/cros_ec_proto.c +1
-0+ [EC_RES_INVALID_HEADER_VERSION] = -EBADMSG,
Any idea for EC_RES_INVALID_HEADER_VERSION ? I am not entirely happy with -EBADMSG: the error is distinctly different to CRC errors. EPROTONOSUPPORT as well, maybe, or something else ?
Thanks,
Guenter
Quoted 38 lines
Quoted 38 lines
drivers/platform/chrome/cros_ec_proto.c +11
-8+ [EC_RES_INVALID_HEADER_CRC] = -EBADMSG, + [EC_RES_INVALID_DATA_CRC] = -EBADMSG, + [EC_RES_DUP_UNAVAILABLE] = -ENODATA, +}; +/** * cros_ec_cmd_xfer_status() - Send a command to the ChromeOS EC. * @ec_dev: EC device. @@ -555,8 +578,7 @@ EXPORT_SYMBOL(cros_ec_cmd_xfer);* * Return: * >=0 - The number of bytes transferred -* -ENOTSUPP - Operation not supported -* -EPROTO - Protocol error +* <0 - Linux error code */ int cros_ec_cmd_xfer_status (struct cros_ec_device *ec_dev,struct cros_ec_command *msg)@@ -566,13 +588,12 @@ int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, ret =cros_ec_cmd_xfer (ec_dev, msg);if (ret <0 ) {dev_err (ec_dev->dev,"Command xfer error (err:%d)\n" , ret); - }else if (msg->result ==EC_RES_INVALID_VERSION ) { -dev_dbg (ec_dev->dev,"Command invalid version (err:%d)\n" , - msg->result); -return -ENOTSUPP ; }else if (msg->result !=EC_RES_SUCCESS ) { -dev_dbg (ec_dev->dev,"Command result (err: %d)\n" , msg->result); -return -EPROTO ; +if (msg->result <ARRAY_SIZE (cros_ec_error_map) && cros_ec_error_map[msg->result]) + ret = cros_ec_error_map[msg->result]; +else + ret = -EPROTO ; +dev_dbg (ec_dev->dev,"Command result (err: %d [%d])\n" , msg->result, ret); }return ret;
+ drinkcat, aseda
Quoted 7 lines · Guenter Roeck
Quoted 2 lines · Enric Balletbo i Serra
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 563
Quoted 1 line · Guenter Roeck
drivers/platform/chrome/cros_ec_proto.c +1
-0+ [EC_RES_INVALID_HEADER_VERSION] = -EBADMSG,Any idea for
EC_RES_INVALID_HEADER_VERSION? I am not entirely happy with-EBADMSG: the error is distinctly different to CRC errors. EPROTONOSUPPORT as well, maybe, or something else ?
FWIW, these (INVALID_HEADER_VERSION, INVALID_HEADER_CRC, INVALID_DATA_CRC) aren't actually used on any firmware yet. This has been open forever:
https://crbug.com/787159
Added here:
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/780452/
Unfortunately, the linked design doc (still in draft) is not public.
My understanding is that while they're not all exactly the same (CRC is different than the others), they are all still supposed to represent "corrupt request [from the Application Processor]". EBADMSG seems good enough to me.
Brian
P.S. for those added late -- you can grab the whole thread from here:
https://lore.kernel.org/lkml/[email protected]/
or in mbox form:
https://lore.kernel.org/lkml/[email protected]/t.mbox.gz
Quoted 18 lines · Brian Norris
+ drinkcat, aseda
Quoted 7 lines · Guenter Roeck
Quoted 2 lines · Enric Balletbo i Serra
drivers/platform/chrome/cros_ec_proto.c int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, · line 563
Quoted 1 line · Guenter Roeck
drivers/platform/chrome/cros_ec_proto.c +1
-0+ [EC_RES_INVALID_HEADER_VERSION] = -EBADMSG,Any idea for
EC_RES_INVALID_HEADER_VERSION? I am not entirely happy with-EBADMSG: the error is distinctly different to CRC errors. EPROTONOSUPPORT as well, maybe, or something else ?FWIW, these (
INVALID_HEADER_VERSION,INVALID_HEADER_CRC,INVALID_DATA_CRC) aren't actually used on any firmware yet. This has been open forever:
https://crbug.com/787159
Added here:
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/780452/
Quoted 7 lines
Unfortunately, the linked design doc (still in draft) is not public.
My understanding is that while they're not all exactly the same (CRC is different than the others), they are all still supposed to represent "corrupt request [from the Application Processor]". EBADMSG seems good enough to me.
SGTM, and make sense.
Thanks,
Guenter
Quoted 7 lines
Brian
P.S. for those added late -- you can grab the whole thread from here:
https://lore.kernel.org/lkml/[email protected]/
or in mbox form:
https://lore.kernel.org/lkml/[email protected]/t.mbox.gz
Hi Guenter,
Quoted 6 lines · Guenter Roeck
The EC reports a variety of error codes. Most of those, with the exception of
EC_RES_INVALID_VERSION, are converted to-EPROTO. As result, the actual error code gets lost. Incros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.
Quoted 6 lines
To prepare for this change, handle error codes other than
-EPROTOfor all callers ofcros_ec_cmd_xfer_status(). Specifically, no longer assume that-EPROTOreflects an error from the EC and all other error codes reflect a transfer error.v2: Add patches 1/4 to 3/4 to handle callers of
cros_ec_cmd_xfer_status()
I did a rough grep to see what you might be missing:
git grep -n EPROTO | grep -e cros -e '-ec'
I think cros-ec-pwm / cros_ec_num_pwms() might need fixing too? Boy, I wrote that, but it sure ain't easy to read...(*checks watch*)...4 years later.
Apart from the notes already made, I think the series looks good:
Feel free to CC me on v3, if you want another look
Brian
Hi Brian,
Quoted 14 lines · Brian Norris
Hi Guenter,
Quoted 11 lines · Guenter Roeck
The EC reports a variety of error codes. Most of those, with the exception of
EC_RES_INVALID_VERSION, are converted to-EPROTO. As result, the actual error code gets lost. Incros_ec_cmd_xfer_status(), convert all EC errors to Linux error codes to report a more meaningful error to the caller to aid debugging.To prepare for this change, handle error codes other than
-EPROTOfor all callers ofcros_ec_cmd_xfer_status(). Specifically, no longer assume that-EPROTOreflects an error from the EC and all other error codes reflect a transfer error.
Quoted 7 lines
Quoted 1 line
v2: Add patches 1/4 to 3/4 to handle callers of
cros_ec_cmd_xfer_status()I did a rough grep to see what you might be missing:
git grep -n EPROTO | grep -e cros -e '-ec'
I think cros-ec-pwm /
cros_ec_num_pwms()might need fixing too? Boy, I
Yes, you are correct. And there was me thinking I got them all. Thanks a lot !
Quoted 3 lines
wrote that, but it sure ain't easy to read...(*checks watch*)...4 years later.
Usually I am quite embarrassed by code I wrote more than a couple of years ago :-)
Quoted 5 lines
Apart from the notes already made, I think the series looks good:
Reviewed-by Brian Norris <[email protected]>Quoted 1 line
Feel free to CC me on v3, if you want another look
I'll be happy to do that. I did make a couple of changes, so I'll add your Reviewed-by: only to unchanged patches.
Thanks,
Guenter