Skip to contentSkip to conversation

crypto/qat: add DOCSIS performance optimization

PATCH Superseded David Coyle 3 participants 4 messages Jul 20, 2020 – Jul 26, 2020 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/qat: add DOCSIS performance optimization

DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")
---
 drivers/common/qat/qat_qp.c  |  2 +
 drivers/crypto/qat/qat_sym.c | 75 ++++++++----------------------------
 drivers/crypto/qat/qat_sym.h | 57 +++++++++++++++++++++++++++
 3 files changed, 76 insertions(+), 58 deletions(-)
drivers/common/qat/qat_qp.c +2 -0
index aacd4ab21..6fd836fdb 100644
@@ -627,6 +627,8 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 		}
 	}
 
+	if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC)
+		qat_sym_preprocess_requests(ops, nb_ops_possible);
 
 	while (nb_ops_sent != nb_ops_possible) {
 		if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC) {
drivers/crypto/qat/qat_sym.c +17 -58

106 lines not on this page · raw message

drivers/crypto/qat/qat_sym.h +57 -0

69 lines not on this page · raw message

Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 crypto/qat: add DOCSIS performance optimization

DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")

---
v2:
* Added '#ifdef BUILD_QAT_SYM' guard around call to qat_sym_preprocess_requests() in driver/common/qat_qp.c

 drivers/common/qat/qat_qp.c  |  4 ++
 drivers/crypto/qat/qat_sym.c | 75 ++++++++----------------------------
 drivers/crypto/qat/qat_sym.h | 57 +++++++++++++++++++++++++++
 3 files changed, 78 insertions(+), 58 deletions(-)
drivers/common/qat/qat_qp.c +4 -0
index aacd4ab21..953873933 100644
@@ -627,6 +627,10 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 		}
 	}
 
+#ifdef BUILD_QAT_SYM
+	if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC)
+		qat_sym_preprocess_requests(ops, nb_ops_possible);
+#endif
 
 	while (nb_ops_sent != nb_ops_possible) {
 		if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC) {
drivers/crypto/qat/qat_sym.c +17 -58

106 lines not on this page · raw message

drivers/crypto/qat/qat_sym.h +57 -0

69 lines not on this page · raw message

Signature · 1 line
2.17.1
Acked-by on v2 1/1
#2 lore raw
Quoted 11 lines

-----Original Message-----
From: Coyle, David <[email protected]>
Sent: Tuesday, July 21, 2020 3:47 PM
To: Trahe, Fiona <[email protected]>; [email protected]
Cc: [email protected]; Ryan, Brendan <[email protected]>; O'loingsigh, Mairtin <[email protected]>; Doherty, Declan <[email protected]>; De Lara Guarch, Pablo <[email protected]>; Coyle, David <[email protected]>
Subject: [PATCH v2] crypto/qat: add DOCSIS performance optimization

Quoted 8 lines

DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")
Applied
#3 lore raw
Quoted 10 lines
Quoted 9 lines

DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")

Applied to dpdk-next-crypto

Thanks.