net: mdio-mux-gpio: use devm_gpiod_get_array()
Subsystems (3)
PATCH 1/1 net: mdio-mux-gpio: use devm_gpiod_get_array()
Use devm_gpiod_get_array() to simplify the error handling and exit code path.
Signed-off-by Jisheng Zhang <[email protected]>
--- drivers/net/phy/mdio-mux-gpio.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/net/phy/mdio-mux-gpio.c +3 -8
@@ -42,25 +42,21 @@ static int mdio_mux_gpio_probe(struct platform_device *pdev)struct gpio_descs *gpios;int r; - gpios =gpiod_get_array (&pdev->dev,NULL ,GPIOD_OUT_LOW ); + gpios =devm_gpiod_get_array (&pdev->dev,NULL ,GPIOD_OUT_LOW );if (IS_ERR (gpios))return PTR_ERR (gpios); s =devm_kzalloc (&pdev->dev,sizeof (*s),GFP_KERNEL ); -if (!s) { -gpiod_put_array (gpios); +if (!s)return -ENOMEM ; - } s->gpios = gpios; r =mdio_mux_init (&pdev->dev, pdev->dev.of_node, mdio_mux_gpio_switch_fn, &s->mux_handle, s,NULL ); -if (r !=0 ) { -gpiod_put_array (s->gpios); +if (r !=0 )return r; - } pdev->dev.platform_data = s;return 0 ;
@@ -70,7 +66,6 @@ static int mdio_mux_gpio_remove(struct platform_device *pdev) {struct mdio_mux_gpio_state *s =dev_get_platdata (&pdev->dev);mdio_mux_uninit (s->mux_handle); -gpiod_put_array (s->gpios);return 0 ; }
Signature · 1 line
2.28.0.rc0
From: Jisheng Zhang <[email protected]>
Date: Tue, 21 Jul 2020 15:01:57 +0800
Quoted 4 lines
Use
devm_gpiod_get_array()to simplify the error handling and exit code path.Signed-off-by Jisheng Zhang <[email protected]>
Applied.