Skip to contentSkip to conversation

scsi: lpfc: Add dependency on CPU_FREQ

PATCH Applied Guenter Roeck 3 participants 3 messages Jul 22, 2020 – Jul 25, 2020 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: lpfc: Add dependency on CPU_FREQ

Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment"), the lpfc driver depends on CPUFREQ. Without it, builds fail with

drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
implicit declaration of function 'get_cpu_idle_time'

Add the missing dependency.

Fixes 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
Cc Dick Kennedy <[email protected]>
Cc James Smart <[email protected]>
---
 drivers/scsi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/Kconfig +1 -0
index 571473a58f98..701b61ec76ee 100644
@@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
 config SCSI_LPFC
 	tristate "Emulex LightPulse Fibre Channel Support"
 	depends on PCI && SCSI
+	depends on CPU_FREQ
 	depends on SCSI_FC_ATTRS
 	depends on NVME_TARGET_FC || NVME_TARGET_FC=n
 	depends on NVME_FC || NVME_FC=n
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Guenter Roeck

Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment"), the lpfc driver depends on CPUFREQ. Without it, builds fail with

drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
implicit declaration of function 'get_cpu_idle_time'

Add the missing dependency.

Fixes 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
Cc Dick Kennedy <[email protected]>
Cc James Smart <[email protected]>
---
  drivers/scsi/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/scsi/Kconfig +0 -0
index 571473a58f98..701b61ec76ee 100644

drivers/scsi/Kconfig source "drivers/scsi/qedf/Kconfig" · line 1160

Quoted 7 lines
drivers/scsi/Kconfig +1 -0
@@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
  config SCSI_LPFC
  	tristate "Emulex LightPulse Fibre Channel Support"
  	depends on PCI && SCSI
+	depends on CPU_FREQ
  	depends on SCSI_FC_ATTRS
  	depends on NVME_TARGET_FC || NVME_TARGET_FC=n
  	depends on NVME_FC || NVME_FC=n

-- james

#2 lore raw
In reply to Guenter Roeck
Quoted 9 lines · Guenter Roeck

Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment"), the lpfc driver depends on CPUFREQ. Without it, builds fail with

drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
implicit declaration of function 'get_cpu_idle_time'

[...]

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: lpfc: Add dependency on CPU_FREQ

      https://git.kernel.org/mkp/scsi/c/e3d2bf6505dd
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering