Skip to contentSkip to conversation

PCI: rcar-gen2: Use fallthrough pseudo-keyword

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages Jul 22, 2020 – Sep 7, 2020

Subsystems (4)
PCI Arm/RISC-V/Renesas architecture PCI native host bridge and endpoint drivers PCI driver for Renesas R-Car
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH v2 1/1 PCI: rcar-gen2: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Reviewed-by Geert Uytterhoeven <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>

---
Changes in v2:
- Update URL. Use proper URL to Linux v5.7 documentation.
- Add Geert's Reviewed-by tag.
- Update changelog text.

 drivers/pci/controller/pci-rcar-gen2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-rcar-gen2.c +1 -1
index 326171cb1a97..2ec7093a7588 100644
@@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
 		pr_warn("unknown window size %ld - defaulting to 256M\n",
 			priv->window_size);
 		priv->window_size = SZ_256M;
-		/* fall-through */
+		fallthrough;
 	case SZ_256M:
 		val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
 		break;
Signature · 1 line
2.27.0
maintainer Reviewed-by on v2 1/1
#1 lore raw

Hi,

Quoted 10 lines

From: Gustavo A. R. Silva, Sent: Wednesday, July 22, 2020 12:29 PM

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].

[1]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Reviewed-by Geert Uytterhoeven <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>

Thank you for the patch!

Reviewed-by Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

Applied
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 7 lines · Gustavo A. R. Silva

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Reviewed-by Geert Uytterhoeven <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
Quoted 8 lines

---
Changes in v2:
- Update URL. Use proper URL to Linux v5.7 documentation.
- Add Geert's Reviewed-by tag.
- Update changelog text.

 drivers/pci/controller/pci-rcar-gen2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/rcar, thanks.

Lorenzo

Quoted 16 lines
drivers/pci/controller/pci-rcar-gen2.c +1 -1
index 326171cb1a97..2ec7093a7588 100644
@@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
 		pr_warn("unknown window size %ld - defaulting to 256M\n",
 			priv->window_size);
 		priv->window_size = SZ_256M;
-		/* fall-through */
+		fallthrough;
 	case SZ_256M:
 		val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
 		break;
Signature · 1 line
2.27.0