Skip to contentSkip to conversation

hw/isa/isa-bus: Ensure ISA I/O regions are 8/16-bit accessible

RFC In review Philippe Mathieu-Daudé 3 participants 5 messages Jul 20, 2020 – Jul 22, 2020

lore
Share & tools
lore
#0 lore raw

RFC v2 1/1 hw/isa/isa-bus: Ensure ISA I/O regions are 8/16-bit accessible

Since commit 5d971f9e67 we don't accept mismatching sizes in memory_region_access_valid(). This gives troubles when a device is on an ISA bus, because the CPU is free to use 8/16-bit accesses on the bus (or up to 32-bit on EISA bus), regardless what range is valid for the device.

Add a check to ensure devices plugged on the ISA bus can accept 8/16-bits accesses.

Related bug reports:

- https://lore.kernel.org/xen-devel/[email protected]/T/
- https://bugs.debian.org/964793
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964247
- https://bugs.launchpad.net/bugs/1886318

---
MST: I really don't like this approach, I think the ISA bus
should adjust the access.

since v1: only 8/16-bit accesses enforced

---
 hw/isa/isa-bus.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
hw/isa/isa-bus.c +14 -0
index 58fde178f9..e142eeef06 100644
@@ -132,6 +132,20 @@ static inline void isa_init_ioport(ISADevice *dev, uint16_t ioport)
 
 void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start)
 {
+    if (io->ops->valid.min_access_size > 1) {
+        /*
+         * To be backward compatible with IBM-PC bus, ISA bus must accept
+         * 8-bit accesses.
+         */
+        error_report("ISA device '%s' requires I/O min_access_size of 1 (byte)",
+                     object_get_typename(OBJECT(dev)));
+        exit(1);
+    } else if (io->ops->valid.max_access_size < 2) {
+        /* ISA bus must accept 16-bit accesses (EISA accepts 32-bit) */
+        error_report("ISA device '%s' requires I/O max_access_size of "
+                     "at least 2 (bytes)", object_get_typename(OBJECT(dev)));
+        exit(1);
+    }
     memory_region_add_subregion(isabus->address_space_io, start, io);
     isa_init_ioport(dev, start);
 }
Signature · 1 line
2.21.3
#1 lore raw

20.07.2020 21:57, Philippe Mathieu-Daudé пишет:

Quoted 9 lines

Since commit 5d971f9e67 we don't accept mismatching sizes in memory_region_access_valid(). This gives troubles when a device is on an ISA bus, because the CPU is free to use 8/16-bit accesses on the bus (or up to 32-bit on EISA bus), regardless what range is valid for the device.

Add a check to ensure devices plugged on the ISA bus can accept 8/16-bits accesses.

Quoted 6 lines

Related bug reports:

- https://lore.kernel.org/xen-devel/[email protected]/T/
- https://bugs.debian.org/964793
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964247
- https://bugs.launchpad.net/bugs/1886318

Here's the output (of a similar patch), after I fixed the 3 acpi core devies, of one of my windows7 test VMs. I guess we need to fix either these devices or the registration, before 5.1 is out, or else more difficult-to-catch breakage like the above will pop up..

For now we don't have any released qemu version with this situation so not many project enabled workarounds for broken qemu behavour like the xen-devel link above.

qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'mc146818rtc' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-pit' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'isa-pcspk' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'isa-serial' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'i8042' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'i8042' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'vmport' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'port92' requires I/O max_access_size of 2

Thanks,

/mjt

Quoted 36 lines

---
MST: I really don't like this approach, I think the ISA bus
should adjust the access.

since v1: only 8/16-bit accesses enforced

---
 hw/isa/isa-bus.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
hw/isa/isa-bus.c +14 -0
index 58fde178f9..e142eeef06 100644
@@ -132,6 +132,20 @@ static inline void isa_init_ioport(ISADevice *dev, uint16_t ioport)
 
 void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start)
 {
+    if (io->ops->valid.min_access_size > 1) {
+        /*
+         * To be backward compatible with IBM-PC bus, ISA bus must accept
+         * 8-bit accesses.
+         */
+        error_report("ISA device '%s' requires I/O min_access_size of 1 (byte)",
+                     object_get_typename(OBJECT(dev)));
+        exit(1);
+    } else if (io->ops->valid.max_access_size < 2) {
+        /* ISA bus must accept 16-bit accesses (EISA accepts 32-bit) */
+        error_report("ISA device '%s' requires I/O max_access_size of "
+                     "at least 2 (bytes)", object_get_typename(OBJECT(dev)));
+        exit(1);
+    }
     memory_region_add_subregion(isabus->address_space_io, start, io);
     isa_init_ioport(dev, start);
 }
#2 lore raw
Quoted 26 lines · Michael Tokarev

20.07.2020 21:57, Philippe Mathieu-Daudé пишет:

Quoted 9 lines

Since commit 5d971f9e67 we don't accept mismatching sizes in memory_region_access_valid(). This gives troubles when a device is on an ISA bus, because the CPU is free to use 8/16-bit accesses on the bus (or up to 32-bit on EISA bus), regardless what range is valid for the device.

Add a check to ensure devices plugged on the ISA bus can accept 8/16-bits accesses.

Quoted 6 lines

Related bug reports:

- https://lore.kernel.org/xen-devel/[email protected]/T/
- https://bugs.debian.org/964793
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964247
- https://bugs.launchpad.net/bugs/1886318

Here's the output (of a similar patch), after I fixed the 3 acpi core devies, of one of my windows7 test VMs. I guess we need to fix either these devices or the registration, before 5.1 is out, or else more difficult-to-catch breakage like the above will pop up..

For now we don't have any released qemu version with this situation so not many project enabled workarounds for broken qemu behavour like the xen-devel link above.

Quoted 12 lines

qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'mc146818rtc' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-pit' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'isa-pcspk' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'isa-serial' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'i8042' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'i8042' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'vmport' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'port92' requires I/O max_access_size of 2

This is better to find the full list:

$ git grep -l isa_register_ioport
hw/audio/cs4231a.c
hw/audio/pcspk.c
hw/char/serial-isa.c
hw/i386/port92.c
hw/i386/vmport.c
hw/input/pckbd.c
hw/intc/i8259_common.c
hw/ipmi/isa_ipmi_bt.c
hw/ipmi/isa_ipmi_kcs.c
hw/isa/isa-bus.c
hw/isa/pc87312.c
hw/misc/applesmc.c
hw/misc/pvpanic.c
hw/net/ne2000-isa.c
hw/rtc/m48t59-isa.c
hw/rtc/mc146818rtc.c
hw/timer/i8254_common.c
include/hw/isa/isa.h
Quoted 4 lines

Thanks,

/mjt

#3 lore raw
Quoted 1 line · Philippe Mathieu-Daudé

On 7/20/20 9:45 PM, Michael Tokarev wrote:

...

Quoted 3 lines
Quoted 3 lines

For now we don't have any released qemu version with this situation so not many project enabled workarounds for broken qemu behavour like the xen-devel link above.

Note: all of the entries below have min_access_size = max_access_size = 0 I dunno what it gives us, but it is a different issue.

Quoted 13 lines
Quoted 4 lines

qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-i8259' requires I/O max_access_size of 2

Quoted 8 lines

qemu-system-x86_64: ISA device 'mc146818rtc' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'kvm-pit' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'isa-pcspk' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'isa-serial' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'i8042' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'i8042' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'vmport' requires I/O max_access_size of 2
qemu-system-x86_64: ISA device 'port92' requires I/O max_access_size of 2

Quoted 1 line

This is better to find the full list:

I found no other entries which restrict access to >1.

/mjt

#4 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 5 lines · Philippe Mathieu-Daudé

Since commit 5d971f9e67 we don't accept mismatching sizes in memory_region_access_valid(). This gives troubles when a device is on an ISA bus, because the CPU is free to use 8/16-bit accesses on the bus (or up to 32-bit on EISA bus), regardless what range is valid for the device.

Right, but I am not sure device is guaranteed to do something sensible if the CPU does it.

Any examples where that is the case?

Quoted 9 lines

Add a check to ensure devices plugged on the ISA bus can accept 8/16-bits accesses.

Related bug reports:

- https://lore.kernel.org/xen-devel/[email protected]/T/
- https://bugs.debian.org/964793
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964247
- https://bugs.launchpad.net/bugs/1886318

These all have to do with ACPI that Michael fixed, right?

Quoted 37 lines

---
MST: I really don't like this approach, I think the ISA bus
should adjust the access.

since v1: only 8/16-bit accesses enforced

---
 hw/isa/isa-bus.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
hw/isa/isa-bus.c +14 -0
index 58fde178f9..e142eeef06 100644
@@ -132,6 +132,20 @@ static inline void isa_init_ioport(ISADevice *dev, uint16_t ioport)
 
 void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start)
 {
+    if (io->ops->valid.min_access_size > 1) {
+        /*
+         * To be backward compatible with IBM-PC bus, ISA bus must accept
+         * 8-bit accesses.
+         */
+        error_report("ISA device '%s' requires I/O min_access_size of 1 (byte)",
+                     object_get_typename(OBJECT(dev)));
+        exit(1);
+    } else if (io->ops->valid.max_access_size < 2) {
+        /* ISA bus must accept 16-bit accesses (EISA accepts 32-bit) */
+        error_report("ISA device '%s' requires I/O max_access_size of "
+                     "at least 2 (bytes)", object_get_typename(OBJECT(dev)));
+        exit(1);
+    }
     memory_region_add_subregion(isabus->address_space_io, start, io);
     isa_init_ioport(dev, start);
 }
Signature · 1 line
2.21.3