Skip to contentSkip to conversation

hw/misc/edu: support pci device state migration

PATCH Superseded Zeng Guang 2 participants 3 messages Jul 22, 2020 – Jul 23, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Zeng Guang

author
#0 lore raw

PATCH 1/1 hw/misc/edu: support pci device state migration

Currently edu device doesn't support live migration. Part of PCI configuration information would be lost after migration.

PCI device state in source VM:

     Bus  0, device   3, function 0:
     Class 0255: PCI device 1234:11e8
     PCI subsystem 1af4:1100
     IRQ 11, pin A
     BAR0: 32 bit memory at 0xfea00000 [0xfeafffff].
     id ""

PCI device state in destination VM:

     Bus  0, device   3, function 0:
     Class 0255: PCI device 1234:11e8
     PCI subsystem 1af4:1100
     IRQ 0, pin A
     BAR0: 32 bit memory at 0xffffffffffffffff [0x000ffffe].
     id ""

Add VMState for edu device to support migration.

---
 hw/misc/edu.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
hw/misc/edu.c +12 -0
index ec617e63f3..3ff2759ee1 100644
@@ -27,6 +27,7 @@
 #include "hw/pci/pci.h"
 #include "hw/hw.h"
 #include "hw/pci/msi.h"
+#include "migration/vmstate.h"
 #include "qemu/timer.h"
 #include "qemu/main-loop.h" /* iothread mutex */
 #include "qemu/module.h"
@@ -405,6 +406,16 @@ static void edu_instance_init(Object *obj)
                                    &edu->dma_mask, OBJ_PROP_FLAG_READWRITE);
 }
 
+static const VMStateDescription vmstate_edu = {
+    .name = "edu",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .fields = (VMStateField[]) {
+        VMSTATE_PCI_DEVICE(pdev, EduState),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
 static void edu_class_init(ObjectClass *class, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(class);
@@ -415,6 +426,7 @@ static void edu_class_init(ObjectClass *class, void *data)
     k->vendor_id = PCI_VENDOR_ID_QEMU;
     k->device_id = 0x11e8;
     k->revision = 0x10;
+    dc->vmsd = &vmstate_edu;
     k->class_id = PCI_CLASS_OTHERS;
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
 }
Signature · 1 line
2.17.1
#1 lore raw
Quoted 20 lines · Zeng Guang

Currently edu device doesn't support live migration. Part of PCI configuration information would be lost after migration.

PCI device state in source VM:

     Bus  0, device   3, function 0:
     Class 0255: PCI device 1234:11e8
     PCI subsystem 1af4:1100
     IRQ 11, pin A
     BAR0: 32 bit memory at 0xfea00000 [0xfeafffff].
     id ""

PCI device state in destination VM:

     Bus  0, device   3, function 0:
     Class 0255: PCI device 1234:11e8
     PCI subsystem 1af4:1100
     IRQ 0, pin A
     BAR0: 32 bit memory at 0xffffffffffffffff [0x000ffffe].
     id ""
Quoted 5 lines

Add VMState for edu device to support migration.

Hi; thanks for adding migration support for this device.

hw/misc/edu.c static void edu_instance_init(Object *obj) · line 414

Quoted 6 lines
hw/misc/edu.c +6 -0
+static const VMStateDescription vmstate_edu = {
+    .name = "edu",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .fields = (VMStateField[]) {
+        VMSTATE_PCI_DEVICE(pdev, EduState),

This isn't the only state that the device has. You
also need to migrate:
stopping, addr4, fact, status, irq_status, the struct dma_state members, the dma_timer, dma_buf and dma_mask.

thanks
-- PMM

author
#2 lore raw
Quoted 34 lines · Peter Maydell
Quoted 19 lines · Zeng Guang

Currently edu device doesn't support live migration. Part of PCI configuration information would be lost after migration.

PCI device state in source VM:

      Bus  0, device   3, function 0:
      Class 0255: PCI device 1234:11e8
      PCI subsystem 1af4:1100
      IRQ 11, pin A
      BAR0: 32 bit memory at 0xfea00000 [0xfeafffff].
      id ""

PCI device state in destination VM:

      Bus  0, device   3, function 0:
      Class 0255: PCI device 1234:11e8
      PCI subsystem 1af4:1100
      IRQ 0, pin A
      BAR0: 32 bit memory at 0xffffffffffffffff [0x000ffffe].
      id ""
Quoted 5 lines

Add VMState for edu device to support migration.

Hi; thanks for adding migration support for this device.

hw/misc/edu.c static void edu_instance_init(Object *obj) · line 414

Quoted 6 lines
hw/misc/edu.c +6 -0
+static const VMStateDescription vmstate_edu = {
+    .name = "edu",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .fields = (VMStateField[]) {
+        VMSTATE_PCI_DEVICE(pdev, EduState),
Quoted 4 lines

This isn't the only state that the device has. You
also need to migrate:
stopping, addr4, fact, status, irq_status, the struct dma_state members, the dma_timer, dma_buf and dma_mask.

Right . I will add those params in VMstate and update patch. Thanks.

Quoted 3 lines

thanks
-- PMM