remoteproc: virtio: support sharing vdev buffer
PATCH 1/1 remoteproc: virtio: support sharing vdev buffer
Support sharing vdev buffer between multiple vdevs by using name "vdevbuffer".
--- drivers/remoteproc/remoteproc_virtio.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/remoteproc/remoteproc_virtio.c +2 -0
@@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)/* Try to find dedicated vdev buffer carveout */ mem =rproc_find_carveout_by_name (rproc,"vdev%dbuffer" , rvdev->index); +if (!mem) + mem =rproc_find_carveout_by_name (rproc,"vdevbuffer" );if (mem) {phys_addr_t pa;
Signature · 1 line
2.16.4
Mathieu Poirier
maintainerHi Peng,
Quoted 14 lines · Peng Fan
Support sharing vdev buffer between multiple vdevs by using name "vdevbuffer".
Reviewed-by Richard Zhu <[email protected]>Signed-off-by Peng Fan <[email protected]>--- drivers/remoteproc/remoteproc_virtio.c | 2 ++ 1 file changed, 2 insertions(+)drivers/remoteproc/remoteproc_virtio.c +0
-0
drivers/remoteproc/remoteproc_virtio.c int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) · line 347
Quoted 5 lines
drivers/remoteproc/remoteproc_virtio.c +2
-0@@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)/* Try to find dedicated vdev buffer carveout */ mem =rproc_find_carveout_by_name (rproc,"vdev%dbuffer" , rvdev->index); +if (!mem) + mem =rproc_find_carveout_by_name (rproc,"vdevbuffer" );
We already have a way to share buffers [1], do you think it would work for you? I would rather proceed that way to avoid introducing a 3rd way to deal with vdev buffers.
Thanks,
Mathieu
[1]. https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/remoteproc/remoteproc_virtio.c#L389
Quoted 6 lines
drivers/remoteproc/remoteproc_virtio.c +0
-0if (mem) {phys_addr_t pa;Signature · 1 line
2.16.4
Hi Mathieu,
Quoted 22 lines
Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer
Hi Peng,
Quoted 17 lines · Peng Fan
Support sharing vdev buffer between multiple vdevs by using name "vdevbuffer".
Reviewed-by Richard Zhu <[email protected]>Signed-off-by Peng Fan <[email protected]>--- drivers/remoteproc/remoteproc_virtio.c | 2 ++ 1 file changed, 2 insertions(+)drivers/remoteproc/remoteproc_virtio.c +0
-0@@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
Quoted 9 lines
drivers/remoteproc/remoteproc_virtio.c int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) · line 347
Quoted 5 lines
drivers/remoteproc/remoteproc_virtio.c +2
-0/* Try to find dedicated vdev buffer carveout */ mem =rproc_find_carveout_by_name (rproc,"vdev%dbuffer" , rvdev->index); +if (!mem) + mem =rproc_find_carveout_by_name (rproc,"vdevbuffer" );We already have a way to share buffers [1], do you think it would work for you? I would rather proceed that way to avoid introducing a 3rd way to deal with vdev buffers.
That should work for me. I just need to move the vdevbuffer to the 1st one inside the memory-region.
BTW: Do you have time to give a review for
https://patchwork.kernel.org/patch/11688751/
Thanks,
Peng.
Quoted 18 lines
Thanks,
Mathieu[1].
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
ootlin.com%2Flinux%2Fv5.8-rc4%2Fsource%2Fdrivers%2Fremoteproc%2Frem oteproc_virtio.c%23L389&data=02%7C01%7Cpeng.fan%40nxp.com%7C 760ae238005c49fe20db08d833e193ca%7C686ea1d3bc2b4c6fa92cd99c5c30 1635%7C0%7C0%7C637316391223184319&sdata=UTN8YVaEynomrwFx 7aTCJ7fp0fjfIS8fscfGG67naKk%3D&reserved=0Quoted 6 lines
drivers/remoteproc/remoteproc_virtio.c +0
-0if (mem) {
phys_addr_tpa;--
2.16.4
Mathieu Poirier
maintainerQuoted 35 lines · Peng Fan
Hi Mathieu,
Quoted 22 lines
Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer
Hi Peng,
Quoted 17 lines · Peng Fan
Support sharing vdev buffer between multiple vdevs by using name "vdevbuffer".
Reviewed-by Richard Zhu <[email protected]>Signed-off-by Peng Fan <[email protected]>--- drivers/remoteproc/remoteproc_virtio.c | 2 ++ 1 file changed, 2 insertions(+)drivers/remoteproc/remoteproc_virtio.c +0
-0@@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)Quoted 9 lines
drivers/remoteproc/remoteproc_virtio.c int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) · line 347
Quoted 5 lines
drivers/remoteproc/remoteproc_virtio.c +2
-0/* Try to find dedicated vdev buffer carveout */ mem =rproc_find_carveout_by_name (rproc,"vdev%dbuffer" , rvdev->index); +if (!mem) + mem =rproc_find_carveout_by_name (rproc,"vdevbuffer" );We already have a way to share buffers [1], do you think it would work for you? I would rather proceed that way to avoid introducing a 3rd way to deal with vdev buffers.
Quoted 2 lines
That should work for me. I just need to move the vdevbuffer to the 1st one inside the memory-region.
Perfect
Quoted 4 lines
BTW: Do you have time to give a review for
https://patchwork.kernel.org/patch/11688751/
Unfortunately not in a little while. There are a couple of beefy patchset in the queue ahead of yours and to make matters worse I am away next week.
Quoted 21 lines
Thanks,
Peng.Quoted 18 lines
Thanks,
Mathieu[1].
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
ootlin.com%2Flinux%2Fv5.8-rc4%2Fsource%2Fdrivers%2Fremoteproc%2Frem oteproc_virtio.c%23L389&data=02%7C01%7Cpeng.fan%40nxp.com%7C 760ae238005c49fe20db08d833e193ca%7C686ea1d3bc2b4c6fa92cd99c5c30 1635%7C0%7C0%7C637316391223184319&sdata=UTN8YVaEynomrwFx 7aTCJ7fp0fjfIS8fscfGG67naKk%3D&reserved=0Quoted 6 lines
drivers/remoteproc/remoteproc_virtio.c +0
-0if (mem) {phys_addr_t pa;--
2.16.4