LVM: Drop legacy scripts and runtest files
RFC PATCH 1/1 LVM: Drop legacy scripts and runtest files
These scripts were unmaintained and there is replacement added in 45289e498 ("Add LVM support scripts").
lvm.part{1,2} are in replaced by lvm.local generated before running, thus fix better to particular SUT.
ltpfslvm.sh / ltpfsnolvm.sh are replaced by lvmtest.sh.
We lose testing of legacy filesystems: MS-DOS, ReiserFS, Minix, JFS and ramdisk (not supported by new API).
---
NOTE, there was also a patch removing TST_NEEDS_ROOT=1 from generate_lvm_runfile.sh, but I dropped it (I don't like requiring root just to get /sbin:/usr/sbin in PATH, but that's a pragmatic solution).
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
Kind regards,
Petr
doc/ltp-run-files.txt | 4 +- runtest/lvm.part1 | 217 -------------------------------------- runtest/lvm.part2 | 72 ------------- testscripts/ltpfslvm.sh | 200 ----------------------------------- testscripts/ltpfsnolvm.sh | 150 -------------------------- 5 files changed, 1 insertion(+), 642 deletions(-) delete mode 100644 runtest/lvm.part1 delete mode 100644 runtest/lvm.part2 delete mode 100755 testscripts/ltpfslvm.sh delete mode 100755 testscripts/ltpfsnolvm.sh
doc/ltp-run-files.txt +1 -3
@@ -56,9 +56,7 @@ if run network tests flag is passed these additional tests are run - nfs To test filesystem with LVM -- ltpfslvm.sh -w/o LVM -- ltpfsnolvm.sh +- testscripts/lvmtest.sh Device Mapper tests - ltpdmmapper.sh
runtest/lvm.part1 deleted +0 -217
217 lines not on this page · raw message
runtest/lvm.part2 deleted +0 -72
72 lines not on this page · raw message
testscripts/ltpfslvm.sh deleted +0 -200
200 lines not on this page · raw message
testscripts/ltpfsnolvm.sh deleted +0 -150
150 lines not on this page · raw message
Signature · 1 line
2.27.0
RFC PATCH 1/1 LVM: Drop legacy scripts and runtest files
Hi!
Looks good to me, acked.
I would wait a bit more to see if anyone complains about the removal though.
Signature · 2 lines
Cyril Hrubis [email protected]
RFC PATCH 1/1 LVM: Drop legacy scripts and runtest files
Hi Cyril,
Quoted 2 lines
Hi!
Looks good to me, acked.
Thanks for your review.
Quoted 2 lines
I would wait a bit more to see if anyone complains about the removal though.
Originally posted at the end of May (i.e. more than 1 half month in ML), but it does not harm to wait a bit longer before dropping them.
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
Kind regards,
Petr
RFC PATCH 1/1 LVM: Drop legacy scripts and runtest files
In reply to Cyril HrubisQuoted 6 lines · Cyril Hrubis
Hi!
Looks good to me, acked.I would wait a bit more to see if anyone complains about the removal though.
No objections from me. ACK.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20200721/431545b4/attachment.htm>
RFC PATCH 1/1 LVM: Drop legacy scripts and runtest files
Hi Li, Cyril,
Quoted 9 lines · Cyril Hrubis
Quoted 6 lines
Hi!
Looks good to me, acked.I would wait a bit more to see if anyone complains about the removal though.
No objections from me. ACK.
Thanks! Merged.
Kind regards,
Petr