Skip to contentSkip to conversation

dom0pvh: assign 1GB of memory to PVH dom0

PATCH In review Roger Pau Monne 2 participants 3 messages Jul 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dom0pvh: assign 1GB of memory to PVH dom0

Current tests use 512MB of memory for dom0, but that's too low for a PVH dom0 on some hosts and will cause errors because memory is ballooned out in order to obtain physical memory ranges to map foreign pages.

Using ballooned out pages for foreign mappings also doesn't seem to work properly with the current Linux kernel version, so increase the memory assigned to dom0 to 1GB for PVH dom0 tests. We should see about reverting this when using ballooned pages is fixed.

The runvar diff is:

+test-amd64-amd64-dom0pvh-xl-amd dom0_mem 1024
+test-amd64-amd64-dom0pvh-xl-intel dom0_mem 1024

I've done a repro of the failed test on elbling0 with dom0_mem set to 1GB and it seems to prevent the issue, the flight is 152111.

---
 make-flight | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
make-flight +1 -1
index b8942c1c..85559c68 100755
@@ -903,7 +903,7 @@ test_matrix_do_one () {
       job_create_test test-$xenarch$kern-$dom0arch-dom0pvh-xl-$cpuvendor \
                 test-debian xl $xenarch $dom0arch $debian_runvars \
                 all_hostflags=$most_hostflags,hvm-$cpuvendor,iommu \
-                xen_boot_append='dom0=pvh,verbose'
+                xen_boot_append='dom0=pvh,verbose' dom0_mem=1024
 
     done
 
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw

Roger Pau Monne writes ("[osstest PATCH] dom0pvh: assign 1GB of memory to PVH dom0"):

Quoted 15 lines

Current tests use 512MB of memory for dom0, but that's too low for a PVH dom0 on some hosts and will cause errors because memory is ballooned out in order to obtain physical memory ranges to map foreign pages.

Using ballooned out pages for foreign mappings also doesn't seem to work properly with the current Linux kernel version, so increase the memory assigned to dom0 to 1GB for PVH dom0 tests. We should see about reverting this when using ballooned pages is fixed.

The runvar diff is:

(quoted diff) +2 -0
+test-amd64-amd64-dom0pvh-xl-amd   dom0_mem 1024
+test-amd64-amd64-dom0pvh-xl-intel dom0_mem 1024
Quoted 4 lines

I've done a repro of the failed test on elbling0 with dom0_mem set to 1GB and it seems to prevent the issue, the flight is 152111.

And queued.

Ian.

#2 lore raw
Quoted 16 lines · Ian Jackson

Roger Pau Monne writes ("[osstest PATCH] dom0pvh: assign 1GB of memory to PVH dom0"):

Quoted 15 lines

Current tests use 512MB of memory for dom0, but that's too low for a PVH dom0 on some hosts and will cause errors because memory is ballooned out in order to obtain physical memory ranges to map foreign pages.

Using ballooned out pages for foreign mappings also doesn't seem to work properly with the current Linux kernel version, so increase the memory assigned to dom0 to 1GB for PVH dom0 tests. We should see about reverting this when using ballooned pages is fixed.

The runvar diff is:

(quoted diff) +2 -0
+test-amd64-amd64-dom0pvh-xl-amd   dom0_mem 1024
+test-amd64-amd64-dom0pvh-xl-intel dom0_mem 1024
Quoted 8 lines
Quoted 4 lines

I've done a repro of the failed test on elbling0 with dom0_mem set to 1GB and it seems to prevent the issue, the flight is 152111.

And queued.

Thanks! Forgot to add that I've checked x86 hosts and they all have at least 8GB of RAM, so using 1GB for dom0 should be fine, as I don't think osstest runs guests close to 7GB of RAM.

Roger.