Skip to contentSkip to conversation

ls1028a: fix EFI boot

PATCH New Mian Yousaf Kaukab 3 participants 5 messages Jul 21, 2020 – Jul 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ls1028a: fix EFI boot

scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn?t work. Fix this issue by adding scan_dev_for_efi call.

---
 include/configs/ls1028aqds.h | 1 +
 include/configs/ls1028ardb.h | 1 +
 2 files changed, 2 insertions(+)
include/configs/ls1028aqds.h +1 -0
index 7bb740f48e36..3d622002ebca 100644
@@ -135,6 +135,7 @@
 		"for prefix in ${boot_prefixes}; do " \
 			"run scan_dev_for_scripts; " \
 		"done;" \
+		SCAN_DEV_FOR_EFI \
 		"\0" \
 	"boot_a_script=" \
 		"load ${devtype} ${devnum}:${distro_bootpart} " \
include/configs/ls1028ardb.h +1 -0
index 07450113269c..0064c1dcc01a 100644
@@ -118,6 +118,7 @@
 		"for prefix in ${boot_prefixes}; do "	  \
 			"run scan_dev_for_scripts; "	  \
 		"done;"					  \
+		SCAN_DEV_FOR_EFI			  \
 		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 ls1028a: fix EFI boot

Hello Yousaf

Quoted 10 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Mian Yousaf Kaukab
Sent: Tuesday, July 21, 2020 8:04 PM
To: u-boot at lists.denx.de; Rajesh Bhagat <[email protected]>; harninder.rai at nxp.com; sudhanshu.gupta at nxp.com
Cc: prabhakar.kushwaha at nxp.com; Andy Tang <[email protected]>; Priyanka Jain <[email protected]>; Mian Yousaf Kaukab <[email protected]>
Subject: [PATCH] ls1028a: fix EFI boot

Quoted 4 lines

scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn?t work. Fix this issue by adding scan_dev_for_efi call.

Acked.

Andy, can you please also take a look.

Thanks .

Regards
Poonam

Quoted 32 lines
---
 include/configs/ls1028aqds.h | 1 +
 include/configs/ls1028ardb.h | 1 +
 2 files changed, 2 insertions(+)
include/configs/ls1028aqds.h index renamed from include/configs/ls1028aqds.h +0 -0

7bb740f48e36..3d622002ebca 100644

include/configs/ls1028aqds.h +1 -0
@@ -135,6 +135,7 @@
 		"for prefix in ${boot_prefixes}; do " \
 			"run scan_dev_for_scripts; " \
 		"done;" \
+		SCAN_DEV_FOR_EFI \
 		"\0" \
 	"boot_a_script=" \
 		"load ${devtype} ${devnum}:${distro_bootpart} " \ diff --git

a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 07450113269c..0064c1dcc01a 100644

include/configs/ls1028ardb.h +1 -1
@@ -118,6 +118,7 @@
 		"for prefix in ${boot_prefixes}; do "	  \
 			"run scan_dev_for_scripts; "	  \
 		"done;"					  \
+		SCAN_DEV_FOR_EFI			  \
 		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
--

2.26.2

#2 lore raw

PATCH 1/1 ls1028a: fix EFI boot

Hi Yousaf,

Could you please try removing entire environment variable "scan_dev_for_boot" in the ls1028aqds/rdb header file? In this way, the default value for scan_dev_for_boot could be used and meet your requirement.

BR,
Andy

Quoted 71 lines

-----Original Message-----
From: Poonam Aggrwal <[email protected]>
Sent: 2020?7?22? 18:01
To: Mian Yousaf Kaukab <[email protected]>; u-boot at lists.denx.de; Rajesh Bhagat <[email protected]>; harninder.rai at nxp.com; sudhanshu.gupta at nxp.com
Cc: prabhakar.kushwaha at nxp.com; Andy Tang <[email protected]>; Priyanka Jain <[email protected]>
Subject: RE: [PATCH] ls1028a: fix EFI boot

Hello Yousaf

Quoted 11 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Mian Yousaf Kaukab
Sent: Tuesday, July 21, 2020 8:04 PM
To: u-boot at lists.denx.de; Rajesh Bhagat <[email protected]>; harninder.rai at nxp.com; sudhanshu.gupta at nxp.com
Cc: prabhakar.kushwaha at nxp.com; Andy Tang <[email protected]>; Priyanka Jain <[email protected]>; Mian Yousaf Kaukab <[email protected]>
Subject: [PATCH] ls1028a: fix EFI boot

Quoted 3 lines

scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn?t work. Fix this issue by adding scan_dev_for_efi

call.

Quoted 1 line

Acked.

Andy, can you please also take a look.

Thanks .

Regards
Poonam

Quoted 8 lines
---
 include/configs/ls1028aqds.h | 1 +
 include/configs/ls1028ardb.h | 1 +
 2 files changed, 2 insertions(+)
(quoted diff) +0 -0

b/include/configs/ls1028aqds.h index 7bb740f48e36..3d622002ebca

100644

Quoted 24 lines
include/configs/ls1028aqds.h +1 -0
@@ -135,6 +135,7 @@
 		"for prefix in ${boot_prefixes}; do " \
 			"run scan_dev_for_scripts; " \
 		"done;" \
+		SCAN_DEV_FOR_EFI \
 		"\0" \
 	"boot_a_script=" \
 		"load ${devtype} ${devnum}:${distro_bootpart} " \ diff --git

a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 07450113269c..0064c1dcc01a 100644

include/configs/ls1028ardb.h +1 -1
@@ -118,6 +118,7 @@
 		"for prefix in ${boot_prefixes}; do "	  \
 			"run scan_dev_for_scripts; "	  \
 		"done;"					  \
+		SCAN_DEV_FOR_EFI			  \
 		"\0"					  \
 	"boot_a_script="				  \
 		"load ${devtype} ${devnum}:${distro_bootpart} "  \
--

2.26.2

#3 lore raw

PATCH 1/1 ls1028a: fix EFI boot

Quoted 1 line · Andy Tang

Hi Yousaf,

Hi Andy,

Quoted 3 lines

Could you please try removing entire environment variable "scan_dev_for_boot" in the ls1028aqds/rdb header file? In this way, the default value for scan_dev_for_boot could be used and meet your requirement.

Its actually better to remove the custom definition of scan_dev_for_boot. However, the default definition will additionally call ?run scan_dev_for_extlinux?. I can send a new patch if that's not an issue.

Quoted 3 lines

BR,
Andy

BR,
Yousaf

#4 lore raw
Quoted 18 lines

-----Original Message-----
From: Mian Yousaf Kaukab <[email protected]>
Sent: 2020?7?23? 17:31
To: Andy Tang <[email protected]>
Cc: Poonam Aggrwal <[email protected]>; u-boot at lists.denx.de; Rajesh Bhagat <[email protected]>; harninder.rai at nxp.com; sudhanshu.gupta at nxp.com; prabhakar.kushwaha at nxp.com; Priyanka Jain <[email protected]>
Subject: [EXT] Re: [PATCH] ls1028a: fix EFI boot

Caution: EXT Email

Quoted 1 line · Andy Tang

Hi Yousaf,

Hi Andy,

Quoted 1 line
Quoted 8 lines
Quoted 1 line

Could you please try removing entire environment variable

"scan_dev_for_boot" in the ls1028aqds/rdb header file?

Quoted 1 line

In this way, the default value for scan_dev_for_boot could be used and meet

your requirement.
Its actually better to remove the custom definition of scan_dev_for_boot. However, the default definition will additionally call ?run scan_dev_for_extlinux?.
I can send a new patch if that's not an issue.

Go ahead, that should not be an issue.

BR,
Andy

Quoted 5 lines
Quoted 3 lines

BR,
Andy

BR,
Yousaf