ls1028a: use default scan_dev_for_boot
PATCH v2 1/1 ls1028a: use default scan_dev_for_boot
scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn?t work. Fix this issue by removing custom definition of scan_dev_for_boot and use the default definition instead.
---
Change-log:
v2: -Rename. was: ls1028a: fix EFI boot
https://patchwork.ozlabs.org/project/uboot/patch/20200721143354.14382-1-ykaukab at suse.de/
-Remove custom definition of scan_dev_for_boot
include/configs/ls1028aqds.h | 7 ------- include/configs/ls1028ardb.h | 7 ------- 2 files changed, 14 deletions(-)
include/configs/ls1028aqds.h +0 -7
@@ -129,13 +129,6 @@"run scan_dev_for_boot; " \"fi; " \"done\0" \ -"scan_dev_for_boot=" \ -"echo Scanning ${devtype} " \ -"${devnum}:${distro_bootpart}...; " \ -"for prefix in ${boot_prefixes}; do " \ -"run scan_dev_for_scripts; " \ -"done;" \ -"\0" \"boot_a_script=" \"load ${devtype} ${devnum}:${distro_bootpart} " \"${scriptaddr} ${prefix}${script}; " \
include/configs/ls1028ardb.h +0 -7
@@ -112,13 +112,6 @@"run scan_dev_for_boot; " \"fi; " \"done\0" \ -"scan_dev_for_boot=" \ -"echo Scanning ${devtype} " \ -"${devnum}:${distro_bootpart}...; " \ -"for prefix in ${boot_prefixes}; do " \ -"run scan_dev_for_scripts; " \ -"done;" \ -"\0" \"boot_a_script=" \"load ${devtype} ${devnum}:${distro_bootpart} " \"${scriptaddr} ${prefix}${script}; " \
Signature · 1 line
2.26.2
PATCH v2 1/1 ls1028a: use default scan_dev_for_boot
Quoted 73 lines
-----Original Message-----
From: Mian Yousaf Kaukab <[email protected]>
Sent: 2020?7?23? 21:41
To: u-boot at lists.denx.de; Andy Tang <[email protected]>
Cc: Priyanka Jain <[email protected]>; Rajesh Bhagat <[email protected]>; harninder.rai at nxp.com; sudhanshu.gupta at nxp.com; Poonam Aggrwal <[email protected]>; Mian Yousaf Kaukab <[email protected]>
Subject: [EXT] [PATCH v2] ls1028a: use defaultscan_dev_for_bootCaution: EXT Email
scan_dev_for_efiis supposed to be called fromscan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn?t work. Fix this issue by removing custom definition ofscan_dev_for_bootand use the default definition instead.Signed-off-by Mian Yousaf Kaukab <[email protected]>---
Change-log:
v2: -Rename. was: ls1028a: fix EFI boothttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
work.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20200721143354.14382-1 -ykaukab%40suse.de%2F&data=02%7C01%7Candy.tang%40nxp.com%7 C729286cd9264486fe7e208d82f0e3e21%7C686ea1d3bc2b4c6fa92cd99c5c3 01635%7C0%7C1%7C637311085499253728&sdata=iS6R4NdV3LhAXttKf lgl29Su8TJqfFoBzTCnUl4mAQM%3D&reserved=0
-Remove custom definition ofscan_dev_for_bootinclude/configs/ls1028aqds.h | 7 ------- include/configs/ls1028ardb.h | 7 ------- 2 files changed, 14 deletions(-)include/configs/ls1028aqds.h index renamed from include/configs/ls1028aqds.h +0
-0
7bb740f48e36..8ab943cc640a100644include/configs/ls1028aqds.h +0
-7@@ -129,13 +129,6 @@"run scan_dev_for_boot; " \"fi; " \"done\0" \ -"scan_dev_for_boot=" \ -"echo Scanning ${devtype} " \ -"${devnum}:${distro_bootpart}...; " \ -"for prefix in ${boot_prefixes}; do " \ -"run scan_dev_for_scripts; " \ -"done;" \ -"\0" \"boot_a_script=" \"load ${devtype} ${devnum}:${distro_bootpart} " \ "${scriptaddr} ${prefix}${script}; " \ diff --git
a/include/configs/ls1028ardb.hb/include/configs/ls1028ardb.hindex07450113269c..3c9358ca4b7a100644include/configs/ls1028ardb.h +0
-7@@ -112,13 +112,6 @@"run scan_dev_for_boot; " \"fi; " \"done\0" \ -"scan_dev_for_boot=" \ -"echo Scanning ${devtype} " \ -"${devnum}:${distro_bootpart}...; " \ -"for prefix in ${boot_prefixes}; do " \ -"run scan_dev_for_scripts; " \ -"done;" \ -"\0" \"boot_a_script=" \"load ${devtype} ${devnum}:${distro_bootpart} " \"${scriptaddr} ${prefix}${script}; " \
Quoted 2 lines
--
2.26.2
PATCH v2 1/1 ls1028a: use default scan_dev_for_boot
Quoted 69 lines · Andy Tang
Quoted 69 lines
-----Original Message-----
From: Mian Yousaf Kaukab <[email protected]>
Sent: 2020?7?23? 21:41
To: u-boot at lists.denx.de; Andy Tang <[email protected]>
Cc: Priyanka Jain <[email protected]>; Rajesh Bhagat <[email protected]>; harninder.rai at nxp.com; sudhanshu.gupta at nxp.com; Poonam Aggrwal <[email protected]>; Mian Yousaf Kaukab <[email protected]>
Subject: [EXT] [PATCH v2] ls1028a: use defaultscan_dev_for_bootCaution: EXT Email
scan_dev_for_efiis supposed to be called fromscan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn?t work. Fix this issue by removing custom definition ofscan_dev_for_bootand use the default definition instead.Signed-off-by Mian Yousaf Kaukab <[email protected]>---
Change-log:
v2: -Rename. was: ls1028a: fix EFI boothttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
work.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20200721143354.14382-1 -ykaukab%40suse.de%2F&data=02%7C01%7Candy.tang%40nxp.com%7 C729286cd9264486fe7e208d82f0e3e21%7C686ea1d3bc2b4c6fa92cd99c5c3 01635%7C0%7C1%7C637311085499253728&sdata=iS6R4NdV3LhAXttKf lgl29Su8TJqfFoBzTCnUl4mAQM%3D&reserved=0
-Remove custom definition ofscan_dev_for_bootinclude/configs/ls1028aqds.h | 7 ------- include/configs/ls1028ardb.h | 7 ------- 2 files changed, 14 deletions(-)include/configs/ls1028aqds.h index renamed from include/configs/ls1028aqds.h +0
-0
7bb740f48e36..8ab943cc640a100644include/configs/ls1028aqds.h +0
-7@@ -129,13 +129,6 @@"run scan_dev_for_boot; " \"fi; " \"done\0" \ -"scan_dev_for_boot=" \ -"echo Scanning ${devtype} " \ -"${devnum}:${distro_bootpart}...; " \ -"for prefix in ${boot_prefixes}; do " \ -"run scan_dev_for_scripts; " \ -"done;" \ -"\0" \"boot_a_script=" \"load ${devtype} ${devnum}:${distro_bootpart} " \ "${scriptaddr} ${prefix}${script}; " \ diff --git
a/include/configs/ls1028ardb.hb/include/configs/ls1028ardb.hindex07450113269c..3c9358ca4b7a100644include/configs/ls1028ardb.h +0
-6@@ -112,13 +112,6 @@"run scan_dev_for_boot; " \"fi; " \"done\0" \ -"scan_dev_for_boot=" \ -"echo Scanning ${devtype} " \ -"${devnum}:${distro_bootpart}...; " \ -"for prefix in ${boot_prefixes}; do " \ -"run scan_dev_for_scripts; " \ -"done;" \
Quoted 9 lines
Quoted 6 lines
include/configs/ls1028ardb.h +0
-1-"\0" \"boot_a_script=" \"load ${devtype} ${devnum}:${distro_bootpart} " \"${scriptaddr} ${prefix}${script}; " \--
2.26.2Reviewed-by andy.tang at nxp.com
Andy, Are you maintaining nxp tree through which you can queue this patch? Or should I ask Tom to cherry-pick it?
BR,
Yousaf