Skip to contentSkip to conversation

net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER

PATCH In review [email protected] 2 participants 2 messages Jul 23, 2020 – Jul 25, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER

From: Tom Rix <[email protected]>

A link error

ld: drivers/net/usb/cdc_ncm.o:
undefined reference to `usbnet_cdc_update_filter'

usbnet_cdc_update_filter is defined in cdc_ether.c Building of cdc_ether.o is controlled by USB_NET_CDCETHER

Building of cdc_ncm.o is controlled by USB_NET_CDC_NCM

So add a select USB_NET_CDCETHER to USB_NET_CDC_NCM

---
 drivers/net/usb/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/usb/Kconfig +1 -0
index a7fbc3ccd29e..c7bcfca7d70b 100644
@@ -252,6 +252,7 @@ config USB_NET_CDC_EEM
 config USB_NET_CDC_NCM
 	tristate "CDC NCM support"
 	depends on USB_USBNET
+	select USB_NET_CDCETHER
 	default y
 	help
 	  This driver provides support for CDC NCM (Network Control Model
Signature · 1 line
2.18.1
maintainer
#1 lore raw

From: [email protected]
Date: Thu, 23 Jul 2020 07:22:10 -0700

Quoted 7 lines

From: Tom Rix <[email protected]>

A link error

ld: drivers/net/usb/cdc_ncm.o:
undefined reference to `usbnet_cdc_update_filter'

Quoted 8 lines

usbnet_cdc_update_filter is defined in cdc_ether.c Building of cdc_ether.o is controlled by USB_NET_CDCETHER

Building of cdc_ncm.o is controlled by USB_NET_CDC_NCM

So add a select USB_NET_CDCETHER to USB_NET_CDC_NCM

Please indicate the appropriate target tree ('net' or 'net-next') in your Subject line f.e. "[PATCH net-next] ..."

Please provide an appropriate and properly formatted Fixes: tag.

Thank you.