Skip to contentSkip to conversation

Deprecate --inetd

PATCH In review Arne Schwabe 2 participants 2 messages Jul 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Deprecate --inetd

This is a corner case of a corner case option. It only works with tcp, tap and needs special configuration.

---
 src/openvpn/options.c | 2 ++
 1 file changed, 2 insertions(+)
src/openvpn/options.c +2 -0
index aa7f57b5..5beaba0f 100644
@@ -5871,6 +5871,8 @@ add_option(struct options *options,
     }
     else if (streq(p[0], "inetd") && !p[3])
     {
+        msg(M_WARN, "DEPRECATED OPTION: --inetd mode is deprecated "
+                    "and will be removed in OpenVPN 2.6");
         VERIFY_PERMISSION(OPT_P_GENERAL);
         if (!options->inetd)
         {
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw

I think I am the only one currently using --inetd, and I only use it on my test server rig because I was curious on whether it still works. It does (after some code fixes, back then), but it is very limited in what it can do, and complicates the socket.c code quite a bit. Out with it!

Added Changes.rst entry.

Your patch has been applied to the master branch.

commit 25a422cc60c609cc6927a3fb26bf1fb506dda828

Author: Arne Schwabe
Date:   Thu Jul 23 17:59:37 2020 +0200
     Deprecate --inetd

     Signed-off-by: Arne Schwabe <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg20554.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering