Skip to contentSkip to conversation

package/setools: remove C++ dependency on comment

PATCH New Antoine Tenart 2 participants 3 messages Jul 22, 2020 – Jul 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/setools: remove C++ dependency on comment

Bump to 4.1.1 (commit 96d3d017963b) removed setools' dependency on BR2_INSTALL_LIBSTDCPP, but the corresponding inverse dependency on one of its Kconfig comment was not removed. This led to have the package being available while a Kconfig comment on non-matched dependencies is shown. Fix this by removing the dependency on !BR2_INSTALL_LIBSTDCPP on the Kconfig comment.

---
 package/setools/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/setools/Config.in +2 -2
index 9475bbef65f3..46b3d4525bc5 100644
@@ -19,10 +19,10 @@ config BR2_PACKAGE_SETOOLS
 
 	  https://github.com/TresysTechnology/setools
 
-comment "setools needs a toolchain w/ threads, C++, wchar, dynamic library"
+comment "setools needs a toolchain w/ threads, wchar, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
-		!BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
+		!BR2_USE_WCHAR
 
 comment "setools needs python3"
 	depends on BR2_USE_MMU
Signature · 1 line
2.26.2
#1 lore raw

PATCH 2/2 package/setools: update the project location in the Kconfig help

setools is no longer hosted on https://github.com/TresysTechnology/setools/.
Updated the Kconfig help to point to its new home,
https://github.com/SELinuxProject/setools/.

---
 package/setools/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/setools/Config.in +1 -1
index 46b3d4525bc5..3ab7f559489b 100644
@@ -17,7 +17,7 @@ config BR2_PACKAGE_SETOOLS
 	   * seinfoflow - information flow analysis for SELinux
 	   * sesearch - Search rules (allow, type_transition, etc.)
 
-	  https://github.com/TresysTechnology/setools
+	  https://github.com/SELinuxProject/setools/
 
 comment "setools needs a toolchain w/ threads, wchar, dynamic library"
 	depends on BR2_USE_MMU
Signature · 1 line
2.26.2
#2 lore raw

PATCH 1/2 package/setools: remove C++ dependency on comment

In reply to Antoine Tenart
Quoted 11 lines · On Wed, 22 Jul 2020 09:44:29 +0200 Antoine Tenart <[email protected]>…

Bump to 4.1.1 (commit 96d3d017963b) removed setools' dependency on BR2_INSTALL_LIBSTDCPP, but the corresponding inverse dependency on one of its Kconfig comment was not removed. This led to have the package being available while a Kconfig comment on non-matched dependencies is shown. Fix this by removing the dependency on !BR2_INSTALL_LIBSTDCPP on the Kconfig comment.

---
 package/setools/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Both applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com