Skip to contentSkip to conversation

Fix TI K3 cbass interconnect node names

PATCH In review Suman Anna 3 participants 6 messages Jul 23, 2020 – Aug 26, 2020

Subsystems (2)
lore
Share & tools
lore

Suman Anna

author
#0 lore raw

cover Fix TI K3 cbass interconnect node names

Hi Tero, Nishanth,

Following are couple of minor fixes that fix the node names for the interconnect bus nodes on K3 AM65x and J721E SoCs. These fix the following warnings seen with dtbs_check on the K3 dtbs.

'interconnect@100000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' 'interconnect@28380000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'

Lokesh has already used the correct name in his initial submission for J7200 SoCs.

regards
Suman

Suman Anna (2):
arm64: dts: ti: k3-am65: Fix interconnect node names
arm64: dts: ti: k3-j721e: Fix interconnect node names

 arch/arm64/boot/dts/ti/k3-am65.dtsi  | 6 +++---
 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.26.0
author
#1 lore raw

PATCH 1/2 arm64: dts: ti: k3-am65: Fix interconnect node names

The various CBASS interconnect nodes on K3 AM65x SoCs are defined using the node name "interconnect". This is not a valid node name as per the dt-schema. Fix these node names to use the standard name used for SoC interconnects, "bus".

---
 arch/arm64/boot/dts/ti/k3-am65.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65.dtsi +3 -3
index 5be75e430965..94ab5bd744cf 100644
@@ -61,7 +61,7 @@ pmu: pmu {
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
-	cbass_main: interconnect@100000 {
+	cbass_main: bus@100000 {
 		compatible = "simple-bus";
 		#address-cells = <2>;
 		#size-cells = <2>;
@@ -88,7 +88,7 @@ cbass_main: interconnect@100000 {
 			 <0x05 0x00000000 0x05 0x00000000 0x01 0x0000000>,
 			 <0x07 0x00000000 0x07 0x00000000 0x01 0x0000000>;
 
-		cbass_mcu: interconnect@28380000 {
+		cbass_mcu: bus@28380000 {
 			compatible = "simple-bus";
 			#address-cells = <2>;
 			#size-cells = <2>;
@@ -106,7 +106,7 @@ cbass_mcu: interconnect@28380000 {
 				 <0x05 0x00000000 0x05 0x00000000 0x01 0x0000000>, /* FSS OSPI0 data region 3*/
 				 <0x07 0x00000000 0x07 0x00000000 0x01 0x0000000>; /* FSS OSPI1 data region 3*/
 
-			cbass_wakeup: interconnect@42040000 {
+			cbass_wakeup: bus@42040000 {
 				compatible = "simple-bus";
 				#address-cells = <1>;
 				#size-cells = <1>;
Signature · 1 line
2.26.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] arm64: dts: ti: k3-am65: Fix interconnect node names

Quoted 6 lines · Suman Anna

The various CBASS interconnect nodes on K3 AM65x SoCs are defined using the node name "interconnect". This is not a valid node name as per the dt-schema. Fix these node names to use the standard name used for SoC interconnects, "bus".

Thanks and regards,
Lokesh

author
#3 lore raw

PATCH 2/2 arm64: dts: ti: k3-j721e: Fix interconnect node names

In reply to Suman Anna

The various CBASS interconnect nodes on K3 J721E SoCs are defined using the node name "interconnect". This is not a valid node name as per the dt-schema. Fix these node names to use the standard name used for SoC interconnects, "bus".

---
 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j721e.dtsi +2 -2
index 2f9a56d9b114..3565885142e7 100644
@@ -120,7 +120,7 @@ pmu: pmu {
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
-	cbass_main: interconnect@100000 {
+	cbass_main: bus@100000 {
 		compatible = "simple-bus";
 		#address-cells = <2>;
 		#size-cells = <2>;
@@ -155,7 +155,7 @@ cbass_main: interconnect@100000 {
 			 <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>,
 			 <0x07 0x00000000 0x07 0x00000000 0x01 0x00000000>;
 
-		cbass_mcu_wakeup: interconnect@28380000 {
+		cbass_mcu_wakeup: bus@28380000 {
 			compatible = "simple-bus";
 			#address-cells = <2>;
 			#size-cells = <2>;
Signature · 1 line
2.26.0
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] arm64: dts: ti: k3-j721e: Fix interconnect node names

Quoted 6 lines · Suman Anna

The various CBASS interconnect nodes on K3 J721E SoCs are defined using the node name "interconnect". This is not a valid node name as per the dt-schema. Fix these node names to use the standard name used for SoC interconnects, "bus".

Thanks and regards,
Lokesh

maintainer
#5 lore raw
In reply to Suman Anna
Quoted 11 lines · Suman Anna

Hi Tero, Nishanth,

Following are couple of minor fixes that fix the node names for the interconnect bus nodes on K3 AM65x and J721E SoCs. These fix the following warnings seen with dtbs_check on the K3 dtbs.

'interconnect@100000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' 'interconnect@28380000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'

Lokesh has already used the correct name in his initial submission for J7200 SoCs.

Thank you. I have staged in the staging branch, once rc3 is available, I will apply it there and you should be able to see this in -next tree.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D