Skip to contentSkip to conversation

ram: rockchip: Disable debug output of RAM init by default

PATCH New Michael Walle 2 participants 3 messages Jul 23, 2020 – Aug 10, 2020 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ram: rockchip: Disable debug output of RAM init by default

Like the name says, it is debug output and should not be enabled by default as it just clutters the console. I know this basically reverts commit fba7bd4c34c5 ("ram: rockchip: Default enable DRAM debug info"). But if there is so important information printed on the console as indicated in the commit description (which I didn't saw for the LPDDR4 initialization), it shouldn't be debug in the first place.

---
 drivers/ram/rockchip/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/ram/rockchip/Kconfig +0 -1
index 8e97c2f49e..43a125e273 100644
@@ -14,7 +14,6 @@ config ROCKCHIP_SDRAM_COMMON
 config RAM_ROCKCHIP_DEBUG
 	bool "Rockchip ram drivers debugging"
 	depends on RAM_ROCKCHIP
-	default y
 	help
 	  This enables debugging ram driver API's for the platforms
 	  based on Rockchip SoCs.
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 ram: rockchip: Disable debug output of RAM init by default

Hi Michael,

??? I think there do have some information are really help people
identify what's happen for TPL fail,

that's why rockchip's dram binary always keep some DRAM info print for all the boards.

??? I would like to keep it as is for now, before we are can split the
'debug' and 'info' msg.

Thanks,

- Kever

? 2020/7/24 ??5:35, Michael Walle ??:

Quoted 24 lines

Like the name says, it is debug output and should not be enabled by default as it just clutters the console. I know this basically reverts commit fba7bd4c34c5 ("ram: rockchip: Default enable DRAM debug info"). But if there is so important information printed on the console as indicated in the commit description (which I didn't saw for the LPDDR4 initialization), it shouldn't be debug in the first place.

---
  drivers/ram/rockchip/Kconfig | 1 -
  1 file changed, 1 deletion(-)
drivers/ram/rockchip/Kconfig +0 -1
index 8e97c2f49e..43a125e273 100644
@@ -14,7 +14,6 @@ config ROCKCHIP_SDRAM_COMMON
  config RAM_ROCKCHIP_DEBUG
  	bool "Rockchip ram drivers debugging"
  	depends on RAM_ROCKCHIP
-	default y
  	help
  	  This enables debugging ram driver API's for the platforms
  	  based on Rockchip SoCs.
#2 lore raw

PATCH 1/1 ram: rockchip: Disable debug output of RAM init by default

Hi Kever,

Am 2020-08-08 11:40, schrieb Kever Yang:

Quoted 10 lines

Hi Michael,

??? I think there do have some information are really help people identify what's happen for TPL fail,

that's why rockchip's dram binary always keep some DRAM info print for all the boards.

??? I would like to keep it as is for now, before we are can split the 'debug' and 'info' msg.

So shouldn't we work on splitting the messages into debug() and info() then?

Like I said, it really clutters the console in the normal case (for DDR4 at least, I don't know about DDR3)and IMHO you don't want that many debug
information _by default_.

-michael