usbip: tools: fix build error for multiple definition
Subsystems (2)
PATCH 1/1 usbip: tools: fix build error for multiple definition
With GCC 10, building usbip triggers error for multiple definition of 'udev_context', in:
- libsrc/vhci_driver.c:18 and
- libsrc/usbip_host_common.c:27.
Declare as extern the definition in libsrc/usbip_host_common.c.
--- tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/usb/usbip/libsrc/usbip_host_common.c +1 -1
@@ -23,7 +23,7 @@#include "list.h" #include "sysfs_utils.h" -struct udev *udev_context; +extern struct udev *udev_context;static int32_t read_attr_usbip_status (struct usbip_usb_device *udev) {
Signature · 1 line
2.27.0
Quoted 18 lines · Antonio Borneo
With GCC 10, building usbip triggers error for multiple definition of '
udev_context', in:
-libsrc/vhci_driver.c:18and
-libsrc/usbip_host_common.c:27.Declare as extern the definition in
libsrc/usbip_host_common.c.Signed-off-by Antonio Borneo <[email protected]>--- tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/usb/usbip/libsrc/usbip_host_common.c +0
-0
tools/usb/usbip/libsrc/usbip_host_common.c line 29
Quoted 8 lines
tools/usb/usbip/libsrc/usbip_host_common.c +1
-1@@ -23,7 +23,7 @@#include "list.h" #include "sysfs_utils.h" -struct udev *udev_context; +extern struct udev *udev_context;static int32_t read_attr_usbip_status (struct usbip_usb_device *udev) {
Looks good to me.
thanks,
-- Shuah
Salvatore Bonaccorso
Tested-byHi,
Quoted 28 lines · Shuah Khan
Quoted 17 lines · Antonio Borneo
With GCC 10, building usbip triggers error for multiple definition of '
udev_context', in:
-libsrc/vhci_driver.c:18and
-libsrc/usbip_host_common.c:27.Declare as extern the definition in
libsrc/usbip_host_common.c.Signed-off-by Antonio Borneo <[email protected]>--- tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/usb/usbip/libsrc/usbip_host_common.c +0
-0tools/usb/usbip/libsrc/usbip_host_common.c line 28
Quoted 7 lines
tools/usb/usbip/libsrc/usbip_host_common.c +1
-1@@ -23,7 +23,7 @@#include "list.h" #include "sysfs_utils.h" -struct udev *udev_context; +extern struct udev *udev_context;static int32_t read_attr_usbip_status (struct usbip_usb_device *udev) {Looks good to me.
Quoted 1 line
Acked-by Shuah Khan <[email protected]>
As Debian (unstable) has switched to GCC 10 by default, we are biten by this. Patch looks good to me.
Regards,
Salvatore