slimbus: ngd: simplify error handling
Subsystems (4)
PATCH 1/1 slimbus: ngd: simplify error handling
Simplify error handling; we already know mwq is NULL.
Signed-off-by Pavel Machek (CIP) <[email protected]>
drivers/slimbus/qcom-ngd-ctrl.c +2 -8
@@ -1396,17 +1396,11 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) ctrl->mwq =create_singlethread_workqueue ("ngd_master" );if (!ctrl->mwq) {dev_err (&pdev->dev,"Failed to start master worker\n" ); - ret = -ENOMEM ; - goto wq_err; +qcom_slim_ngd_qmi_svc_event_deinit (&ctrl->qmi); +return -ENOMEM ; }return 0 ; -wq_err: -qcom_slim_ngd_qmi_svc_event_deinit (&ctrl->qmi); -if (ctrl->mwq) -destroy_workqueue (ctrl->mwq); - -return ret; }static int qcom_slim_ngd_ctrl_probe (struct platform_device *pdev)
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
drivers/slimbus/qcom-ngd-ctrl.c
Quoted 5 lines · Pavel Machek
Simplify error handling; we already know mwq is NULL.
Signed-off-by Pavel Machek (CIP) <[email protected]>drivers/slimbus/qcom-ngd-ctrl.c +0
-0
I think you sent this to the wrong lists:
$ scripts/get_maintainer.pl drivers/slimbus/qcom-ngd-ctrl.c Andy Gross <[email protected]> (maintainer:ARM/QUALCOMM SUPPORT) Bjorn Andersson <[email protected]> (maintainer:ARM/QUALCOMM SUPPORT) Srinivas Kandagatla <[email protected]> (maintainer:SERIAL LOW-POWER INTER-CHIP MEDIA BUS (SLIMbus)) [email protected] (open list:ARM/QUALCOMM SUPPORT) [email protected] (moderated list:SERIAL LOW-POWER INTER-CHIP MEDIA BUS (SLIMbus)) [email protected] (open list)
Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches