Skip to contentSkip to conversation

driver core: Change delimiter in devlink device's name to "--"

PATCH In review Saravana Kannan 2 participants 3 messages Jul 24, 2020 – Jul 27, 2020 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver core: Change delimiter in devlink device's name to "--"

The devlink device name is of the form "supplier:consumer". But ":" is fairly common in device names and makes it visually hard to distinguish supplier and consumer. So, replace it with "--" to make it easier.

---
 Documentation/ABI/testing/sysfs-class-devlink | 2 +-
 drivers/base/core.c                           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-class-devlink +1 -1
index 3a24973abb83..64791b65c9a3 100644
@@ -4,7 +4,7 @@ Contact:	Saravana Kannan <[email protected]>
 Description:
 		Provide a place in sysfs for the device link objects in the
 		kernel at any given time.  The name of a device link directory,
-		denoted as ... above, is of the form <supplier>:<consumer>
+		denoted as ... above, is of the form <supplier>--<consumer>
 		where <supplier> is the supplier device name and <consumer> is
 		the consumer device name.
 
drivers/base/core.c +1 -1
index b6e8b0bb76e4..4d05868d9356 100644
@@ -623,7 +623,7 @@ struct device_link *device_link_add(struct device *consumer,
 
 	link->link_dev.class = &devlink_class;
 	device_set_pm_not_required(&link->link_dev);
-	dev_set_name(&link->link_dev, "%s:%s",
+	dev_set_name(&link->link_dev, "%s--%s",
 		     dev_name(supplier), dev_name(consumer));
 	if (device_register(&link->link_dev)) {
 		put_device(consumer);
Signature · 1 line
2.28.0.rc0.142.g3c755180ce-goog
#1 lore raw
Quoted 6 lines · Saravana Kannan

The devlink device name is of the form "supplier:consumer". But ":" is fairly common in device names and makes it visually hard to distinguish supplier and consumer. So, replace it with "--" to make it easier.

Well, this makes sense in principle, but I wonder how much risk of breaking anything in user space there is?

Quoted 34 lines
---
 Documentation/ABI/testing/sysfs-class-devlink | 2 +-
 drivers/base/core.c                           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-class-devlink +1 -1
index 3a24973abb83..64791b65c9a3 100644
@@ -4,7 +4,7 @@ Contact:        Saravana Kannan <[email protected]>
 Description:
                Provide a place in sysfs for the device link objects in the
                kernel at any given time.  The name of a device link directory,
-               denoted as ... above, is of the form <supplier>:<consumer>
+               denoted as ... above, is of the form <supplier>--<consumer>
                where <supplier> is the supplier device name and <consumer> is
                the consumer device name.
 
drivers/base/core.c +1 -2
index b6e8b0bb76e4..4d05868d9356 100644
@@ -623,7 +623,7 @@ struct device_link *device_link_add(struct device *consumer,
 
        link->link_dev.class = &devlink_class;
        device_set_pm_not_required(&link->link_dev);
-       dev_set_name(&link->link_dev, "%s:%s",
+       dev_set_name(&link->link_dev, "%s--%s",
                     dev_name(supplier), dev_name(consumer));
        if (device_register(&link->link_dev)) {
                put_device(consumer);
--

2.28.0.rc0.142.g3c755180ce-goog

#2 lore raw
Quoted 11 lines · Rafael J. Wysocki
Quoted 6 lines · Saravana Kannan

The devlink device name is of the form "supplier:consumer". But ":" is fairly common in device names and makes it visually hard to distinguish supplier and consumer. So, replace it with "--" to make it easier.

Well, this makes sense in principle, but I wonder how much risk of breaking anything in user space there is?

The original patch got in only a week or two before this patch. So I don't think there's any real risk of breaking user space here. Also, it hasn't been part of any kernel release version yet. So I think we are safe.

Also, Greg already took it.

-Saravana