Skip to contentSkip to conversation

ALSA: usb-audio: This patch for prevent auto wakeup from s3 trig by usb disconnect signal from Lenovo Thinkcentre TI024Gen3 USB-audio.

PATCH In review penghao 2 participants 4 messages Jul 25, 2020 Sound

lore
Share & tools
lore

penghao

author
#0 lore raw

PATCH 14216/14216 ALSA: usb-audio: This patch for prevent auto wakeup from s3 trig by usb disconnect signal from Lenovo Thinkcentre TI024Gen3 USB-audio.

From: "[email protected]" <[email protected]>

TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens enter sleep mode, USB-audio will disconnect from USB bus port, so disabled the /sys/bus/usb/*/power/wakeup Fixesimmediately wakup form s3 state

---
 sound/usb/card.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/usb/card.c +7 -0
index 2644a5ae2b75..969c3809e051 100644
@@ -640,6 +640,12 @@ static int usb_audio_probe(struct usb_interface *intf,
 		}
 	}
 	dev_set_drvdata(&dev->dev, chip);
+	/*
+	 * ALSA: usb-audio: Add prevent wakeup from s3 state trig by lenovo
+	 * ThinkCentre TI024Gen3 USB-audio
+	 */
+	if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012))
+		device_set_wakeup_enable(&dev->dev, 0);
 
 	/*
 	 * For devices with more than one control interface, we assume the
@@ -914,3 +920,4 @@ static struct usb_driver usb_audio_driver = {
 };
 
 module_usb_driver(usb_audio_driver);
+
Signature · 1 line
2.11.0
#1 lore raw
Quoted 6 lines · penghao

From: "[email protected]" <[email protected]>

TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens enter sleep mode, USB-audio will disconnect from USB bus port, so disabled the /sys/bus/usb/*/power/wakeup Fixesimmediately wakup form s3 state

Why the indentation?

Quoted 3 lines

We need a name, not just an email address.

And where are the 14215 other patches in this patch series?

Quoted 9 lines
---
 sound/usb/card.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/usb/card.c +0 -0
index 2644a5ae2b75..969c3809e051 100644

sound/usb/card.c static int usb_audio_probe(struct usb_interface *intf, · line 648

Quoted 9 lines
sound/usb/card.c +6 -0
@@ -640,6 +640,12 @@ static int usb_audio_probe(struct usb_interface *intf,
 		}
 	}
 	dev_set_drvdata(&dev->dev, chip);
+	/*
+	 * ALSA: usb-audio: Add prevent wakeup from s3 state trig by lenovo
+	 * ThinkCentre TI024Gen3 USB-audio
+	 */
+	if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012))
+		device_set_wakeup_enable(&dev->dev, 0);

Shouldn't there be a quirk for this type of device that can be used instead?

thanks,

greg k-h

author
#2 lore raw

Re:Re: [PATCH 14216/14216] ALSA: usb-audio: This patch for prevent autowakeup from s3 trig by usb disconnect signal from Lenovo ThinkcentreTI024Gen3 USB-audio.

Thank you for your guidance, I will improve

ç»ä¿¡è½¯ä»¶ææ¯æéå¬å¸

UnionTech Software Technology Co., Ltd. ã

å®ç½ï¼www.uniontech.comãã

座æºï¼+86-10-62669253 æ¤çµåé®ä»¶æ¶æ¯ä»ä¾é¢ææ¶ä»¶äººä½¿ç¨ï¼å¶ä¸å¯è½åå«ä¿å¯æç¹æä½¿ç¨ä¿¡æ¯ãå¦ææ¨ ä¸æ¯é¢ææ¶ä»¶äººï¼è¯·å¿ä½¿ç¨ãä¼ æãååæå¤å¶æ¤çµåé®ä»¶æä¿¡èµæ¤é®ä»¶éåä»»ä½è ¡å¨ã妿æ¨è¯¯æ¶äºæ¤é®ä»¶ï¼è¯·ç«å³åå¤é®ä»¶éç¥ç»ä¿¡è½¯ä»¶ææ¯æéå¬å¸åä»¶äººï ¼å¹¶å é¤è¯¯æ¶çµåé®ä»¶åå¶ç¸å³éä»¶ãæè°¢éåï¼
This email message is intended only for the use of the individual or entity who/which is the intended recipient and may contain information that is privileged or confidential. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of, or taking any action in reliance on, this e-mail is strictly prohibited. If you have received this email in error, please notify UnionTech Software Technology immediately by replying to this e-mail and immediately delete and discard all copies of the e-mail and the attachment thereto (if any). Thank you.

From: "Greg KH <[email protected]>"

To: "penghao <[email protected]>"

CC: "perex <[email protected]>","tiwai <[email protected]>","alsa-devel <[email protected]>","linux-kernel <[email protected]>","phz0008 <[email protected]>","[email protected] <[email protected]>"

Sent: 2020-07-25 13:48

Subject: Re: [PATCH 14216/14216] ALSA: usb-audio: This patch for prevent autowakeup from s3 trig by usb disconnect signal from Lenovo ThinkcentreTI024Gen3 USB-audio.

Quoted 6 lines · penghao

From: "[email protected]" <[email protected]>

TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens enter sleep mode, USB-audio will disconnect from USB bus port, so disabled the /sys/bus/usb/*/power/wakeup Fixesimmediately wakup form s3 state

Why the indentation?

Quoted 3 lines

We need a name, not just an email address.
And where are the 14215 other patches in this patch series?

sound/usb/card.c static int usb_audio_probe(struct usb_interface

Quoted 9 lines
---
 sound/usb/card.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/usb/card.c +0 -0
index 2644a5ae2b75..969c3809e051 100644
@@ -640,6 +640,12 @@ static int usb_audio_probe(struct usb_interface

*intf,

sound/usb/card.c static int usb_audio_probe(struct usb_interface *intf, · line 648

Quoted 9 lines
sound/usb/card.c +6 -0
  }
  }
  dev_set_drvdata(&dev->dev, chip);
+ /*
+ * ALSA: usb-audio: Add prevent wakeup from s3 state trig by lenovo
+ * ThinkCentre TI024Gen3 USB-audio
+ */
+ if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012))
+ device_set_wakeup_enable(&dev->dev, 0);

Shouldn't there be a quirk for this type of device that can be used instead?
thanks,
greg k-h

#3 lore raw

Re: Re: [PATCH 14216/14216] ALSA: usb-audio: This patch for prevent autowakeup from s3 trig by usb disconnect signal from Lenovo ThinkcentreTI024Gen3 USB-audio.

Quoted 8 lines · 彭浩

This email message is intended only for the use of the individual or entity who /which is the intended recipient and may contain information that is privileged or confidential. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of, or taking any action in reliance on, this e-mail is strictly prohibited. If you have received this email in error, please notify UnionTech Software Technology immediately by replying to this e-mail and immediately delete and discard all copies of the e-mail and the attachment thereto (if any). Thank you.

Please note that this email footer is not compatible with kernel development, so I have now removed it from my system.

greg k-h