Skip to contentSkip to conversation

mac80211: remove STA txq pending airtime underflow warning

PATCH In review Felix Fietkau 2 participants 2 messages Jul 25, 2020 – Aug 11, 2020 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: remove STA txq pending airtime underflow warning

This warning can trigger if there is a mismatch between frames that were sent with the sta pointer set vs tx status frames reported for the sta address.

This can happen due to race conditions on re-creating stations, or even in the case of .sta_add/remove being used instead of .sta_state, which can cause frames to be sent to a station that has not been uploaded yet.

If there is an actual underflow issue, it should show up in the device airtime warning below, so it is better to remove this one.

---
 net/mac80211/sta_info.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
net/mac80211/sta_info.c +1 -3
index cd8487bc6fc2..af4cc5fb678e 100644
@@ -1923,9 +1923,7 @@ void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local,
 	if (sta) {
 		tx_pending = atomic_sub_return(tx_airtime,
 					       &sta->airtime[ac].aql_tx_pending);
-		if (WARN_ONCE(tx_pending < 0,
-			      "STA %pM AC %d txq pending airtime underflow: %u, %u",
-			      sta->addr, ac, tx_pending, tx_airtime))
+		if (tx_pending < 0)
 			atomic_cmpxchg(&sta->airtime[ac].aql_tx_pending,
 				       tx_pending, 0);
 	}
Signature · 1 line
2.24.0
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Felix Fietkau

This warning can trigger if there is a mismatch between frames that were sent with the sta pointer set vs tx status frames reported for the sta address.

This can happen due to race conditions on re-creating stations, or even in the case of .sta_add/remove being used instead of .sta_state, which can cause frames to be sent to a station that has not been uploaded yet.

If there is an actual underflow issue, it should show up in the device airtime warning below, so it is better to remove this one.

Fair enough.