Skip to contentSkip to conversation

Fix one coding style issue

PATCH In review Anant Thazhemadam 2 participants 2 messages Jul 25, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix one coding style issue

The coding style issue that raised an error (upon checking against checkpatch.pl) has been fixed.
Exactly one coding style issue has been fixed; as required by Task 10 of the Eudyptula Challenge.

---
 drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_security.c +3 -1
index 21f6652dd69f..dc22ee9c24ad 100644
@@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
 				res = _FAIL;
 			}
 		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
+				 ("%s: stainfo==NULL!!!\n", __func__)
+				);
 			res = _FAIL;
 		}
 	}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Anant Thazhemadam

The coding style issue that raised an error (upon checking against checkpatch.pl) has been fixed.

You are not saying what issue was fixed.

Also, your subject line needs to be fixed, please see the link provided by the bot previously for what to do.

Quoted 2 lines

Exactly one coding style issue has been fixed; as required by Task 10 of the Eudyptula Challenge.

We don't care why you are doing this work, no need to put that in the changelog.

Quoted 11 lines
---
 drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_security.c +0 -0
index 21f6652dd69f..dc22ee9c24ad 100644

drivers/staging/rtl8188eu/core/rtw_security.c u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) · line 723

Quoted 7 lines
drivers/staging/rtl8188eu/core/rtw_security.c +3 -1
@@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
 				res = _FAIL;
 			}
 		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
+				 ("%s: stainfo==NULL!!!\n", __func__)
+				);

Very odd line breaks, this now looks worse than before :(

thanks,

greg k-h