cg_read_strcmp: Fix null pointer dereference
PATCH 1/1 cg_read_strcmp: Fix null pointer dereference
Passing NULL in strcmp will cause a segmentation fault. Fix this by returning -1 if expected is NULL pointer.
Signed-off-by Gaurav Singh <[email protected]>
--- tools/testing/selftests/cgroup/cgroup_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/cgroup/cgroup_util.c +1 -1
@@ -106,7 +106,7 @@ int cg_read_strcmp(const char *cgroup, const char *control,/* Handle the case of comparing against empty string */ if (!expected) - size =32 ; +return -1 ;else size =strlen (expected) +1 ;
Signature · 1 line
2.17.1
Quoted 2 lines · Gaurav Singh
Passing NULL in strcmp will cause a segmentation fault. Fix this by returning -1 if expected is NULL pointer.
Did you actually encounter this while running the tests?
PATCH 1/1 cg_read_strcmp: Fix null pointer dereference
In reply to Gaurav SinghHaven't reproduced this issue. This PR is does a minor code cleanup.
Signed-off-by Gaurav Singh <[email protected]>
--- tools/testing/selftests/cgroup/cgroup_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/cgroup/cgroup_util.c +1 -1
@@ -106,7 +106,7 @@ int cg_read_strcmp(const char *cgroup, const char *control,/* Handle the case of comparing against empty string */ if (!expected) - size =32 ; +return -1 ;else size =strlen (expected) +1 ;
Signature · 1 line
2.17.1