Skip to contentSkip to conversation

fb_flashcursor: Remove redundant null check

PATCH In review Gaurav Singh 2 participants 2 messages Jul 26, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fb_flashcursor: Remove redundant null check

ops cannot be NULL as its being accessed later without checks. Remove the redundant NULL check.

---
 drivers/video/fbdev/core/fbcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/core/fbcon.c +1 -1
index e2a490c5ae08..9551f40c6d14 100644
@@ -401,7 +401,7 @@ static void fb_flashcursor(struct work_struct *work)
 	if (ret = 0)
 		return;
 
-	if (ops && ops->currcon != -1)
+	if (ops->currcon != -1)
 		vc = vc_cons[ops->currcon].d;
 
 	if (!vc || !con_is_visible(vc) ||
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Gaurav Singh

ops cannot be NULL as its being accessed later without

it's

Quoted 1 line

checks. Remove the redundant NULL check.

Commit message doesn't clarify why your fix is the correct one. Maybe it's the other way around, missed check in the rest of the code there?

Signature · 2 lines
With Best Regards,
Andy Shevchenko