Skip to contentSkip to conversation

MAINTAINERS: Remove JZ4780 DMA driver entry

PATCH Superseded Krzysztof Kozlowski 3 participants 6 messages Jul 26, 2020 – Aug 2, 2020 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 MAINTAINERS: Remove JZ4780 DMA driver entry

The entry for MIPS Ingenic JZ4780 DMA driver is not up to date anymore. Zubair Lutfullah Kakakhel's email bounces and no maintenance is provided.

---

Changes since v1:
1. New patch

---
 MAINTAINERS | 5 -----
 1 file changed, 5 deletions(-)
MAINTAINERS +0 -5
index cba0ed77775b..362863cae239 100644
@@ -8541,11 +8541,6 @@ F:	include/uapi/rdma/
 F:	samples/bpf/ibumad_kern.c
 F:	samples/bpf/ibumad_user.c
 
-INGENIC JZ4780 DMA Driver
-M:	Zubair Lutfullah Kakakhel <[email protected]>
-S:	Maintained
-F:	drivers/dma/dma-jz4780.c
-
 INGENIC JZ4780 NAND DRIVER
 M:	Harvey Hunt <[email protected]>
 L:	[email protected]
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 2/2 MAINTAINERS: Add linux-mips mailing list to JZ47xx entries

The entries for JZ47xx SoCs and its drivers lacked MIPS mailing list. Only MTD NAND driver pointed linux-mtd. Add linux-mips so the relevant patches will get attention of MIPS developers.

---

Changes since v1:
1. Do not update DMA driver entry
2. Add ack

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 362863cae239..d1cc0afe0762 100644
@@ -8544,11 +8544,13 @@ F:	samples/bpf/ibumad_user.c
 INGENIC JZ4780 NAND DRIVER
 M:	Harvey Hunt <[email protected]>
 L:	[email protected]
+L:	[email protected]
 S:	Maintained
 F:	drivers/mtd/nand/raw/ingenic/
 
 INGENIC JZ47xx SoCs
 M:	Paul Cercueil <[email protected]>
+L:	[email protected]
 S:	Maintained
 F:	arch/mips/boot/dts/ingenic/
 F:	arch/mips/include/asm/mach-jz4740/
Signature · 1 line
2.17.1
#2 lore raw
In reply to Krzysztof Kozlowski

MAINTAINERS F: include/uapi/rdma/ · line 8548

Quoted 13 lines · Krzysztof Kozlowski
MAINTAINERS +0 -5
index cba0ed77775b..362863cae239 100644
@@ -8541,11 +8541,6 @@ F:	include/uapi/rdma/
 F:	samples/bpf/ibumad_kern.c
 F:	samples/bpf/ibumad_user.c
 
-INGENIC JZ4780 DMA Driver
-M:	Zubair Lutfullah Kakakhel <[email protected]>
-S:	Maintained
-F:	drivers/dma/dma-jz4780.c
-

FYI, the usual approach would be marking the entry "Orphan" rather than
removing it entirely, so that the mapping remains and makes it easy for someone to pick it up.

Maciej

#3 lore raw

Hi Maciej,

Quoted 16 lines · Maciej W. Rozycki
Quoted 8 lines · Krzysztof Kozlowski

diff --git a/MAINTAINERS b/MAINTAINERS
index cba0ed77775b..362863cae239 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8541,11 +8541,6 @@ F: include/uapi/rdma/
F: samples/bpf/ibumad_kern.c
F: samples/bpf/ibumad_user.c

Quoted 5 lines

-INGENIC JZ4780 DMA Driver
-M: Zubair Lutfullah Kakakhel <[email protected]>
-S: Maintained
-F: drivers/dma/dma-jz4780.c
-

Quoted 4 lines

FYI, the usual approach would be marking the entry "Orphan" rather
than
removing it entirely, so that the mapping remains and makes it easy for someone to pick it up.

This is OK in this case, as the driver is also listed as part of the "INGENIC JZ47xx SoCs".

-Paul

#4 lore raw
Quoted 8 lines · Paul Cercueil
Quoted 5 lines

FYI, the usual approach would be marking the entry "Orphan" rather
than
removing it entirely, so that the mapping remains and makes it easy for
someone to pick it up.

This is OK in this case, as the driver is also listed as part of the "INGENIC JZ47xx SoCs".

Fair enough (and odd enough too to have two entries for one piece),
though in this case I think the commit description ought to mention it. As it stands it makes one think the driver is not going to have a maintainer anymore: "[...] and no maintenance is provided."

Maciej

#5 lore raw
Quoted 9 lines · Maciej W. Rozycki
Quoted 6 lines · Paul Cercueil
Quoted 5 lines

FYI, the usual approach would be marking the entry "Orphan" rather
than
removing it entirely, so that the mapping remains and makes it easy for
someone to pick it up.

Quoted 7 lines
Quoted 2 lines

This is OK in this case, as the driver is also listed as part of the "INGENIC JZ47xx SoCs".

Fair enough (and odd enough too to have two entries for one piece),
though in this case I think the commit description ought to mention it. As it stands it makes one think the driver is not going to have a maintainer anymore: "[...] and no maintenance is provided."

Sure, the message could be improved. How about:

"The entry for MIPS Ingenic JZ4780 DMA driver is not up to date anymore. Zubair Lutfullah Kakakhel's email bounces. The maintenance is provided through Ingenic SoC maintainers entry."

If it is OK, I can either resend or it could be fixed up when applying.

Best regards,
Krzysztof