dt-bindings: lpspi: New property in document DT bindings for LPSPI
Subsystems (3)
PATCH v2 4/4 dt-bindings: lpspi: New property in document DT bindings for LPSPI
Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
Spi common code does not support use of CS signals discontinuously. It only uses CS1 without using CS0. So, add this property to re-config chipselect value.
---
Changes:
V2:
- New patch added in the v2 patchset.
--- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +7 -0
@@ -34,6 +34,12 @@ properties: - const: per - const: ipg + fsl,spi-only-use-cs1-sel: + description: + spi common code does not support use of CS signals discontinuously. + i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add + this property to re-config the chipselect value in the LPSPI driver. + required: - compatible - reg
@@ -57,4 +63,5 @@ examples: <&clks IMX7ULP_CLK_DUMMY>; clock-names = "per", "ipg"; spi-slave; + fsl,spi-only-use-cs1-sel; };
Signature · 1 line
2.17.1
Quoted 20 lines · Clark Wang
Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
Spi common code does not support use of CS signals discontinuously. It only uses CS1 without using CS0. So, add this property to re-config chipselect value.Signed-off-by Clark Wang <[email protected]>---
Changes:
V2:
- New patch added in the v2 patchset.--- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +0
-0
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml properties: · line 41
Quoted 8 lines
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +5
-0@@ -34,6 +34,12 @@ properties: - const: per - const: ipg + fsl,spi-only-use-cs1-sel: + description: + spi common code does not support use of CS signals discontinuously. + i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add + this property to re-config the chipselect value in the LPSPI driver.
This breaks linux-next and you didn't test with 'make dt_binding_check':
/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code
does not support use of CS signals discontinuously. i.MX8DXL-EVK board
only uses CS1 without using CS0. Therefore, add this property to
re-config the chipselect value in the LPSPI driver.'} is not valid
under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: 'not' is a required property
The problem is you need a type definition for a vendor specific property. In this case 'type: boolean'.
Rob
Quoted 42 lines · Rob Herring
Quoted 20 lines · Clark Wang
Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
Spi common code does not support use of CS signals discontinuously. It only uses CS1 without using CS0. So, add this property to re-config chipselect value.Signed-off-by Clark Wang <[email protected]>---
Changes:
V2:
- New patch added in the v2 patchset.--- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +0
-0Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml properties: · line 41
Quoted 8 lines
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +5
-0@@ -34,6 +34,12 @@ properties: - const: per - const: ipg + fsl,spi-only-use-cs1-sel: + description: + spi common code does not support use of CS signals discontinuously. + i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add + this property to re-config the chipselect value in the LPSPI driver.This breaks linux-next and you didn't test with 'make
dt_binding_check':/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code
does not support use of CS signals discontinuously. i.MX8DXL-EVK board
only uses CS1 without using CS0. Therefore, add this property to
re-config the chipselect value in the LPSPI driver.'} is not valid
under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: 'not' is a required property
Quoted 2 lines
The problem is you need a type definition for a vendor specific property. In this case 'type: boolean'.
Ping! And now Linus' tree is broken. If you can't be bothered to fix this, perhaps it should be reverted.
Rob