Skip to contentSkip to conversation

fs/fs-writeback.c: not WARN on unregistered BDI

PATCH In review Ming Lei 2 participants 4 messages Jun 11, 2020 – Jul 27, 2020

Subsystems (2)
lore
Share & tools
lore

Ming Lei

author
#0 lore raw

PATCH 1/1 fs/fs-writeback.c: not WARN on unregistered BDI

BDI is unregistered from del_gendisk() which is usually done in device's release handler from device hotplug or error handling context, so BDI can be unregistered anytime.

It should be normal for __mark_inode_dirty to see un-registered BDI, so kill the WARN().

Cc Alexander Viro <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Brian Foster <[email protected]>
Cc Dave Chinner <[email protected]>
Cc Jens Axboe <[email protected]>
---
 fs/fs-writeback.c | 4 ----
 1 file changed, 4 deletions(-)
fs/fs-writeback.c +0 -4
index a605c3dddabc..5e718580d4bf 100644
@@ -2318,10 +2318,6 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 
 			wb = locked_inode_to_wb_and_lock_list(inode);
 
-			WARN(bdi_cap_writeback_dirty(wb->bdi) &&
-			     !test_bit(WB_registered, &wb->state),
-			     "bdi-%s not registered\n", bdi_dev_name(wb->bdi));
-
 			inode->dirtied_when = jiffies;
 			if (dirtytime)
 				inode->dirtied_time_when = jiffies;
Signature · 1 line
2.25.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ming Lei

BDI is unregistered from del_gendisk() which is usually done in device's release handler from device hotplug or error handling context, so BDI can be unregistered anytime.

It should be normal for __mark_inode_dirty to see un-registered BDI, so kill the WARN().

Looks good:

author
#2 lore raw
In reply to Ming Lei
Quoted 7 lines · Ming Lei

BDI is unregistered from del_gendisk() which is usually done in device's release handler from device hotplug or error handling context, so BDI can be unregistered anytime.

It should be normal for __mark_inode_dirty to see un-registered BDI, so kill the WARN().

Quoted 7 lines
Cc Alexander Viro <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Brian Foster <[email protected]>
Cc Dave Chinner <[email protected]>
Cc Jens Axboe <[email protected]>

Hello Guys,

Ping...

Thanks,
Ming

author
#3 lore raw
In reply to Ming Lei
Quoted 23 lines · Ming Lei

BDI is unregistered from del_gendisk() which is usually done in device's release handler from device hotplug or error handling context, so BDI can be unregistered anytime.

It should be normal for __mark_inode_dirty to see un-registered BDI, so kill the WARN().

Cc Alexander Viro <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Brian Foster <[email protected]>
Cc Dave Chinner <[email protected]>
Cc Jens Axboe <[email protected]>
---
 fs/fs-writeback.c | 4 ----
 1 file changed, 4 deletions(-)
fs/fs-writeback.c +0 -0
index a605c3dddabc..5e718580d4bf 100644

fs/fs-writeback.c void __mark_inode_dirty(struct inode *inode, int flags) · line 2323

Quoted 10 lines
fs/fs-writeback.c +0 -4
@@ -2318,10 +2318,6 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 
 			wb = locked_inode_to_wb_and_lock_list(inode);
 
-			WARN(bdi_cap_writeback_dirty(wb->bdi) &&
-			     !test_bit(WB_registered, &wb->state),
-			     "bdi-%s not registered\n", bdi_dev_name(wb->bdi));
-
 			inode->dirtied_when = jiffies;
 			if (dirtytime)
 				inode->dirtied_time_when = jiffies;

Hello Alexander,

Could you merge this patch if you are fine?

Thanks,
Ming