udf: use common error code for unclean filesystem
PATCH 1/1 udf: use common error code for unclean filesystem
Use common error code for unclean filesystem, and warn when incosistency is detected.
Signed-off-by Pavel Machek (CIP) <[email protected]>
fs/udf/inode.c +4 -1
@@ -1395,7 +1395,10 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode)if (iinfo->i_alloc_type !=ICBTAG_FLAG_AD_SHORT && iinfo->i_alloc_type !=ICBTAG_FLAG_AD_LONG && iinfo->i_alloc_type !=ICBTAG_FLAG_AD_IN_ICB ) { - ret = -EIO ; + ret = -EUCLEAN ; +udf_err (inode->i_sb,"invalid allocation type: %u\n" , + iinfo->i_alloc_type); + goto out; } iinfo->i_unique =0 ;
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 5 lines · Pavel Machek
Use common error code for unclean filesystem, and warn when incosistency is detected.
Signed-off-by Pavel Machek (CIP) <[email protected]>
So this is going in the right direction but there are *much* more places that would need a similar treatment (furthermore I'd prefer to use the EFSCORRUPTED redefine of EUCLEAN as other filesystems do). Any reason why you converted this particular place?
Honza
Quoted 21 lines
fs/udf/inode.c +4
-1@@ -1395,7 +1395,10 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode)if (iinfo->i_alloc_type !=ICBTAG_FLAG_AD_SHORT && iinfo->i_alloc_type !=ICBTAG_FLAG_AD_LONG && iinfo->i_alloc_type !=ICBTAG_FLAG_AD_IN_ICB ) { - ret = -EIO ; + ret = -EUCLEAN ; +udf_err (inode->i_sb,"invalid allocation type: %u\n" , + iinfo->i_alloc_type); + goto out; } iinfo->i_unique =0 ;Signature · 3 lines
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR