usertools/dpdk-devbind: hide "if" value for non-network devs
PATCH 1/1 usertools/dpdk-devbind: hide "if" value for non-network devs
The "if", or interface, field in the status display of dpdk-devbind is only relevant for network interfaces, so don't display it for other device types.
--- usertools/dpdk-devbind.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
usertools/dpdk-devbind.py +6 -3
@@ -585,7 +585,7 @@ def display_devices(title, dev_list, extra_params=None): strings.sort() print("\n".join(strings)) # print one per line -def show_device_status(devices_type, device_name): +def show_device_status(devices_type, device_name, if_field=False): global dpdk_drivers kernel_drv = [] dpdk_drv = []
@@ -617,8 +617,11 @@ def show_device_status(devices_type, device_name): display_devices("%s devices using DPDK-compatible driver" % device_name, dpdk_drv, "drv=%(Driver_str)s unused=%(Module_str)s") if len(kernel_drv) != 0: + if_text = "" + if if_field: + if_text = "if=%(Interface)s " display_devices("%s devices using kernel driver" % device_name, kernel_drv, - "if=%(Interface)s drv=%(Driver_str)s " + if_text + "drv=%(Driver_str)s " "unused=%(Module_str)s %(Active)s") if len(no_drv) != 0: display_devices("Other %s devices" % device_name, no_drv,
@@ -630,7 +633,7 @@ def show_status(): kernel driver or to no driver''' if status_dev == "net" or status_dev == "all": - show_device_status(network_devices, "Network") + show_device_status(network_devices, "Network", if_field=True) if status_dev == "baseband" or status_dev == "all": show_device_status(baseband_devices, "Baseband")
Signature · 1 line
2.25.1
Quoted 6 lines · Bruce Richardson
The "if", or interface, field in the status display of dpdk-devbind is only relevant for network interfaces, so don't display it for other device types.
Signed-off-by Bruce Richardson <[email protected]>---
We should probably get away from using legacy string formatting with % operator, but that's out of scope here :)
Signature · 2 lines
Thanks, Anatoly
Thomas Monjalon
Applied28/07/2020 12:12, Burakov, Anatoly:
Quoted 5 lines · Bruce Richardson
Quoted 4 lines
The "if", or interface, field in the status display of dpdk-devbind is only relevant for network interfaces, so don't display it for other device types.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Bruce Richardson <[email protected]>---
We should probably get away from using legacy string formatting with % operator, but that's out of scope here :)
Acked-by Anatoly Burakov <[email protected]>
Applied, thanks