Skip to contentSkip to conversation

Convert chdir01 to the new API

PATCH New Martin Doucha 2 participants 2 messages Jul 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Convert chdir01 to the new API

chdir02 and chdir03 were removed because the updated chdir01 makes them redundant.

---

Changes since v1:
- Require root privileges and run the test on all file systems
- Fixed expected return value for directory with 0644 access mode
- Added test case for chdir("/");
- Improved chdir() return value/errno checks

Changes since v2:
- Dropped chdir02 patch and merged the unprivileged tests into chdir01 instead

 runtest/quickhit                           |   2 +-
 runtest/syscalls                           |   2 -
 testcases/kernel/syscalls/chdir/.gitignore |   2 -
 testcases/kernel/syscalls/chdir/chdir01.c  | 271 +++++++++------------
 testcases/kernel/syscalls/chdir/chdir02.c  | 163 -------------
 testcases/kernel/syscalls/chdir/chdir03.c  |  68 ------
 6 files changed, 118 insertions(+), 390 deletions(-)
 delete mode 100644 testcases/kernel/syscalls/chdir/chdir02.c
 delete mode 100644 testcases/kernel/syscalls/chdir/chdir03.c
runtest/quickhit +1 -1
index e01b838fb..b17318b65 100644
@@ -24,7 +24,7 @@ brk01 brk01
 # Basic test for brk()
 #    TEST CASES
 # 	1.) brk(2) returns...
-chdir02 chdir02
+chdir01 chdir01
 # Basic test for chdir(2)
 #    TEST CASES
 # 	1.) chdir(2) returns...
runtest/syscalls +0 -2
index c2bfc6df3..70b3277d3 100644
@@ -55,8 +55,6 @@ cacheflush01 cacheflush01
 
 chdir01 chdir01
 chdir01A symlink01 -T chdir01
-chdir02 chdir02
-chdir03 chdir03
 chdir04 chdir04
 
 chmod01 chmod01
testcases/kernel/syscalls/chdir/.gitignore +0 -2
index c1e4b9d07..1b15eb6b9 100644
@@ -1,4 +1,2 @@
 /chdir01
-/chdir02
-/chdir03
 /chdir04
testcases/kernel/syscalls/chdir/chdir01.c +117 -154

298 lines not on this page · raw message

testcases/kernel/syscalls/chdir/chdir02.c deleted +0 -163

163 lines not on this page · raw message

testcases/kernel/syscalls/chdir/chdir03.c deleted +0 -68

68 lines not on this page · raw message

Signature · 1 line
2.26.2
#1 lore raw

PATCH v3 1/1 Convert chdir01 to the new API

Hi Martin,

Quoted 6 lines

chdir02 and chdir03 were removed because the updated chdir01 makes them redundant.

---

Quoted 8 lines

Changes since v1:
- Require root privileges and run the test on all file systems
- Fixed expected return value for directory with 0644 access mode
- Added test case for chdir("/");
- Improved chdir() return value/errno checks

Changes since v2:
- Dropped chdir02 patch and merged the unprivileged tests into chdir01 instead

Thanks, merged!

Kind regards,
Petr