package/python-matplotlib: add QT5 support
PATCH v2 1/1 package/python-matplotlib: add QT5 support
From: Gwenhael Goavec-Merou <[email protected]>
python-matplotlib may be used in qt5 application. This patch add option to enable qt5. Since this backend is automatically enabled when pyqt5 is detected, list dependencies is simply an updated (no enable/disable options).
---
Changes v1 -> v2
- move options before comment (Thomas)
- remove select BR2_PACKAGE_QT5BASE_GUI (already done by python-pyqt5) (Thomas)
- suppress qt5base to PYTHON_MATPLOTLIB_DEPENDENCIES (Thomas)
--- package/python-matplotlib/Config.in | 12 ++++++++++++ package/python-matplotlib/python-matplotlib.mk | 4 ++++ 2 files changed, 16 insertions(+)
package/python-matplotlib/Config.in +12 -0
@@ -23,6 +23,18 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB https://matplotlib.org/ +if BR2_PACKAGE_PYTHON_MATPLOTLIB + +config BR2_PACKAGE_PYTHON_MATPLOTLIB_QT + bool "qt display" + depends on BR2_PACKAGE_QT5 # python-pyqt5 + select BR2_PACKAGE_PYTHON_PYQT5 + select BR2_PACKAGE_QT5BASE + select BR2_PACKAGE_QT5BASE_FONTCONFIG + select BR2_PACKAGE_QT5BASE_WIDGETS + +endif + comment "python-matplotlib needs a toolchain w/ C++" depends on !BR2_INSTALL_LIBSTDCPP
package/python-matplotlib/python-matplotlib.mk +4 -0
@@ -13,4 +13,8 @@ PYTHON_MATPLOTLIB_DEPENDENCIES = host-pkgconf freetype host-python-numpy \ libpng python-cycler PYTHON_MATPLOTLIB_SETUP_TYPE = setuptools +ifeq ($(BR2_PACKAGE_PYTHON_MATPLOTLIB_QT),y) +PYTHON_MATPLOTLIB_DEPENDENCIES += python-pyqt5 +endif + $(eval $(python-package))
Signature · 1 line
2.20.1
PATCH v2 1/1 package/python-matplotlib: add QT5 support
Gwenhael, All,
On 2020-07-27 15:00 +0200, Gwenhael Goavec-Merou spake thusly:
Quoted 11 lines
From: Gwenhael Goavec-Merou <[email protected]>
python-matplotlib may be used in qt5 application. This patch add option to enable qt5. Since this backend is automatically enabled when pyqt5 is detected, list dependencies is simply an updated (no enable/disable options).
Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
Changes v1 -> v2
- move options before comment (Thomas)
- remove selectBR2_PACKAGE_QT5BASE_GUI(already done by python-pyqt5) (Thomas)
I find it very annoying that we rely on another package to guarantee the dependencies. Maybe it is redundant now, but what if pytqt5 drops the GUI dependency in a future version?
Anyway, applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 49 lines
- suppress qt5base to
PYTHON_MATPLOTLIB_DEPENDENCIES(Thomas)--- package/python-matplotlib/Config.in | 12 ++++++++++++ package/python-matplotlib/python-matplotlib.mk | 4 ++++ 2 files changed, 16 insertions(+)package/python-matplotlib/Config.in +12
-0@@ -23,6 +23,18 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB https://matplotlib.org/ +if BR2_PACKAGE_PYTHON_MATPLOTLIB + +config BR2_PACKAGE_PYTHON_MATPLOTLIB_QT + bool "qt display" + depends on BR2_PACKAGE_QT5 # python-pyqt5 + select BR2_PACKAGE_PYTHON_PYQT5 + select BR2_PACKAGE_QT5BASE + select BR2_PACKAGE_QT5BASE_FONTCONFIG + select BR2_PACKAGE_QT5BASE_WIDGETS + +endif + comment "python-matplotlib needs a toolchain w/ C++" depends on !BR2_INSTALL_LIBSTDCPPpackage/python-matplotlib/python-matplotlib.mk +4
-0@@ -13,4 +13,8 @@ PYTHON_MATPLOTLIB_DEPENDENCIES = host-pkgconf freetype host-python-numpy \ libpng python-cycler PYTHON_MATPLOTLIB_SETUP_TYPE = setuptools +ifeq ($(BR2_PACKAGE_PYTHON_MATPLOTLIB_QT),y) +PYTHON_MATPLOTLIB_DEPENDENCIES += python-pyqt5 +endif + $(eval $(python-package))Signature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'