Skip to contentSkip to conversation

net: mvneta: improve phylink_speed_up/down usage

PATCH Superseded Jisheng Zhang 2 participants 5 messages Jul 27, 2020 – Jul 29, 2020

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover net: mvneta: improve phylink_speed_up/down usage

patch1 fix the comment
patch2 tries to avoid unnecessary phylink_speed_up() and phylink_speed_down() during changing the mtu.

Jisheng Zhang (2):
net: mvneta: fix comment about phylink_speed_down
net: mvneta: Don't speed down the PHY when changing mtu

 drivers/net/ethernet/marvell/mvneta.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.28.0.rc0
#1 lore raw

PATCH 1/2 net: mvneta: fix comment about phylink_speed_down

mvneta has switched to phylink, so the comment should look like "We may have called phylink_speed_down before".

---
 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvneta.c +1 -1
index 2c9277e73cef..c9b6b0f85bb0 100644
@@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
 
 	phylink_start(pp->phylink);
 
-	/* We may have called phy_speed_down before */
+	/* We may have called phylink_speed_down before */
 	phylink_speed_up(pp->phylink);
 
 	netif_tx_start_all_queues(pp->dev);
Signature · 1 line
2.28.0.rc0
#2 lore raw

PATCH 2/2 net: mvneta: Don't speed down the PHY when changing mtu

In reply to Jisheng Zhang

We found a case where the phy link speed is changed to 10Mbps then back to 1000Mbps when changing the mtu:

ethtool -s eth0 wol g
ip link set eth0 mtu 1400

Add a simple check to avoid unnecessary phylink_speed_down() when changing the mtu.

---
 drivers/net/ethernet/marvell/mvneta.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvneta.c +2 -1
index c9b6b0f85bb0..9cdbb05277eb 100644
@@ -3651,7 +3651,8 @@ static void mvneta_stop_dev(struct mvneta_port *pp)
 
 	set_bit(__MVNETA_DOWN, &pp->state);
 
-	if (device_may_wakeup(&pp->dev->dev))
+	if (device_may_wakeup(&pp->dev->dev) &&
+	    pp->pkt_size == MVNETA_RX_PKT_SIZE(pp->dev->mtu))
 		phylink_speed_down(pp->phylink, false);
 
 	phylink_stop(pp->phylink);
Signature · 1 line
2.28.0.rc0
maintainer
#3 lore raw

Re: [PATCH net-nex 2/2] net: mvneta: Don't speed down the PHY when changing mtu

From: Jisheng Zhang <[email protected]>
Date: Mon, 27 Jul 2020 19:53:14 +0800

drivers/net/ethernet/marvell/mvneta.c static void mvneta_stop_dev(struct mvneta_port *pp) · line 3657

Quoted 9 lines
drivers/net/ethernet/marvell/mvneta.c +2 -1
@@ -3651,7 +3651,8 @@ static void mvneta_stop_dev(struct mvneta_port *pp)
 
 	set_bit(__MVNETA_DOWN, &pp->state);
 
-	if (device_may_wakeup(&pp->dev->dev))
+	if (device_may_wakeup(&pp->dev->dev) &&
+	    pp->pkt_size == MVNETA_RX_PKT_SIZE(pp->dev->mtu))
 		phylink_speed_down(pp->phylink, false);
 

This is too much for me.

You shouldn't have to shut down the entire device and take it back up again just to change the MTU.

Unfortunately, this is a common pattern in many drivers and it is very dangerous to take this lazy path of just doing "stop/start" around the MTU change.

It means you can't recover from partial failures properly, f.e. recovering from an inability to allocate queue resources for the new MTU.

To solve this properly, you must restructure the MTU change such that is specifically stops the necessary and only the units of the chip necessary to change the MTU.

It should next try to allocate the necessary resources to satisfy the MTU change, keeping the existing resources allocated in case of failure.

Then, only is all resources are successfully allocated, it should commit the MTU change fully and without errors.

Then none of these link flapping issues are even possible.

#4 lore raw

Re: [PATCH net-nex 2/2] net: mvneta: Don't speed down the PHY when changing mtu

Hi David,

Quoted 29 lines · On Tue, 28 Jul 2020 17:52:02 -0700 (PDT) David Miller wrote:

drivers/net/ethernet/marvell/mvneta.c static void mvneta_stop_dev(struct mvneta_port *pp) · line 3657

Quoted 11 lines
drivers/net/ethernet/marvell/mvneta.c +2 -1
@@ -3651,7 +3651,8 @@ static void mvneta_stop_dev(struct mvneta_port *pp)
 
      set_bit(__MVNETA_DOWN, &pp->state);
 
-     if (device_may_wakeup(&pp->dev->dev))
+     if (device_may_wakeup(&pp->dev->dev) &&
+         pp->pkt_size == MVNETA_RX_PKT_SIZE(pp->dev->mtu))
              phylink_speed_down(pp->phylink, false);
 

This is too much for me.

You shouldn't have to shut down the entire device and take it back up again just to change the MTU.

Unfortunately, this is a common pattern in many drivers and it is very dangerous to take this lazy path of just doing "stop/start" around the MTU change.

It means you can't recover from partial failures properly, f.e. recovering from an inability to allocate queue resources for the new MTU.

To solve this properly, you must restructure the MTU change such that is specifically stops the necessary and only the units of the chip necessary to change the MTU.

Quoted 8 lines

It should next try to allocate the necessary resources to satisfy the MTU change, keeping the existing resources allocated in case of failure.

Then, only is all resources are successfully allocated, it should commit the MTU change fully and without errors.

Then none of these link flapping issues are even possible.

Thanks a lot for pointing out the correct direction. Refactoring change mtu method needs more time(maybe for linux-5.10 is reasonable), so I just drop patch2 in v2.