Skip to contentSkip to conversation

drm/ttm: drop unusued function declaration

PATCH In review Dave Airlie 2 participants 3 messages Jul 28, 2020 – Jul 29, 2020

Subsystems (2)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 drm/ttm: drop unusued function declaration

From: Dave Airlie <[email protected]>

This was removed in
f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

but the the declaration was left dangling.

---
 include/drm/ttm/ttm_bo_driver.h | 11 -----------
 1 file changed, 11 deletions(-)
include/drm/ttm/ttm_bo_driver.h +0 -11
index 71b195e78c7c..5a37f1cc057e 100644
@@ -525,17 +525,6 @@ ttm_flag_masked(uint32_t *old, uint32_t new, uint32_t mask)
  * ttm_bo.c
  */
 
-/**
- * ttm_mem_reg_is_pci
- *
- * @bdev: Pointer to a struct ttm_bo_device.
- * @mem: A valid struct ttm_mem_reg.
- *
- * Returns true if the memory described by @mem is PCI memory,
- * false otherwise.
- */
-bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, struct ttm_mem_reg *mem);
-
 /**
  * ttm_bo_mem_space
  *
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Am 28.07.20 um 06:51 schrieb Dave Airlie:

Quoted 8 lines

From: Dave Airlie <[email protected]>

This was removed in
f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

but the the declaration was left dangling.

Quoted 16 lines
---
  include/drm/ttm/ttm_bo_driver.h | 11 -----------
  1 file changed, 11 deletions(-)
include/drm/ttm/ttm_bo_driver.h +0 -4
index 71b195e78c7c..5a37f1cc057e 100644
@@ -525,17 +525,6 @@ ttm_flag_masked(uint32_t *old, uint32_t new, uint32_t mask)
   * ttm_bo.c
   */
 
-/**
- * ttm_mem_reg_is_pci
- *
- * @bdev: Pointer to a struct ttm_bo_device.

include/drm/ttm/ttm_bo_driver.h ttm_flag_masked(uint32_t *old, uint32_t new, uint32_t mask) · line 530

Quoted 10 lines
include/drm/ttm/ttm_bo_driver.h +0 -7
- * @mem: A valid struct ttm_mem_reg.
- *
- * Returns true if the memory described by @mem is PCI memory,
- * false otherwise.
- */
-bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, struct ttm_mem_reg *mem);
-
  /**
   * ttm_bo_mem_space
   *

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#2 lore raw
Quoted 4 lines · Christian König

Am 28.07.20 um 06:51 schrieb Dave Airlie:

Quoted 2 lines

From: Dave Airlie <[email protected]>

Quoted 8 lines
Quoted 6 lines

This was removed in
f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

but the the declaration was left dangling.

I've just pushed this, the unbind and swapout all to drm-next.

Though we should probably in future just have you merge them via misc.

Dave.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel