soc: qcom: pdr: Reorder the PD state indication ack
Subsystems (3)
PATCH RESEND 1/1 soc: qcom: pdr: Reorder the PD state indication ack
The Protection Domains (PD) have a mechanism to keep its resources enabled until the PD down indication is acked. Reorder the PD state indication ack so that clients get to release the relevant resources before the PD goes down.
---
I couldn't find the previous patch on patchworks. Resending the patch since it would need to land on stable trees as well
drivers/soc/qcom/pdr_interface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/soc/qcom/pdr_interface.c +3 -1
@@ -279,13 +279,15 @@ static void pdr_indack_work(struct work_struct *work)list_for_each_entry_safe (ind, tmp, &pdr->indack_list, node) { pds = ind->pds; -pdr_send_indack_msg (pdr, pds, ind->transaction_id);mutex_lock (&pdr->status_lock); pds->state = ind->curr_state; pdr->status (pds->state, pds->service_path, pdr->priv);mutex_unlock (&pdr->status_lock); +/* Ack the indication after clients release the PD resources */ +pdr_send_indack_msg (pdr, pds, ind->transaction_id); +mutex_lock (&pdr->list_lock);list_del (&ind->node);mutex_unlock (&pdr->list_lock);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 37 lines · Sibi Sankar
The Protection Domains (PD) have a mechanism to keep its resources enabled until the PD down indication is acked. Reorder the PD state indication ack so that clients get to release the relevant resources before the PD goes down.
Fixes fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")Reported-by Rishabh Bhatnagar <[email protected]>Signed-off-by Sibi Sankar <[email protected]>---
I couldn't find the previous patch on patchworks. Resending the patch since it would need to land on stable trees as well
drivers/soc/qcom/pdr_interface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/soc/qcom/pdr_interface.c +3
-1@@ -279,13 +279,15 @@ static void pdr_indack_work(struct work_struct *work)list_for_each_entry_safe (ind, tmp, &pdr->indack_list, node) { pds = ind->pds; -pdr_send_indack_msg (pdr, pds, ind->transaction_id);mutex_lock (&pdr->status_lock); pds->state = ind->curr_state; pdr->status (pds->state, pds->service_path, pdr->priv);mutex_unlock (&pdr->status_lock); +/* Ack the indication after clients release the PD resources */ +pdr_send_indack_msg (pdr, pds, ind->transaction_id); +mutex_lock (&pdr->list_lock);list_del (&ind->node);
Quoted 1 line
mutex_unlock(&pdr->list_lock);
Thanks,
Rishabh
Quoted 8 lines · Sibi Sankar
The Protection Domains (PD) have a mechanism to keep its resources enabled until the PD down indication is acked. Reorder the PD state indication ack so that clients get to release the relevant resources before the PD goes down.
Fixes fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")Reported-by Rishabh Bhatnagar <[email protected]>Signed-off-by Sibi Sankar <[email protected]>
Quoted 33 lines
---
I couldn't find the previous patch on patchworks. Resending the patch since it would need to land on stable trees as well
drivers/soc/qcom/pdr_interface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/soc/qcom/pdr_interface.c +3
-1@@ -279,13 +279,15 @@ static void pdr_indack_work(struct work_struct *work)list_for_each_entry_safe (ind, tmp, &pdr->indack_list, node) { pds = ind->pds; -pdr_send_indack_msg (pdr, pds, ind->transaction_id);mutex_lock (&pdr->status_lock); pds->state = ind->curr_state; pdr->status (pds->state, pds->service_path, pdr->priv);mutex_unlock (&pdr->status_lock); +/* Ack the indication after clients release the PD resources */ +pdr_send_indack_msg (pdr, pds, ind->transaction_id); +mutex_lock (&pdr->list_lock);list_del (&ind->node);mutex_unlock (&pdr->list_lock);Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project