USB: PHY: JZ4770: Add support for new Ingenic SoCs.
Hello 周琰杰 (Zhou Yanjie),
The patch 2a6c0b82e651: "USB: PHY: JZ4770: Add support for new Ingenic SoCs." from Jul 23, 2020, leads to the following static checker warning:
drivers/usb/phy/phy-jz4770.c:179 ingenic_usb_phy_init() error: uninitialized symbol 'reg'.
drivers/usb/phy/phy-jz4770.c
157 static int ingenic_usb_phy_init(struct usb_phy *phy) 158 {
159 struct jz4770_phy *priv = phy_to_jz4770_phy(phy);
160 int err;
161 u32 reg;
^^^
162
163 err = regulator_enable(priv->vcc_supply);
164 if (err) {
165 dev_err(priv->dev, "Unable to enable VCC: %d\n", err);
166 return err;
167 }
168
169 err = clk_prepare_enable(priv->clk);
170 if (err) {
171 dev_err(priv->dev, "Unable to start clock: %d\n", err);
172 return err;
173 }
174
175 priv->soc_info->usb_phy_init(phy);
176
177 /* Wait for PHY to reset */
178 usleep_range(30, 300);
179 writel(reg & ~USBPCR_POR, priv->base + REG_USBPCR_OFFSET);
^^^Not initialized any more.
180 usleep_range(300, 1000); 181 182 return 0; 183 }
regards,
dan carpenter
Hello,
Quoted 37 lines · 在 2020/7/28 下午7:51, [email protected] 写道:
Hello 周琰杰 (Zhou Yanjie),
The patch
2a6c0b82e651: "USB: PHY: JZ4770: Add support for new Ingenic SoCs." from Jul 23, 2020, leads to the following static checker warning:drivers/usb/phy/phy-jz4770.c:179 ingenic_usb_phy_init() error: uninitialized symbol 'reg'.
drivers/usb/phy/phy-jz4770.c157 static int ingenic_usb_phy_init(struct usb_phy *phy) 158 { 159 struct jz4770_phy *priv = phy_to_jz4770_phy(phy); 160 int err; 161 u32 reg; ^^^ 162 163 err = regulator_enable(priv->vcc_supply); 164 if (err) { 165 dev_err(priv->dev, "Unable to enable VCC: %d\n", err); 166 return err; 167 } 168 169 err = clk_prepare_enable(priv->clk); 170 if (err) { 171 dev_err(priv->dev, "Unable to start clock: %d\n", err); 172 return err; 173 } 174 175 priv->soc_info->usb_phy_init(phy); 176 177 /* Wait for PHY to reset */ 178 usleep_range(30, 300); 179 writel(reg & ~USBPCR_POR, priv->base + REG_USBPCR_OFFSET); ^^^Not initialized any more.
Quoted 7 lines
180 usleep_range(300, 1000); 181 182 return 0; 183 }regards,
dan carpenter
Thanks for report this, I will fix this soon.