Skip to contentSkip to conversation

reset: Fix and extend kerneldoc

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Jul 28, 2020 – Jul 29, 2020 Reset controller framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: Fix and extend kerneldoc

Fix W=1 compile warnings (invalid kerneldoc):

drivers/reset/core.c:50: warning: Function parameter or member 'array' not described in 'reset_control' drivers/reset/core.c:50: warning: Function parameter or member 'deassert_count' not described in 'reset_control'

---
 drivers/reset/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/reset/core.c +2 -1
index 01c0c7aa835c..a2df88e90011 100644
@@ -32,7 +32,8 @@ static LIST_HEAD(reset_lookup_list);
  * @refcnt: Number of gets of this reset_control
  * @acquired: Only one reset_control may be acquired for a given rcdev and id.
  * @shared: Is this a shared (1), or an exclusive (0) reset_control?
- * @deassert_cnt: Number of times this reset line has been deasserted
+ * @array: Is this an array of reset controls (1)?
+ * @deassert_count: Number of times this reset line has been deasserted
  * @triggered_count: Number of times this reset line has been reset. Currently
  *                   only used for shared resets, which means that the value
  *                   will be either 0 or 1.
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Hi Krzysztof,

Quoted 15 lines · Krzysztof Kozlowski

Fix W=1 compile warnings (invalid kerneldoc):

drivers/reset/core.c:50: warning: Function parameter or member 'array' not described in 'reset_control' drivers/reset/core.c:50: warning: Function parameter or member 'deassert_count' not described in 'reset_control'

---
 drivers/reset/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/reset/core.c +0 -0
index 01c0c7aa835c..a2df88e90011 100644

drivers/reset/core.c static LIST_HEAD(reset_lookup_list); · line 39

Quoted 9 lines
drivers/reset/core.c +2 -1
@@ -32,7 +32,8 @@ static LIST_HEAD(reset_lookup_list);
  * @refcnt: Number of gets of this reset_control
  * @acquired: Only one reset_control may be acquired for a given rcdev and id.
  * @shared: Is this a shared (1), or an exclusive (0) reset_control?
- * @deassert_cnt: Number of times this reset line has been deasserted
+ * @array: Is this an array of reset controls (1)?
+ * @deassert_count: Number of times this reset line has been deasserted
  * @triggered_count: Number of times this reset line has been reset. Currently
  *                   only used for shared resets, which means that the value
  *                   will be either 0 or 1.

Thank you for the fix, applied to reset/next.

regards
Philipp