anon_inodes: Make _anon_inode_getfile() static
Subsystems (5)
PATCH 1/4 anon_inodes: Make _anon_inode_getfile() static
_anon_inode_getfile() function is not used outside so make it static to fix W=1 warning:
fs/anon_inodes.c:80:14: warning: no previous prototype for '_anon_inode_getfile' [-Wmissing-prototypes]
80 | struct file *_anon_inode_getfile(const char *name,
--- fs/anon_inodes.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
fs/anon_inodes.c +5 -5
@@ -77,11 +77,11 @@ static struct inode *anon_inode_make_secure_inode(return inode; } -struct file *_anon_inode_getfile (const char *name, -const struct file_operations *fops, -void *priv,int flags, -const struct inode *context_inode, -bool secure) +static struct file *_anon_inode_getfile (const char *name, +const struct file_operations *fops, +void *priv,int flags, +const struct inode *context_inode, +bool secure) {struct inode *inode;struct file *file;
Signature · 1 line
2.17.1
PATCH 2/4 mm: swap: Fix kerneldoc of swap_vma_readahead()
Fix W=1 compile warnings (invalid kerneldoc):
mm/swap_state.c:742: warning: Function parameter or member 'fentry' not described in 'swap_vma_readahead' mm/swap_state.c:742: warning: Excess function parameter 'entry' description in 'swap_vma_readahead'
--- mm/swap_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/swap_state.c +1 -1
@@ -725,7 +725,7 @@ static void swap_ra_info(struct vm_fault *vmf,/** * swap_vma_readahead - swap in pages in hope we need them soon -* @entry: swap entry of this memory +* @fentry: swap entry of this memory * @gfp_mask: memory allocation flags * @vmf: fault information *
Signature · 1 line
2.17.1
PATCH 3/4 mm: mempolicy: Fix kerneldoc of numa_map_to_online_node()
In reply to Krzysztof KozlowskiFix W=1 compile warnings (invalid kerneldoc):
mm/mempolicy.c:137: warning: Function parameter or member 'node' not described in 'numa_map_to_online_node' mm/mempolicy.c:137: warning: Excess function parameter 'nid' description in 'numa_map_to_online_node'
--- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/mempolicy.c +1 -1
@@ -129,7 +129,7 @@ static struct mempolicy preferred_node_policy[MAX_NUMNODES];/** * numa_map_to_online_node - Find closest online node -* @nid: Node id to start the search +* @node: Node id to start the search * * Lookup the next closest node by distance if @nid is not online. */
Signature · 1 line
2.17.1
PATCH 4/4 mm: mmu_notifier: Fix and extend kerneldoc
In reply to Krzysztof KozlowskiFix W=1 compile warnings (invalid kerneldoc):
mm/mmu_notifier.c:187: warning: Function parameter or member 'interval_sub' not described in 'mmu_interval_read_bgin' mm/mmu_notifier.c:708: warning: Function parameter or member 'subscription' not described in 'mmu_notifier_registr' mm/mmu_notifier.c:708: warning: Excess function parameter 'mn' description in 'mmu_notifier_register' mm/mmu_notifier.c:880: warning: Function parameter or member 'subscription' not described in 'mmu_notifier_put' mm/mmu_notifier.c:880: warning: Excess function parameter 'mn' description in 'mmu_notifier_put' mm/mmu_notifier.c:982: warning: Function parameter or member 'ops' not described in 'mmu_interval_notifier_insert'
--- mm/mmu_notifier.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
mm/mmu_notifier.c +5 -4
@@ -166,7 +166,7 @@ static void mn_itree_inv_end(struct mmu_notifier_subscriptions *subscriptions)/** * mmu_interval_read_begin - Begin a read side critical section against a VA * range -* interval_sub: The interval subscription +* @interval_sub: The interval subscription * * mmu_iterval_read_begin()/mmu_iterval_read_retry() implement a * collision-retry scheme similar to seqcount for the VA range under
@@ -686,7 +686,7 @@ EXPORT_SYMBOL_GPL(__mmu_notifier_register);/** * mmu_notifier_register - Register a notifier on a mm -* @mn: The notifier to attach +* @subscription: The notifier to attach * @mm: The mm to attach the notifier to * * Must not hold mmap_lock nor any other VM related lock when calling
@@ -856,7 +856,7 @@ static void mmu_notifier_free_rcu(struct rcu_head *rcu)/** * mmu_notifier_put - Release the reference on the notifier -* @mn: The notifier to act on +* @subscription: The notifier to act on * * This function must be paired with each mmu_notifier_get(), it releases the * reference obtained by the get. If this is the last reference then process
@@ -965,7 +965,8 @@ static int __mmu_interval_notifier_insert(* @interval_sub: Interval subscription to register * @start: Starting virtual address to monitor * @length: Length of the range to monitor -* @mm : mm_struct to attach to +* @mm: mm_struct to attach to +* @ops: Interval notifier operations to be called on matching events * * This function subscribes the interval notifier for notifications from the * mm. Upon return the ops related to mmu_interval_notifier will be called
Signature · 1 line
2.17.1
Re: [PATCH 4/4] mm: mmu_notifier: Fix and extend kerneldoc
Quoted 9 lines · Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
mm/mmu_notifier.c:187: warning: Function parameter or member 'interval_sub' not described in 'mmu_interval_read_bgin'mm/mmu_notifier.c:708: warning: Function parameter or member 'subscription' not described in 'mmu_notifier_registr'mm/mmu_notifier.c:708: warning: Excess function parameter 'mn' description in 'mmu_notifier_register'mm/mmu_notifier.c:880: warning: Function parameter or member 'subscription' not described in 'mmu_notifier_put'mm/mmu_notifier.c:880: warning: Excess function parameter 'mn' description in 'mmu_notifier_put'mm/mmu_notifier.c:982: warning: Function parameter or member 'ops' not described in 'mmu_interval_notifier_insert'
Quoted 4 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- mm/mmu_notifier.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Thanks,
Jason