Skip to contentSkip to conversation

package/prosody: fix dependency

PATCH New Francois Perrad 4 participants 6 messages Jul 28, 2020 – Aug 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/prosody: fix dependency

LuaBitOp is not available with Lua 5.3

---
 package/prosody/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/prosody/Config.in +1 -1
index 4b7ea9425..bb3a5025f 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_PROSODY
 	depends on BR2_USE_MMU # fork
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
 	depends on !BR2_STATIC_LIBS # luaexpat, luasec, luasocket, luafilesystem
-	select BR2_PACKAGE_LUABITOP if !BR2_PACKAGE_LUAJIT # runtime
+	select BR2_PACKAGE_LUABITOP if BR2_PACKAGE_LUA_5_1 # runtime
 	select BR2_PACKAGE_LUAEXPAT # runtime
 	select BR2_PACKAGE_LUASEC # runtime
 	select BR2_PACKAGE_LUASOCKET # runtime
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/prosody: fix dependency

Quoted 12 lines · On Tue, 28 Jul 2020 08:21:40 +0200 Francois Perrad <[email protected]> wrote:

LuaBitOp is not available with Lua 5.3

---
 package/prosody/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/prosody/Config.in +0 -0
index 4b7ea9425..bb3a5025f 100644

package/prosody/Config.in config BR2_PACKAGE_PROSODY · line 6

Quoted 5 lines
package/prosody/Config.in +1 -1
@@ -3,7 +3,7 @@ config BR2_PACKAGE_PROSODY
 	depends on BR2_USE_MMU # fork
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
 	depends on !BR2_STATIC_LIBS # luaexpat, luasec, luasocket, luafilesystem
-	select BR2_PACKAGE_LUABITOP if !BR2_PACKAGE_LUAJIT # runtime
+	select BR2_PACKAGE_LUABITOP if BR2_PACKAGE_LUA_5_1 # runtime

The commit log is probably not very clear. Indeed, if LuaBitOp is not available with Lua 5.3, one would think you would need the external BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the opposite of what your change is doing.

Shouldn't the commit log rather be:

The luabitop functionality is available built-in in Lua 5.3 and LuaJIT, so only Lua 5.1 needs the additional external luabitop package.

Could you confirm ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/prosody: fix dependency

Le mar. 28 juil. 2020 ? 09:21, Thomas Petazzoni <
[email protected]> a ?crit :

Quoted 27 lines
Quoted 12 lines · On Tue, 28 Jul 2020 08:21:40 +0200 Francois Perrad <[email protected]> wrote:

LuaBitOp is not available with Lua 5.3

---
 package/prosody/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/prosody/Config.in +0 -0
index 4b7ea9425..bb3a5025f 100644

package/prosody/Config.in config BR2_PACKAGE_PROSODY · line 5

Quoted 3 lines
package/prosody/Config.in +0 -0
@@ -3,7 +3,7 @@ config BR2_PACKAGE_PROSODY
      depends on BR2_USE_MMU # fork
      depends on BR2_PACKAGE_HAS_LUAINTERPRETER
      depends on !BR2_STATIC_LIBS # luaexpat, luasec, luasocket,

luafilesystem

package/prosody/Config.in config BR2_PACKAGE_PROSODY · line 6

Quoted 2 lines
package/prosody/Config.in +1 -1
-     select BR2_PACKAGE_LUABITOP if !BR2_PACKAGE_LUAJIT # runtime
+     select BR2_PACKAGE_LUABITOP if BR2_PACKAGE_LUA_5_1 # runtime

The commit log is probably not very clear. Indeed, if LuaBitOp is not available with Lua 5.3, one would think you would need the external BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the opposite of what your change is doing.

Quoted 8 lines

Shouldn't the commit log rather be:

The luabitop functionality is available built-in in Lua 5.3 and LuaJIT, so only Lua 5.1 needs the additional external luabitop package.

Could you confirm ?

bitwise operators are built-in in Lua 5.3,
LuaBitOp is a built-in library in LuaJIT,
so only Lua 5.1 needs the additional external LuaBitOp package.

Fran?ois

Quoted 11 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200728/968fc8c0/attachment.html>

#3 lore raw

PATCH 1/1 package/prosody: fix dependency

Fran?ois, All,

On 2020-07-28 11:21 +0200, Fran?ois Perrad spake thusly:

Quoted 13 lines

Le?mar. 28 juil. 2020 ??09:21, Thomas Petazzoni < [1][email protected]> a ?crit?:

Quoted 1 line

LuaBitOp is not available with Lua 5.3

The commit log is probably not very clear. Indeed, if LuaBitOp is not available with Lua 5.3, one would think you would need the external BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the opposite of what your change is doing.

Shouldn't the commit log rather be:

? The luabitop functionality is available built-in in Lua 5.3 and ? LuaJIT, so only Lua 5.1 needs the additional external luabitop ? package.

Quoted 5 lines

Could you confirm ?

bitwise operators are built-in in Lua 5.3,
LuaBitOp is a built-in library in LuaJIT,
so only Lua 5.1 needs the additional external LuaBitOp package.

OK, thanks for the explanations.

However, luabitop depends on !lua-5.3, and I see in your latest series that you extended the dependency to !lua-5.4. Maybe we should also fix that, no?

That is, we should have:

config BR2_PACKAGE_LUABITOP
depends on BR2_PACKAGE_LUA_5_1

However, you are saying (emphasize mine):

"only Lua 5.1 **needs** the additional external LuaBitOp"

Does that mean that it can still be used with other versions of Lua?

That is, if we are using lua-5.3, and a package selects luabitop, will this fail to build? To run? In other words, is it a problem if a pacakge ends up using luabitop on another version of lua?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/prosody: fix dependency

Le mar. 28 juil. 2020 ? 22:25, Yann E. MORIN <[email protected]> a ?crit :

Quoted 25 lines

Fran?ois, All,

On 2020-07-28 11:21 +0200, Fran?ois Perrad spake thusly:

Quoted 1 line

Le mar. 28 juil. 2020 ? 09:21, Thomas Petazzoni < [1]

thomas.petazzoni at bootlin.com> a ?crit :

Quoted 12 lines
Quoted 1 line

LuaBitOp is not available with Lua 5.3

The commit log is probably not very clear. Indeed, if LuaBitOp is not available with Lua 5.3, one would think you would need the external BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the opposite of what your change is doing.

Shouldn't the commit log rather be:

The luabitop functionality is available built-in in Lua 5.3 and LuaJIT, so only Lua 5.1 needs the additional external luabitop package.

Quoted 5 lines

Could you confirm ?

bitwise operators are built-in in Lua 5.3,
LuaBitOp is a built-in library in LuaJIT,
so only Lua 5.1 needs the additional external LuaBitOp package.

OK, thanks for the explanations.

Quoted 10 lines

However, luabitop depends on !lua-5.3, and I see in your latest series that you extended the dependency to !lua-5.4. Maybe we should also fix that, no?

That is, we should have:

config BR2_PACKAGE_LUABITOP
depends on BR2_PACKAGE_LUA_5_1

Correct.

Quoted 11 lines

However, you are saying (emphasize mine):

"only Lua 5.1 **needs** the additional external LuaBitOp"

Does that mean that it can still be used with other versions of Lua?

That is, if we are using lua-5.3, and a package selects luabitop, will this fail to build? To run? In other words, is it a problem if a pacakge ends up using luabitop on another version of lua?

LuaBitOp fails to build with Lua 5.3 & 5.4.
LuaBitOp could be built with :
- Lua 5.1
- Lua 5.2 which is now retired of BR
- LuaJIT which uses ABI 5.1, but useless (because already built-in)

Fran?ois

Regards,

Quoted 14 lines

Yann E. MORIN.

--

.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
     |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
 conspiracy.  |
Quoted 2 lines

'------------------------------^-------^------------------^--------------------'

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200729/91089045/attachment.html>

#5 lore raw

PATCH 1/1 package/prosody: fix dependency

In reply to Francois Perrad
Quoted 6 lines · On Tue, 28 Jul 2020 08:21:40 +0200 Francois Perrad <[email protected]> wrote:

LuaBitOp is not available with Lua 5.3

---
 package/prosody/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master with an improved commit log. Thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com