platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
PATCH 1/1 platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
usb_role_switch_set_role() has the second argument as enum for usb_role. Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. This eventually translates to USB_ROLE_NONE in case of UFP and USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of UFP.
--- drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/platform/chrome/cros_ec_typec.c +2 -1
@@ -590,7 +590,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)dev_warn (typec->dev,"Configure muxes failed, err = %d\n" , ret);return usb_role_switch_set_role (typec->ports[port_num]->role_sw, - !!(resp.role &PD_CTRL_RESP_ROLE_DATA )); + resp.role &PD_CTRL_RESP_ROLE_DATA + ?USB_ROLE_HOST :USB_ROLE_DEVICE ); }static int cros_typec_get_cmd_version (struct cros_typec_data *typec)
Signature · 1 line
2.17.1
Hi Azhar,
Quoted 6 lines · Azhar Shaikh
usb_role_switch_set_role()has the second argument as enum forusb_role. Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. This eventually translates toUSB_ROLE_NONEin case of UFP andUSB_ROLE_DEVICEin case of DFP. Correct this by sending correct enum values asUSB_ROLE_DEVICEin case of UFP andUSB_ROLE_HOSTin case of UFP.
nit: DFP
Quoted 4 lines
Fixes 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")Signed-off-by Azhar Shaikh <[email protected]>Cc Prashant Malani <[email protected]>
Quoted 21 lines
--- drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/platform/chrome/cros_ec_typec.c +2
-1@@ -590,7 +590,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)dev_warn (typec->dev,"Configure muxes failed, err = %d\n" , ret);return usb_role_switch_set_role (typec->ports[port_num]->role_sw, - !!(resp.role &PD_CTRL_RESP_ROLE_DATA )); + resp.role &PD_CTRL_RESP_ROLE_DATA + ?USB_ROLE_HOST :USB_ROLE_DEVICE ); }static int cros_typec_get_cmd_version (struct cros_typec_data *typec)Signature · 1 line
2.17.1