configs: pico-imx6ul: convert DM_VIDEO
PATCH 2/3 configs: pico-imx6ul: convert DM_VIDEO
From: Wig Cheng <[email protected]>
Fix compile warning messages.
--- configs/pico-imx6ul_defconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
configs/pico-imx6ul_defconfig +5 -1
@@ -75,4 +75,8 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y +CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0 +# CONFIG_CMD_VIDCONSOLE is not set +# CONFIG_VIDEO_BPP8 is not set +# CONFIG_VIDEO_BPP16 is not set
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH 2/3 configs: pico-imx6ul: convert DM_VIDEO
Quoted 15 lines · On Tue, Jul 28, 2020 at 11:35 PM <[email protected]> wrote:
From: Wig Cheng <[email protected]>
Fix compile warning messages.
Signed-off-by Wig Cheng <[email protected]>--- configs/pico-imx6ul_defconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)configs/pico-imx6ul_defconfig +0
-0
configs/pico-imx6ul_defconfig CONFIG_USB_GADGET_MANUFACTURER="FSL" · line 79
Quoted 6 lines
configs/pico-imx6ul_defconfig +2
-1@@ -75,4 +75,8 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y +CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0
Why is this one needed?
PATCH 2/3 configs: pico-imx6ul: convert DM_VIDEO
Quoted 10 lines · Fabio Estevam
Quoted 9 lines · On Tue, Jul 28, 2020 at 11:35 PM <[email protected]> wrote:
From: Wig Cheng <[email protected]>
Fix compile warning messages.
Signed-off-by Wig Cheng <[email protected]>--- configs/pico-imx6ul_defconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Quoted 12 lines
configs/pico-imx6ul_defconfig CONFIG_USB_GADGET_MANUFACTURER="FSL" · line 79
Quoted 11 lines
configs/pico-imx6ul_defconfig +2
-1@@ -75,4 +75,8 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y +CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0Why is this one needed?
It shows warning messages after compiled:
===================== WARNING ====================== This board does not use CONFIG_DM_VIDEO Please update the board to use CONFIG_DM_VIDEO before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info.
====================================================
Enable DM_VIDEO will be solved this warning although there's no difference no matter enable DM_VIDEO or not on runtime level, just for warning message.
I'll improve the commit log if you think it's okay, thanks a lot.
Fabio Estevam
reviewerPATCH 2/3 configs: pico-imx6ul: convert DM_VIDEO
Quoted 9 lines · wig
It shows warning messages after compiled:
===================== WARNING ====================== This board does not use
CONFIG_DM_VIDEOPlease update the board to useCONFIG_DM_VIDEObefore the v2019.07 release. Failure to update by the deadline may result in board removal. Seedoc/driver-model/migration.rstfor more info.
====================================================
Quoted 5 lines
Enable
DM_VIDEOwill be solved this warning although there's no difference no matter enableDM_VIDEOor not on runtime level, just for warning message.I'll improve the commit log if you think it's okay, thanks a lot.
Yes, with the improved commit log and removing CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0 the patch will be good.
Thanks
Fabio Estevam
reviewerPATCH 2/3 configs: pico-imx6ul: convert DM_VIDEO
In reply to wig.cheng at technexion.comQuoted 4 lines · On Tue, Jul 28, 2020 at 11:35 PM <[email protected]> wrote:
From: Wig Cheng <[email protected]>
Fix compile warning messages.
One more thing: you did a good job in writing the commit logs for the other patches, but this one needs to be improved.