Skip to contentSkip to conversation

xfs/010,030: filter AG header CRC error warnings

PATCH In review Darrick J. Wong 3 participants 5 messages Jul 29, 2020 – Aug 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/010,030: filter AG header CRC error warnings

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

---
 tests/xfs/010 |    7 ++++++-
 tests/xfs/030 |    2 ++
 2 files changed, 8 insertions(+), 1 deletion(-)
tests/xfs/010 +6 -1
index e220a651..b65dd3ba 100755
@@ -113,7 +113,12 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' | \
+		_filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
tests/xfs/030 +2 -0
index efdb6a18..ebe4c92a 100755
@@ -42,6 +42,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for finobt/d' \
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'
 	done
#1 lore raw
Quoted 7 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

---

Hi Darrick,

I still hit an error[1] on xfs/030 after merge your patch.

Thanks,
Zorro

# diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad                                                          
--- /root/git/xfstests-dev/tests/xfs/030.out    2020-03-12 11:22:50.063148796 +0800
+++ /root/git/xfstests-dev/results//xfs/030.out.bad     2020-07-29 12:33:08.485428533 +0800
@@ -105,6 +105,7 @@
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...
Quoted 36 lines
 tests/xfs/010 |    7 ++++++-
 tests/xfs/030 |    2 ++
 2 files changed, 8 insertions(+), 1 deletion(-)
tests/xfs/010 +6 -1
index e220a651..b65dd3ba 100755
@@ -113,7 +113,12 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' | \
+		_filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
tests/xfs/030 +2 -0
index efdb6a18..ebe4c92a 100755
@@ -42,6 +42,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for finobt/d' \
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'
 	done
#2 lore raw
Quoted 6 lines · Zorro Lang
Quoted 5 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

Quoted 6 lines
Quoted 2 lines

---

Hi Darrick,

I still hit an error[1] on xfs/030 after merge your patch.

D'oh, I forgot to send that one out in this batch. Will fix that shortly.

--D

Quoted 52 lines

Thanks,
Zorro

# diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad                                                          
root/git/xfstests-dev/results//xfs/030.out.bad 2020-07-29 12:33:08.485428533 +0800 renamed from root/git/xfstests-dev/tests/xfs/030.out 2020-03-12 11:22:50.063148796 +0800 +1 -0
@@ -105,6 +105,7 @@
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...
Quoted 37 lines
 tests/xfs/010 |    7 ++++++-
 tests/xfs/030 |    2 ++
 2 files changed, 8 insertions(+), 1 deletion(-)
tests/xfs/010 +6 -1
index e220a651..b65dd3ba 100755
@@ -113,7 +113,12 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' | \
+		_filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
tests/xfs/030 +2 -0
index efdb6a18..ebe4c92a 100755
@@ -42,6 +42,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for finobt/d' \
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'
 	done
#3 lore raw

Hi Darrick, Eryu

It seems that fstests missed this patch. I used lastest xfsprogs (include commit a891d871 xfs_repair: complain about ag header crc errors) and xfs/030 still fails because of CRC verification warnings.

Best Regards
Yang Xu

Quoted 73 lines · Zorro Lang
Quoted 6 lines · Darrick J. Wong
Quoted 5 lines

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

Quoted 6 lines
Quoted 2 lines

---

Hi Darrick,

I still hit an error[1] on xfs/030 after merge your patch.

D'oh, I forgot to send that one out in this batch. Will fix that shortly.

--D

Quoted 52 lines

Thanks,
Zorro

# diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad
root/git/xfstests-dev/results//xfs/030.out.bad 2020-07-29 12:33:08.485428533 +0800 renamed from root/git/xfstests-dev/tests/xfs/030.out 2020-03-12 11:22:50.063148796 +0800 +1 -0
@@ -105,6 +105,7 @@
  Phase 2 - using <TYPEOF> log
          - zero log...
          - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
          - found root inode chunk
  Phase 3 - for each AG...
          - scan and clear agi unlinked lists...
Quoted 37 lines
  tests/xfs/010 |    7 ++++++-
  tests/xfs/030 |    2 ++
  2 files changed, 8 insertions(+), 1 deletion(-)
tests/xfs/010 +6 -1
index e220a651..b65dd3ba 100755
@@ -113,7 +113,12 @@ _check_scratch_fs
  # nuke the finobt root, repair will have to regenerate from the inobt
  _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' | \
+		_filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
  status=0
  exit
tests/xfs/030 +2 -0
index efdb6a18..ebe4c92a 100755
@@ -42,6 +42,8 @@ _check_ag()
  			    -e '/^bad agbno AGBNO for finobt/d' \
  			    -e '/^bad agbno AGBNO for rmapbt/d' \
  			    -e '/^bad agbno AGBNO for refcntbt/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
  			    -e '/^Missing reverse-mapping record.*/d' \
  			    -e '/^unknown block state, ag AGNO, block.*/d'
  	done
#4 lore raw

Hi Darrick,Eryu

ping. Or I miss something?

Quoted 79 lines

Hi Darrick, Eryu

It seems that fstests missed this patch. I used lastest xfsprogs (include commit a891d871 xfs_repair: complain about ag header crc errors) and xfs/030 still fails because of CRC verification warnings.

Best Regards
Yang Xu

Quoted 73 lines · Zorro Lang
Quoted 6 lines · Darrick J. Wong
Quoted 5 lines

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

Quoted 6 lines
Quoted 2 lines

---

Hi Darrick,

I still hit an error[1] on xfs/030 after merge your patch.

D'oh, I forgot to send that one out in this batch.  Will fix that shortly.

--D

Quoted 52 lines

Thanks,
Zorro

# diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad
--- /root/git/xfstests-dev/tests/xfs/030.out    2020-03-12 
11:22:50.063148796 +0800
+++ /root/git/xfstests-dev/results//xfs/030.out.bad     2020-07-29 
12:33:08.485428533 +0800
(quoted diff) +0 -0
@@ -105,6 +105,7 @@

  Phase 2 - using <TYPEOF> log
          - zero log...
          - scan filesystem freespace and inode maps... +bad agbno AGBNO in agfl, agno 0
          - found root inode chunk
  Phase 3 - for each AG...
          - scan and clear agi unlinked lists...

Quoted 34 lines

  tests/xfs/010 |    7 ++++++-
  tests/xfs/030 |    2 ++

  2 files changed, 8 insertions(+), 1 deletion(-)
tests/xfs/010 +0 -0
index e220a651..b65dd3ba 100755
@@ -113,7 +113,12 @@ _check_scratch_fs
   # nuke the finobt root, repair will have to regenerate from the inobt

  _corrupt_finobt_root $SCRATCH_DEV

tests/xfs/010 +6 -1
-_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
+filter_finobt_repair() {
+    sed -e '/^agi has bad CRC/d' | \
+        _filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair

  status=0
  exit

tests/xfs/030 +2 -0
index efdb6a18..ebe4c92a 100755
@@ -42,6 +42,8 @@ _check_ag()
                   -e '/^bad agbno AGBNO for finobt/d' \
                   -e '/^bad agbno AGBNO for rmapbt/d' \
                   -e '/^bad agbno AGBNO for refcntbt/d' \
+                -e '/^agf has bad CRC/d' \
+                -e '/^agi has bad CRC/d' \
                   -e '/^Missing reverse-mapping record.*/d' \

                  -e '/^unknown block state, ag AGNO, block.*/d' done