examples/vm_power_manager: fix resource leak
PATCH 1/1 examples/vm_power_manager: fix resource leak
Fix memory leak where variable oob_enable can go out of scope leaking the storage it points to.
Coverity issue: 337674
--- examples/vm_power_manager/main.c | 1 + 1 file changed, 1 insertion(+)
examples/vm_power_manager/main.c +1 -0
@@ -209,6 +209,7 @@ parse_args(int argc, char **argv) }if (branch_ratio <=0.0 || branch_ratio >100.0 ) {printf ("invalid branch ratio specified\n" ); +free (oob_enable);return -1 ; }for (i =0 ; i < ci->core_count; i++) {
Signature · 1 line
2.25.1
Hi Rory,
Quoted 16 lines · Rory Sexton
Fix memory leak where variable
oob_enablecan go out of scope leaking the storage it points to.Coverity issue: 337674
Fixes 95f648ff9ee ("examples/vm_power: make branch ratio threshold per core")Signed-off-by Rory Sexton <[email protected]>--- examples/vm_power_manager/main.c | 1 + 1 file changed, 1 insertion(+)examples/vm_power_manager/main.c +0
-0
examples/vm_power_manager/main.c parse_args(int argc, char **argv) · line 215
Quoted 7 lines
examples/vm_power_manager/main.c +1
-0@@ -209,6 +209,7 @@ parse_args(int argc, char **argv) }if (branch_ratio <=0.0 || branch_ratio >100.0 ) {printf ("invalid branch ratio specified\n" ); +free (oob_enable);return -1 ; }for (i =0 ; i < ci->core_count; i++) {
Quoted 8 lines · Rory Sexton
Fix memory leak where variable
oob_enablecan go out of scope leaking the storage it points to.Coverity issue: 337674
Fixes 95f648ff9ee ("examples/vm_power: make branch ratio threshold per core")Signed-off-by Rory Sexton <[email protected]>
Applied, thanks Rory.
There is another issue in this code.
Previous branches part of the 'b' option handling will break from the parsing loop and have the parse_args() function return the option index where it stopped.
This should instead report a parsing error and have the app fail to initialise.
Something like:
examples/vm_power_manager/main.c +2 -2
@@ -194,7 +194,7 @@ parse_args(int argc, char **argv)"core-branch-ratio matrix - [%s]\n" , optarg);free (oob_enable); -break ; +return -1 ; } cnt =parse_branch_ratio (optarg, &branch_ratio);if (cnt <0 ) {
@@ -202,7 +202,7 @@ parse_args(int argc, char **argv)"core-branch-ratio matrix - [%s]\n" , optarg);free (oob_enable); -break ; +return -1 ; }if (branch_ratio <=0.0 || branch_ratio >100.0 ) {printf ("invalid branch ratio specified\n" );
Could you test this and send a followup patch?
Thanks.
Signature · 1 line
David Marchand